[GitHub] [tomcat] martin-g commented on pull request #382: Add support for unix domain sockets.

martin-g commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-736282608 Even if the Tomcat dev team decides to drop support for the APR connector I don't see a problem the code to be extracted to a new project and be supported by the community.

[GitHub] [tomcat] minfrin commented on a change in pull request #382: Add support for unix domain sockets.

minfrin commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532990550 ## File path: java/org/apache/tomcat/util/net/AprEndpoint.java ## @@ -292,52 +295,79 @@ public void bind() throws Exception { // Create the pool f

[GitHub] [tomcat] minfrin commented on a change in pull request #382: Add support for unix domain sockets.

minfrin commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532981406 ## File path: java/org/apache/coyote/AbstractProtocol.java ## @@ -351,12 +351,15 @@ public String getName() { private String getNameInternal() {

[GitHub] [tomcat] michael-o commented on a change in pull request #382: Add support for unix domain sockets.

michael-o commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532913829 ## File path: java/org/apache/coyote/AbstractProtocol.java ## @@ -351,12 +351,15 @@ public String getName() { private String getNameInternal() {

[GitHub] [tomcat] minfrin commented on a change in pull request #382: Add support for unix domain sockets.

minfrin commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532903806 ## File path: java/org/apache/coyote/AbstractProtocol.java ## @@ -351,12 +351,15 @@ public String getName() { private String getNameInternal() {

[Bug 63802] epoll spin detection is missing

https://bz.apache.org/bugzilla/show_bug.cgi?id=63802 --- Comment #6 from Mark Thomas --- I ran 10 tests with Java 11 and didn't see the issue. The developer of the reproducer also confirmed the issue is fixed in Java 11. I'm happy to implement a work-around but I'd be equally happy with closing

[GitHub] [tomcat] michael-o commented on a change in pull request #382: Add support for unix domain sockets.

michael-o commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532875949 ## File path: java/org/apache/coyote/AbstractProtocol.java ## @@ -351,12 +351,15 @@ public String getName() { private String getNameInternal() {

[GitHub] [tomcat] minfrin commented on a change in pull request #382: Add support for unix domain sockets.

minfrin commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532862975 ## File path: java/org/apache/coyote/AbstractProtocol.java ## @@ -351,12 +351,15 @@ public String getName() { private String getNameInternal() {

[GitHub] [tomcat] michael-o commented on a change in pull request #382: Add support for unix domain sockets.

michael-o commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532841983 ## File path: java/org/apache/coyote/AbstractProtocol.java ## @@ -351,12 +351,15 @@ public String getName() { private String getNameInternal() {

[GitHub] [tomcat] minfrin commented on a change in pull request #382: Add support for unix domain sockets.

minfrin commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532818744 ## File path: java/org/apache/tomcat/jni/Library.java ## @@ -244,6 +247,7 @@ public static synchronized boolean initialize(String libraryName) throws Except

[GitHub] [tomcat] minfrin commented on a change in pull request #382: Add support for unix domain sockets.

minfrin commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532815444 ## File path: java/org/apache/coyote/AbstractProtocol.java ## @@ -347,22 +352,27 @@ public String getName() { private String getNameInternal() {

Re: JDK 16 Early Access build 26 is now available

Hi Marc, Let me see what we can do. Rgds,Rory On 30/11/2020 14:47, Mark Thomas wrote: Hi Rory, I have been (slowly) working my way through the currently open issues and I found time time today to investigate this one: https://urldefense.com/v3/__https://bz.apache.org/bugzilla/show_bug.cgi?id=

[GitHub] [tomcat] minfrin commented on a change in pull request #382: Add support for unix domain sockets.

minfrin commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532732287 ## File path: java/org/apache/tomcat/jni/Library.java ## @@ -247,7 +247,7 @@ public static synchronized boolean initialize(String libraryName) throws Except

[GitHub] [tomcat] minfrin commented on pull request #382: Add support for unix domain sockets.

minfrin commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-735896671 > Nobody has cared about UDS for the past 15 years. And PEM files are supported for JSSE and JSSE/OpenSSL. So I don't understand what the problem is. While you may not have c

[GitHub] [tomcat] michael-o commented on pull request #382: Add support for unix domain sockets.

michael-o commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-735887225 > > > > > > That's correct, it was supposed to be dropped already in 10.0 [it will happen in 10.1]. Instead, it got some defaults changes so that using it requires more d

[GitHub] [tomcat] michael-o commented on a change in pull request #382: Add support for unix domain sockets.

michael-o commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532716306 ## File path: java/org/apache/tomcat/util/net/AprEndpoint.java ## @@ -292,52 +295,79 @@ public void bind() throws Exception { // Create the pool

[GitHub] [tomcat] rmaucher commented on pull request #382: Add support for unix domain sockets.

rmaucher commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-735880429 > > > That's correct, it was supposed to be dropped already in 10.0 [it will happen in 10.1]. Instead, it got some defaults changes so that using it requires more deliberate confi

[GitHub] [tomcat] minfrin commented on a change in pull request #382: Add support for unix domain sockets.

minfrin commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532706511 ## File path: java/org/apache/tomcat/util/net/AprEndpoint.java ## @@ -292,52 +295,79 @@ public void bind() throws Exception { // Create the pool f

[GitHub] [tomcat] minfrin commented on a change in pull request #382: Add support for unix domain sockets.

minfrin commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532695851 ## File path: java/org/apache/tomcat/jni/Library.java ## @@ -247,7 +247,7 @@ public static synchronized boolean initialize(String libraryName) throws Except

[GitHub] [tomcat] michael-o commented on a change in pull request #382: Add support for unix domain sockets.

michael-o commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532692425 ## File path: java/org/apache/tomcat/jni/Library.java ## @@ -247,7 +247,7 @@ public static synchronized boolean initialize(String libraryName) throws Exce

[GitHub] [tomcat] michael-o commented on a change in pull request #382: Add support for unix domain sockets.

michael-o commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532692219 ## File path: java/org/apache/tomcat/util/net/AprEndpoint.java ## @@ -292,52 +295,79 @@ public void bind() throws Exception { // Create the pool

[GitHub] [tomcat] michael-o commented on pull request #382: Add support for unix domain sockets.

michael-o commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-735864234 > > > > That's correct, it was supposed to be dropped already in 10.0 [it will happen in 10.1]. Instead, it got some defaults changes so that using it requires more delib

[GitHub] [tomcat] minfrin commented on pull request #382: Add support for unix domain sockets.

minfrin commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-735859022 > That's correct, it was supposed to be dropped already in 10.0 [it will happen in 10.1]. Instead, it got some defaults changes so that using it requires more deliberate configurat

[GitHub] [tomcat] minfrin commented on a change in pull request #382: Add support for unix domain sockets.

minfrin commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532682814 ## File path: java/org/apache/tomcat/util/net/AbstractEndpoint.java ## @@ -568,6 +569,14 @@ public final int getLocalPort() { protected abstract InetSoc

[GitHub] [tomcat] minfrin commented on a change in pull request #382: Add support for unix domain sockets.

minfrin commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532677929 ## File path: java/org/apache/tomcat/util/net/AprEndpoint.java ## @@ -292,52 +295,79 @@ public void bind() throws Exception { // Create the pool f

[GitHub] [tomcat] minfrin commented on a change in pull request #382: Add support for unix domain sockets.

minfrin commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532674722 ## File path: java/org/apache/tomcat/jni/Library.java ## @@ -244,6 +247,7 @@ public static synchronized boolean initialize(String libraryName) throws Except

[Bug 63802] epoll spin detection is missing

https://bz.apache.org/bugzilla/show_bug.cgi?id=63802 --- Comment #5 from Remy Maucherat --- Ok, so there's a reproducer for this now. It's supposedly fixed in Java 11. Personally, given the ugliness of the workaround, the rarity of the issue and the fact that there's a fix, I would rather not do

[GitHub] [tomcat] minfrin commented on a change in pull request #382: Add support for unix domain sockets.

minfrin commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532669016 ## File path: java/org/apache/tomcat/jni/Library.java ## @@ -177,6 +177,9 @@ private Library(String libraryName) /* Is the O_NONBLOCK flag inherited fro

[GitHub] [tomcat] minfrin commented on a change in pull request #382: Add support for unix domain sockets.

minfrin commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532667538 ## File path: webapps/docs/config/http.xml ## @@ -212,7 +212,11 @@ Where supported, the path to a unix domain socket that this Connector will c

[GitHub] [tomcat] minfrin commented on a change in pull request #382: Add support for unix domain sockets.

minfrin commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532665610 ## File path: java/org/apache/tomcat/util/net/AprEndpoint.java ## @@ -292,52 +295,79 @@ public void bind() throws Exception { // Create the pool f

[Bug 64943] [Patch] Add support for Unix Domain Sockets to org.apache.coyote.http11.Http11AprProtocol

https://bz.apache.org/bugzilla/show_bug.cgi?id=64943 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement --- Comment #2 from Mark Tho

[Bug 63802] epoll spin detection is missing

https://bz.apache.org/bugzilla/show_bug.cgi?id=63802 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #4 from Mark Thomas ---

Re: JDK 16 Early Access build 26 is now available

Hi Rory, I have been (slowly) working my way through the currently open issues and I found time time today to investigate this one: https://bz.apache.org/bugzilla/show_bug.cgi?id=63802 That led me to this OpenJDK bug: https://bugs.openjdk.java.net/browse/JDK-8238279 I have spent some time lookin

Re: JDK 16 Early Access build 26 is now available

Thanks for the feedback Martin! On 30/11/2020 09:37, Martin Grigorov wrote: Hi Rory, Apache Tomcat's build and tests pass with JDK 16 b26 on Ubuntu 20.04.1 (x86_64 & aarch64)! Regards, Martin On Fri, Nov 27, 2020 at 1:15 PM Rory O'Donnell mailto:rory.odonn...@oracle.com>> wrote: Hi M

[Bug 56890] getRealPath returns null

https://bz.apache.org/bugzilla/show_bug.cgi?id=56890 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[tomcat] branch 8.5.x updated: Fix BZ 56890 - Clarification of ServletContext.getRealPath(String)

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new a3ec494 Fix BZ 56890 - Clarification of ServletCo

[tomcat] branch 9.0.x updated: Fix BZ 56890 - Clarification of ServletContext.getRealPath(String)

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new a48767b Fix BZ 56890 - Clarification of ServletCo

Re: JDK 16 Early Access build 26 is now available

On Fri, Nov 27, 2020 at 12:15 PM Rory O'Donnell wrote: > Hi Mark, > > OpenJDK 16 Early Access build 26**is now available at > http://jdk.java.net/16 > > * These early-access , open-source builds are provided under the > o GNU General Public License, version 2, with the Classpath >

[tomcat] branch master updated (5da6295 -> 37f8bf5)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 5da6295 Fix BZ 94944 - correct bytesSent when compression is enabled add 37f8bf5 Fix BZ 56890 - Clarification o

[GitHub] [tomcat] rmaucher commented on pull request #382: Add support for unix domain sockets.

rmaucher commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-735789759 That's correct, it was supposed to be dropped already in 10.0 [it will happen in 10.1]. Instead, it got some defaults changes so that using it requires more deliberate configurati

[GitHub] [tomcat] martin-g commented on pull request #382: Add support for unix domain sockets.

martin-g commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-735780186 By the way, there were talks at dev@ about dropping/deprecating AprProtocol and recommending the use of NIO(2). Maybe for 10.1.x, not decided yet. ---

[Bug 56890] getRealPath returns null

https://bz.apache.org/bugzilla/show_bug.cgi?id=56890 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #9 from Mark Thomas ---

[GitHub] [tomcat] michael-o commented on a change in pull request #382: Add support for unix domain sockets.

michael-o commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532587344 ## File path: java/org/apache/tomcat/util/net/AbstractEndpoint.java ## @@ -568,6 +569,14 @@ public final int getLocalPort() { protected abstract InetS

[Bug 64944] Incorrect bytesSent metric when compression is enabled

https://bz.apache.org/bugzilla/show_bug.cgi?id=64944 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[GitHub] [tomcat] michael-o commented on a change in pull request #382: Add support for unix domain sockets.

michael-o commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532584495 ## File path: java/org/apache/tomcat/jni/Library.java ## @@ -177,6 +177,9 @@ private Library(String libraryName) /* Is the O_NONBLOCK flag inherited f

[GitHub] [tomcat] michael-o commented on a change in pull request #382: Add support for unix domain sockets.

michael-o commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532584495 ## File path: java/org/apache/tomcat/jni/Library.java ## @@ -177,6 +177,9 @@ private Library(String libraryName) /* Is the O_NONBLOCK flag inherited f

[tomcat] branch 8.5.x updated: Fix BZ 94944 - correct bytesSent when compression is enabled

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 187c371 Fix BZ 94944 - correct bytesSent when comp

[tomcat] branch 9.0.x updated: Fix BZ 94944 - correct bytesSent when compression is enabled

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 2995fa7 Fix BZ 94944 - correct bytesSent when comp

[tomcat] branch master updated: Fix BZ 94944 - correct bytesSent when compression is enabled

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 5da6295 Fix BZ 94944 - correct bytesSent when co

[GitHub] [tomcat] martin-g commented on pull request #381: Create Documentation installing tomcat on ibm cloud

martin-g commented on pull request #381: URL: https://github.com/apache/tomcat/pull/381#issuecomment-735749630 IMO this document should be part of IBM Cloud documentation. We cannot maintain it. This is an automated message

[GitHub] [tomcat] martin-g commented on a change in pull request #382: Add support for unix domain sockets.

martin-g commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532540970 ## File path: java/org/apache/tomcat/jni/Library.java ## @@ -177,6 +177,9 @@ private Library(String libraryName) /* Is the O_NONBLOCK flag inherited fr

[GitHub] [tomcat] martin-g commented on a change in pull request #380: Fix BZ 64110 - request attr for requested ciphers and protocols

martin-g commented on a change in pull request #380: URL: https://github.com/apache/tomcat/pull/380#discussion_r532527179 ## File path: java/org/apache/catalina/util/TLSUtil.java ## @@ -38,6 +38,8 @@ public static boolean isTLSRequestAttribute(String name) { Gl

[GitHub] [tomcat] michael-o commented on a change in pull request #382: Add support for unix domain sockets.

michael-o commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532523457 ## File path: webapps/docs/config/http.xml ## @@ -1152,6 +1156,11 @@ permissions appropriately configured to restrict access as required. + Tomca

[GitHub] [tomcat] michael-o commented on a change in pull request #382: Add support for unix domain sockets.

michael-o commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532523379 ## File path: webapps/docs/config/http.xml ## @@ -212,7 +212,11 @@ Where supported, the path to a unix domain socket that this Connector will

[GitHub] [tomcat] michael-o commented on a change in pull request #382: Add support for unix domain sockets.

michael-o commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r53252 ## File path: java/org/apache/coyote/AbstractProtocol.java ## @@ -347,22 +352,27 @@ public String getName() { private String getNameInternal() {

[GitHub] [tomcat] michael-o commented on a change in pull request #382: Add support for unix domain sockets.

michael-o commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532520621 ## File path: java/org/apache/tomcat/util/net/AprEndpoint.java ## @@ -292,52 +295,79 @@ public void bind() throws Exception { // Create the pool

[GitHub] [tomcat-native] minfrin commented on a change in pull request #8: Expose support for Unix Domain Sockets in APR v1.6 and up.

minfrin commented on a change in pull request #8: URL: https://github.com/apache/tomcat-native/pull/8#discussion_r532505101 ## File path: native/src/network.c ## @@ -316,6 +337,11 @@ TCN_IMPLEMENT_CALL(jint, Socket, bind)(TCN_STDARGS, jlong sock, TCN_ASSERT(sock != 0);

[GitHub] [tomcat] minfrin commented on a change in pull request #382: Add support for unix domain sockets.

minfrin commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532490661 ## File path: java/org/apache/tomcat/util/net/AprEndpoint.java ## @@ -292,52 +295,79 @@ public void bind() throws Exception { // Create the pool f

Re: JDK 16 Early Access build 26 is now available

Hi Rory, Apache Tomcat's build and tests pass with JDK 16 b26 on Ubuntu 20.04.1 (x86_64 & aarch64)! Regards, Martin On Fri, Nov 27, 2020 at 1:15 PM Rory O'Donnell wrote: > Hi Mark, > > OpenJDK 16 Early Access build 26**is now available at > http://jdk.java.net/16 > > * These early-access , o