minfrin commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r532669016
########## File path: java/org/apache/tomcat/jni/Library.java ########## @@ -177,6 +177,9 @@ private Library(String libraryName) /* Is the O_NONBLOCK flag inherited from listening sockets? */ public static boolean APR_O_NONBLOCK_INHERITED = false; + /* Support for Unix Domain Sockets. + */ + public static boolean APR_HAVE_UNIX = false; Review comment: Over at APR we call it APR_UNIX, it would be better to be consistent with this: https://github.com/apache/apr/blob/trunk/include/apr_network_io.h#L168 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org