minfrin commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532862975
##########
File path: java/org/apache/coyote/AbstractProtocol.java
##########
@@ -351,12 +351,15 @@ public String getName() {
private String getNameInternal() {
StringBuilder name = new StringBuilder(getNamePrefix());
- name.append('-');
if (getPath() != null) {
- name.append(getPath().getFileName().toString());
+ for (Path path: getPath()) {
Review comment:
This is the name of the connector, for example:
```
30-Nov-2020 20:33:08.007 INFO [main]
org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler
["http-nio-8080"]
30-Nov-2020 20:33:08.015 INFO [main]
org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler
["http-apr-tmp-protected-tomcat.socket"]
```
The name "http-apr-/tmp/protected/tomcat.socket" seems ugly to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
