michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532875949



##########
File path: java/org/apache/coyote/AbstractProtocol.java
##########
@@ -351,12 +351,15 @@ public String getName() {
 
     private String getNameInternal() {
         StringBuilder name = new StringBuilder(getNamePrefix());
-        name.append('-');
         if (getPath() != null) {
-            name.append(getPath().getFileName().toString());
+            for (Path path: getPath()) {

Review comment:
       While it seems ugly, it makes it perfectly clear that it is a path on 
the local filesystem, doesn't it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to