michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532522222
##########
File path: java/org/apache/coyote/AbstractProtocol.java
##########
@@ -347,22 +352,27 @@ public String getName() {
private String getNameInternal() {
StringBuilder name = new StringBuilder(getNamePrefix());
name.append('-');
- if (getAddress() != null) {
- name.append(getAddress().getHostAddress());
- name.append('-');
+ if (getPath() != null) {
+ name.append(getPath().getFileName().toString());
Review comment:
I think we should use the full path and I will explain why. The name
contains the addresss where the socket is bound. TCP sockets contains IP and
port which makes then fully idenfiable. UDS have they full path. I would use
it, not think about it. Windows uses a special path for UDS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
