To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-tc7.0.x-test-apr has an issue affecting its community
integration.
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-tc8.0.x-test-apr has an issue affecting its community
integration.
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/56
@violetagg I refactored the method to use `switch` statement as advised.
https://github.com/apache/tomcat/pull/56/files#diff-5c721c838c78fa7c31f9eb62c27863ceR383
@ChristopherSchultz
>
https://bz.apache.org/bugzilla/show_bug.cgi?id=48672
Christopher Schultz changed:
What|Removed |Added
Component|Catalina|Documentation
--
You are receiv
https://bz.apache.org/bugzilla/show_bug.cgi?id=48672
--- Comment #5 from Coty Sutherland ---
(In reply to Christopher Schultz from comment #4)
> (Should we add a "documentation" component for Tomcat 9?
Added.
--
You are receiving this mail because:
You are the assignee for the bug.
---
https://bz.apache.org/bugzilla/show_bug.cgi?id=48672
Christopher Schultz changed:
What|Removed |Added
Keywords||Beginner
--- Comment #4 from Chr
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/56
> Did you actually test it to see if it would give you the desired channel
options?
I actually did
> A small unit test wouldn't hurt
Will do
---
If your project is set up for it, you
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/56
@isapir I appreciate your core patch as an initial effort. It looks like it
will work. In order for it to be a good patch, it needs to be expanded, so a
larger patch is appropriate.
https://bz.apache.org/bugzilla/show_bug.cgi?id=48672
Mark Thomas changed:
What|Removed |Added
Product|Tomcat 6|Tomcat 9
Target Milestone|default
https://bz.apache.org/bugzilla/show_bug.cgi?id=48543
Mark Thomas changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
Author: markt
Date: Thu Jun 1 19:44:14 2017
New Revision: 1797255
URL: http://svn.apache.org/viewvc?rev=1797255&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=48543
Add the option to specify an alternative file name for the catalina.config
system property. Also document that re
Github user violetagg commented on the issue:
https://github.com/apache/tomcat/pull/56
> I was pointing out these examples while trying to figure out if you still
require that I wrap each single statement if with braces, which would make the
code less readable IMO.
+1 for `sw
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/56
@ChristopherSchultz That's exactly the kind of feedback that I was looking
for. I will address the points to the best of my ability.
Keep in mind that after those changes, the commit will be m
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/56
@violetagg Yes, I read that on
http://tomcat.apache.org/getinvolved.html#Coding_Conventions
I was pointing out these examples while trying to figure out if you still
require that I wrap each s
Chris,
On 6/1/2017 11:16 AM, Christopher Schultz wrote:
Just remember that everyone here is a volunteer, and it takes much
longer to review/test a patch/PR than it does to e.g. reply to a message
on a mailing list. We all have our primary jobs and our families and
both of those take priority ove
Github user violetagg commented on the issue:
https://github.com/apache/tomcat/pull/56
> I noticed instances of the code where curly braces were omitted for
single-statement ifs,
Yep, we know that. If you take a look at the history you will see that
typically when we prepare
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/56
A few comments:
1. I think the patch should include some TRACE-level logging, especially
when catching the NumberFormatException.
2. If there is an unrecognized option string, i
Igal,
On 6/1/17 1:59 PM, Igal @ Lucee.org wrote:
> On 6/1/2017 5:05 AM, Coty Sutherland wrote:
>>
>> Just for future reference, when you submit a PR it's easiest to review
>> if you squash all of the commits into one rather than multiple
>> commits.
>
> Perhaps that's a mentality difference betwee
On 6/1/2017 5:05 AM, Coty Sutherland wrote:
Just for future reference, when you submit a PR it's easiest to review
if you squash all of the commits into one rather than multiple
commits.
Perhaps that's a mentality difference between SVN users and git users.
In git it is common to do as in vo
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/56
@violetagg Thank you for your feedback, I updated the `for`, `catch`, and
one of the `if`'s.
While looking into updating the rest of the `if` statements I noticed
instances of the code where c
Github user isapir commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/56#discussion_r119663995
--- Diff: java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java ---
@@ -339,6 +339,13 @@ public void setChannelSendOptions(int
channelSendOptions) {
Author: schultz
Date: Thu Jun 1 16:08:20 2017
New Revision: 1797237
URL: http://svn.apache.org/viewvc?rev=1797237&view=rev
Log:
Add 3 presentations and links to recordings of two of them.
Modified:
tomcat/site/trunk/docs/presentations.html
tomcat/site/trunk/xdocs/presentations.xml
Modif
Hi guys,
a quick feedback on that topic:
- github seems to be the preferred way to submit code these days (what we
saw in tomee, batchee etc), it implies almost the same amount of work for
dev (just need to comment if applied or not on github itself for tracking)
so it is a good way probably
- to
On 1 June 2017 13:05:18 BST, Coty Sutherland wrote:
>Hm, using Git was mentioned at the TomcatCon but I can't recall if the
>git repository on github is bi-directional or just a clone of svn. Can
>anyone answer that?
The ASF hosts a read-only git clone of svn. GitHub has a read-only mirror of
t
https://bz.apache.org/bugzilla/show_bug.cgi?id=61134
Violeta Georgieva changed:
What|Removed |Added
Keywords||Beginner
--
You are receiving thi
2017-06-01 15:05 GMT+03:00 Coty Sutherland :
> Hi,
>
> On Wed, May 31, 2017 at 12:08 PM, Igal @ Lucee.org wrote:
>> Hi all,
>>
>> On 5/31/2017 1:12 AM, Mark Thomas wrote:
>>>
>>> On 31/05/17 04:07, Coty Sutherland wrote:
I've been thinking about things that we could do for Tomcat to help
https://bz.apache.org/bugzilla/show_bug.cgi?id=46284
--- Comment #4 from Jason A. Lunn ---
After over 8 and a half years I have long since stopped being invested in the
outcome of this issue.
--
You are receiving this mail because:
You are the assignee for the bug.
-
Hi,
On Wed, May 31, 2017 at 12:08 PM, Igal @ Lucee.org wrote:
> Hi all,
>
> On 5/31/2017 1:12 AM, Mark Thomas wrote:
>>
>> On 31/05/17 04:07, Coty Sutherland wrote:
>>>
>>> I've been thinking about things that we could do for Tomcat to help
>>> bring in new contributors and to be more appealing t
https://bz.apache.org/bugzilla/show_bug.cgi?id=61137
Violeta Georgieva changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
Author: violetagg
Date: Thu Jun 1 11:36:09 2017
New Revision: 1797201
URL: http://svn.apache.org/viewvc?rev=1797201&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61137
TagLibraryInfo#uri and TagLibraryInfo#prefix fields should not be final. Patch
provided by Katya Todorova.
M
Author: violetagg
Date: Thu Jun 1 11:34:39 2017
New Revision: 1797200
URL: http://svn.apache.org/viewvc?rev=1797200&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61137
TagLibraryInfo#uri and TagLibraryInfo#prefix fields should not be final. Patch
provided by Katya Todorova.
M
Github user asfgit closed the pull request at:
https://github.com/apache/tomcat/pull/57
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Author: violetagg
Date: Thu Jun 1 11:31:48 2017
New Revision: 1797197
URL: http://svn.apache.org/viewvc?rev=1797197&view=rev
Log:
TagLibraryInfo#uri and TagLibraryInfo#prefix fields should not be final. Patch
provided by Katya Todorova.
This closes #57
Modified:
tomcat/trunk/java/javax/ser
https://bz.apache.org/bugzilla/show_bug.cgi?id=61137
--- Comment #1 from Katya Todorova ---
Pull request: https://github.com/apache/tomcat/pull/57
tomcat tests pass
--
You are receiving this mail because:
You are the assignee for the bug.
GitHub user katya-stoycheva opened a pull request:
https://github.com/apache/tomcat/pull/57
Remove final modifiers from TagLibraryInfo uri and prefix
Remove final modifiers from TagLibraryInfo uri and prefix fields to match
the spec
You can merge this pull request into a Git reposi
Am 30.05.2017 um 22:06 schrieb Emmanuel Bourg:
On 05/26/2017 01:46 PM, Mark Thomas wrote:
It feels a bit late to do this for 9.0.x although we code if we wanted
to. It is more of an option for 10.0.x.
Tomcat 9 is still in an alpha stage and not widely deployed yet. I
wouldn't be shocked if AP
36 matches
Mail list logo
