Github user isapir commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/56#discussion_r119663995
--- Diff: java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java ---
@@ -339,6 +339,13 @@ public void setChannelSendOptions(int
channelSendOptions) {
this.channelSendOptions = channelSendOptions;
}
+ public void setChannelSendOptions(String channelSendOptions) {
+
+ int value = Channel.parseChannelSendOptions(channelSendOptions);
+ if (value > 0)
--- End diff --
Violeta, thank you for your feedback.
I'll add curly braces to the `for` block.
So each of those if's should have curly braces?
```if ("asynchronous".equals(opt) || "async".equals(opt))
return SEND_OPTIONS_ASYNCHRONOUS;```
That's a lot of curly braces... Perhaps a `switch` statement would be
"cleaner" here then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
