Chris, On 6/1/2017 11:16 AM, Christopher Schultz wrote:
Just remember that everyone here is a volunteer, and it takes much longer to review/test a patch/PR than it does to e.g. reply to a message on a mailing list. We all have our primary jobs and our families and both of those take priority over volunteering for the ASF and its communities.
I'm not sure if you read my first email in this thread (reading emails is also very time consuming, I know), but I made it very clear there that I am aware of these factors and that I set my expectations accordingly. I wouldn't have even mentioned my PR at this point if it weren't for Coty's email which started this thread.
I believe that my perspective represents most new contributors, and not only my own personal views, and that's the reason I posted it.
We always say "patches are always welcome" but, you're right, if the patches sit unreviewed for a long time, it's tough to feel like your contributions are valued.
I have been contributing to various open source projects for the better part of a decade now. Unfortunately, in the beginning, I had submitted large PRs a few times, that contained a lot of work. That work was not reviewed in a timely manner, and at some point the code base has changed so much that it was un-mergeable anymore, leading to loss of time and effort.
I have learned since to submit smaller and cleaner patches, so that they are easier to review. But still, if they are not reviewed in a timely manner there is: 1) a risk of them becoming unmergable due to changes in the code base; and 2) discouragement of the submitter from doing more work.
-chris
If that really is your name... Christopher Schultz signs his messages with a PGP signature ;)
Igal Sapir Lucee Core Developer Lucee.org <http://lucee.org/>
