On 6/1/2017 5:05 AM, Coty Sutherland wrote:
Just for future reference, when you submit a PR it's easiest to review if you squash all of the commits into one rather than multiple commits.
Perhaps that's a mentality difference between SVN users and git users. In git it is common to do as in voting: commit early and commit often ( https://en.wikipedia.org/wiki/Vote_early_and_vote_often ).
But there is a very simple solution for that -- rather than check the individual commits, check the "Files changed" tab in github, in this case https://github.com/apache/tomcat/pull/56/files (notice `files` added to endpoint, but clicking the tab would take you there directly).
That shows the cumulative changes of all of the commits. I try to make my PRs as easy as possible to review. On 6/1/2017 6:29 AM, Mark Thomas wrote:
There is generally a large difference in responsiveness between bugs and enhancement requests. Most of the open PRs have been reviewed and are waiting for feedback. The others are enhancement requests which typically remain open until there is sufficient interest in implementing them.
Understandable, but please bear in mind that new contributors can not usually start with complicated bugs. The new "Newbie / Stater / Beginner" keyword that you added to BZ was a great idea (h/t Chris), but if "Beginner" issues will not be reviewed due to lack of interest, then new contributors are very unlikely to submit any PRs after that first one that will not be addressed.
If Tomcat wants new contributors (and it should!), then a better feedback loop is required.
I, for one, am excited to contribute more to the project. I've already received some feedback from Violeta about my PR since I sent my last email, and updated the PR accordingly. I'm not sure if this thread had triggered the review or not, but AFAIC this is good progress :)
Igal --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
