[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...

2017-02-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (GEODE-2508) Generize lib naming

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880633#comment-15880633 ] ASF GitHub Bot commented on GEODE-2508: --- Github user asfgit closed the pull request

[jira] [Commented] (GEODE-2508) Generize lib naming

2017-02-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880632#comment-15880632 ] ASF subversion and git services commented on GEODE-2508: Commit c4

[jira] [Commented] (GEODE-2508) Generize lib naming

2017-02-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880631#comment-15880631 ] ASF subversion and git services commented on GEODE-2508: Commit 90

[GitHub] geode-native pull request #25: GEODE-2382: Replace gemstone with geode.

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/25#discussion_r102736948 --- Diff: src/xsds/gfcpp-cache-9.0.xsd --- @@ -33,7 +33,7 @@ limitations under the License. version="9.0"> The contents of

[jira] [Commented] (GEODE-2382) Remove "gemstone" from code base

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880643#comment-15880643 ] ASF GitHub Bot commented on GEODE-2382: --- Github user pivotal-jbarrett commented on a

[jira] [Created] (GEODE-2532) .NET Integration Tests Creates Temp Files in the Source Directory

2017-02-23 Thread Michael Martell (JIRA)
Michael Martell created GEODE-2532: -- Summary: .NET Integration Tests Creates Temp Files in the Source Directory Key: GEODE-2532 URL: https://issues.apache.org/jira/browse/GEODE-2532 Project: Geode

[jira] [Updated] (GEODE-2532) .NET Integration Tests Create Temp Files in the Source Directory

2017-02-23 Thread Michael Martell (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-2532: --- Summary: .NET Integration Tests Create Temp Files in the Source Directory (was: .NET Integrat

[jira] [Updated] (GEODE-2532) .NET Integration Tests Create Temp Files in the Source Directory

2017-02-23 Thread Michael Martell (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-2532: --- Attachment: ExtraneousTempFiles.jpg Description: The C++/CLI integration tests create tem

Re: C++ Style

2017-02-23 Thread Ernest Burghardt
Just looking a new PR and we have a BUNCH of m_memberVariables... so if we choose that transformation we'll probably touch 99% of the files #funfact On Wed, Feb 22, 2017 at 3:50 PM, Ernest Burghardt wrote: > +1 for camelCase - not a fan of allowed (not as readable) or > under_scores(requires ext

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102739212 --- Diff: src/clicache/src/CacheableDate.cpp --- @@ -90,7 +90,7 @@ namespace Apache TimeSpan epochSpan = m_dateTime - EpochTime;

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102745344 --- Diff: src/cppcache/src/statistics/HostStatHelperSolaris.cpp --- @@ -86,23 +86,23 @@ void HostStatHelperSolaris::refreshProcess(ProcessStats

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102742460 --- Diff: src/cppcache/integration-test/testThinClientFixedPartitionResolver.cpp --- @@ -245,7 +245,7 @@ DUNIT_TASK_DEFINITION(CLIENT1, CheckP

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102743540 --- Diff: src/cppcache/src/CacheImpl.cpp --- @@ -185,8 +185,8 @@ bool CacheImpl::getAndResetNetworkHopFlag() { return networkhop; }

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102744883 --- Diff: src/cppcache/src/statistics/GeodeStatisticsFactory.hpp --- @@ -98,50 +98,50 @@ class GeodeStatisticsFactory : public StatisticsFactory

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102738544 --- Diff: src/clicache/src/CacheableDate.cpp --- @@ -90,7 +90,7 @@ namespace Apache TimeSpan epochSpan = m_dateTime - EpochTime;

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102743673 --- Diff: src/cppcache/src/CqServiceVsdStats.hpp --- @@ -108,7 +108,7 @@ class CPPCACHE_EXPORT CqServiceVsdStats : public CqServiceStatistics {

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102739037 --- Diff: src/clicache/src/CacheableDate.cpp --- @@ -90,7 +90,7 @@ namespace Apache TimeSpan epochSpan = m_dateTime - EpochTime;

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102747392 --- Diff: src/cppcache/src/statistics/StatisticDescriptorImpl.cpp --- @@ -41,8 +41,8 @@ StatisticDescriptorImpl::StatisticDescriptorImpl(const

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102743360 --- Diff: src/cppcache/src/BucketServerLocation.hpp --- @@ -130,7 +130,7 @@ class BucketServerLocation : public ServerLocation { }

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102746696 --- Diff: src/cppcache/src/statistics/HostStatHelperWin.cpp --- @@ -535,21 +535,21 @@ uint32 HostStatHelperWin::getInt32Value(PPERF_COUNTER_DEF

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102742228 --- Diff: src/cppcache/include/geode/statistics/StatisticsFactory.hpp --- @@ -96,7 +96,7 @@ class CPPCACHE_EXPORT StatisticsFactory {

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102739522 --- Diff: src/cppcache/include/geode/geode_base.hpp --- @@ -69,32 +69,9 @@ #define GF_TEMPLATE_EXPORT #endif -#if defined(_M

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r10278 --- Diff: src/cppcache/src/RegionStats.hpp --- @@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats { class RegionStatType { p

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880726#comment-15880726 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880722#comment-15880722 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880723#comment-15880723 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880718#comment-15880718 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880716#comment-15880716 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880714#comment-15880714 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880721#comment-15880721 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880719#comment-15880719 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880720#comment-15880720 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880717#comment-15880717 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880725#comment-15880725 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880724#comment-15880724 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880727#comment-15880727 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880715#comment-15880715 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a

[GitHub] geode-native pull request #28: Feature/geode 2440

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/28#discussion_r102749040 --- Diff: src/cppcache/src/ClientMetadata.cpp --- @@ -344,7 +344,7 @@ int ClientMetadata::assignFixedBucketId(const char* partitionName,

Review Request 56986: GEODE-2497 surprise members are never timed out during startu

2017-02-23 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56986/ --- Review request for geode, Galen O'Sullivan and Hitesh Khamesra. Bugs: GEODE-249

[jira] [Created] (GEODE-2533) Export CSV

2017-02-23 Thread Gregory Green (JIRA)
Gregory Green created GEODE-2533: Summary: Export CSV Key: GEODE-2533 URL: https://issues.apache.org/jira/browse/GEODE-2533 Project: Geode Issue Type: Wish Components: gfsh

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102742761 --- Diff: src/cppcache/src/Log.cpp --- @@ -732,7 +732,7 @@ void Log::put(LogLevel level, const char* msg) { // struct dirent **resultArr

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102757059 --- Diff: src/cppcache/src/statistics/StatArchiveWriter.cpp --- @@ -434,17 +434,17 @@ void StatArchiveWriter::openFile(std::string filename) {

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102747970 --- Diff: src/cppcache/src/ThinClientRegion.hpp --- @@ -149,7 +149,7 @@ class CPPCACHE_EXPORT ThinClientRegion : public LocalRegion {

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102743038 --- Diff: src/cppcache/src/PdxHelper.cpp --- @@ -183,9 +183,9 @@ void PdxHelper::serializePdx(DataOutput& output, nType->InitializeT

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102743535 --- Diff: src/cppcache/src/PdxType.hpp --- @@ -89,7 +89,7 @@ class PdxType : public Serializable, int32_t* m_localToRemoteFieldMap;

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102756763 --- Diff: src/cppcache/src/statistics/StatArchiveWriter.cpp --- @@ -228,10 +228,10 @@ void ResourceInst::writeStatValue(StatisticDescriptor *sd, i

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880812#comment-15880812 ] ASF GitHub Bot commented on GEODE-2439: --- Github user echobravopapa commented on a di

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880811#comment-15880811 ] ASF GitHub Bot commented on GEODE-2439: --- Github user echobravopapa commented on a di

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880810#comment-15880810 ] ASF GitHub Bot commented on GEODE-2439: --- Github user echobravopapa commented on a di

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880808#comment-15880808 ] ASF GitHub Bot commented on GEODE-2439: --- Github user echobravopapa commented on a di

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880807#comment-15880807 ] ASF GitHub Bot commented on GEODE-2439: --- Github user echobravopapa commented on a di

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880809#comment-15880809 ] ASF GitHub Bot commented on GEODE-2439: --- Github user echobravopapa commented on a di

Review Request 56960: GEODE-2491 - Don't suppress IOExceptions when writing to the lucene index

2017-02-23 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56960/ --- Review request for geode and Jason Huynh. Repository: geode Description -

Review Request 56989: Adding an exception listener for the last lucene exception

2017-02-23 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56989/ --- Review request for geode, Jason Huynh and Lynn Hughes-Godfrey. Repository: geod

Review Request 56990: Lowering the log level for errors when cleaning up the index repository

2017-02-23 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56990/ --- Review request for geode and Jason Huynh. Repository: geode Description -

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102769513 --- Diff: src/clicache/src/CacheableDate.cpp --- @@ -90,7 +90,7 @@ namespace Apache TimeSpan epochSpan = m_dateTime - EpochTime;

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880883#comment-15880883 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

[GitHub] geode-native pull request #25: GEODE-2382: Replace gemstone with geode.

2017-02-23 Thread PivotalSarge
Github user PivotalSarge commented on a diff in the pull request: https://github.com/apache/geode-native/pull/25#discussion_r102769835 --- Diff: src/xsds/gfcpp-cache-9.0.xsd --- @@ -33,7 +33,7 @@ limitations under the License. version="9.0"> The contents of a d

[jira] [Commented] (GEODE-2382) Remove "gemstone" from code base

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880887#comment-15880887 ] ASF GitHub Bot commented on GEODE-2382: --- Github user PivotalSarge commented on a dif

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102771046 --- Diff: src/cppcache/include/geode/geode_base.hpp --- @@ -69,32 +69,9 @@ #define GF_TEMPLATE_EXPORT #endif -#if defined(_MSC_VER)

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880896#comment-15880896 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

[GitHub] geode-native pull request #28: Feature/geode 2440

2017-02-23 Thread mmartell
Github user mmartell commented on a diff in the pull request: https://github.com/apache/geode-native/pull/28#discussion_r102771536 --- Diff: src/cppcache/src/ClientMetadata.cpp --- @@ -344,7 +344,7 @@ int ClientMetadata::assignFixedBucketId(const char* partitionName, FixedMa

[jira] [Commented] (GEODE-2231) Create new partitioning example

2017-02-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880901#comment-15880901 ] ASF subversion and git services commented on GEODE-2231: Commit c4

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102771834 --- Diff: src/cppcache/include/geode/statistics/StatisticsFactory.hpp --- @@ -96,7 +96,7 @@ class CPPCACHE_EXPORT StatisticsFactory { virtu

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880906#comment-15880906 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102772268 --- Diff: src/cppcache/src/RegionStats.hpp --- @@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats { class RegionStatType { private:

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880909#comment-15880909 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102772225 --- Diff: src/cppcache/src/CacheImpl.cpp --- @@ -185,8 +185,8 @@ bool CacheImpl::getAndResetNetworkHopFlag() { return networkhop; }

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102772209 --- Diff: src/cppcache/src/BucketServerLocation.hpp --- @@ -130,7 +130,7 @@ class BucketServerLocation : public ServerLocation { } u

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102772252 --- Diff: src/cppcache/src/CqServiceVsdStats.hpp --- @@ -108,7 +108,7 @@ class CPPCACHE_EXPORT CqServiceVsdStats : public CqServiceStatistics {

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880911#comment-15880911 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880912#comment-15880912 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

[jira] [Commented] (GEODE-2533) Export CSV

2017-02-23 Thread Anthony Baker (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880914#comment-15880914 ] Anthony Baker commented on GEODE-2533: -- I suggest extending `gfsh export data` for th

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880913#comment-15880913 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

[jira] [Updated] (GEODE-2533) Export CSV

2017-02-23 Thread Anthony Baker (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2533: - Fix Version/s: (was: 1.2.0) > Export CSV > -- > > Key: GEODE-2533 >

[jira] [Updated] (GEODE-2486) Developer can use encrypted ciphers

2017-02-23 Thread Anthony Baker (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2486: - Fix Version/s: (was: 1.2.0) > Developer can use encrypted ciphers > --

[jira] [Updated] (GEODE-2319) Native Client Build fails on Ubuntu 16

2017-02-23 Thread Anthony Baker (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2319: - Fix Version/s: (was: 1.2.0) > Native Client Build fails on Ubuntu 16 > ---

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102773776 --- Diff: src/cppcache/src/statistics/HostStatHelperWin.cpp --- @@ -535,21 +535,21 @@ uint32 HostStatHelperWin::getInt32Value(PPERF_COUNTER_DEFINITION

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880910#comment-15880910 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102772118 --- Diff: src/cppcache/integration-test/testThinClientFixedPartitionResolver.cpp --- @@ -245,7 +245,7 @@ DUNIT_TASK_DEFINITION(CLIENT1, CheckPrSingleH

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880925#comment-15880925 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102774007 --- Diff: src/cppcache/src/Log.cpp --- @@ -732,7 +732,7 @@ void Log::put(LogLevel level, const char* msg) { // struct dirent **resultArray;

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102774104 --- Diff: src/cppcache/src/statistics/StatArchiveWriter.cpp --- @@ -434,17 +434,17 @@ void StatArchiveWriter::openFile(std::string filename) {

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880928#comment-15880928 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

[jira] [Updated] (GEODE-2343) Windows image sshd fails to start after build user password expires

2017-02-23 Thread Anthony Baker (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2343: - Fix Version/s: (was: 1.2.0) > Windows image sshd fails to start after build user password expi

[jira] [Updated] (GEODE-2344) Upgrade Geode-NC ordinal

2017-02-23 Thread Anthony Baker (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2344: - Fix Version/s: (was: 1.2.0) > Upgrade Geode-NC ordinal > > >

[jira] [Updated] (GEODE-2408) Refactor CacheableDate to use C++ std::chrono

2017-02-23 Thread Anthony Baker (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2408: - Fix Version/s: (was: 1.2.0) > Refactor CacheableDate to use C++ std::chrono >

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102774081 --- Diff: src/cppcache/src/PdxType.hpp --- @@ -89,7 +89,7 @@ class PdxType : public Serializable, int32_t* m_localToRemoteFieldMap;

[jira] [Updated] (GEODE-2308) Replace GemFire branding with Geode branding.

2017-02-23 Thread Anthony Baker (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2308: - Fix Version/s: (was: 1.2.0) > Replace GemFire branding with Geode branding. >

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102774094 --- Diff: src/cppcache/src/statistics/StatArchiveWriter.cpp --- @@ -228,10 +228,10 @@ void ResourceInst::writeStatValue(StatisticDescriptor *sd, int64

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102774038 --- Diff: src/cppcache/src/PdxHelper.cpp --- @@ -183,9 +183,9 @@ void PdxHelper::serializePdx(DataOutput& output, nType->InitializeType()

[jira] [Updated] (GEODE-2316) Replace GemFire namespace with Geode namespace

2017-02-23 Thread Anthony Baker (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2316: - Fix Version/s: (was: 1.2.0) > Replace GemFire namespace with Geode namespace > ---

[jira] [Updated] (GEODE-2306) Update native client BUILDING.md to reflect changes for Geode

2017-02-23 Thread Anthony Baker (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2306: - Fix Version/s: (was: 1.2.0) > Update native client BUILDING.md to reflect changes for Geode >

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880929#comment-15880929 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880927#comment-15880927 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

[jira] [Updated] (GEODE-2370) Need to create a CONTRIBUTING.md

2017-02-23 Thread Anthony Baker (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2370: - Fix Version/s: (was: 1.2.0) > Need to create a CONTRIBUTING.md > -

[jira] [Updated] (GEODE-2340) Update GemfireCppCache

2017-02-23 Thread Anthony Baker (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2340: - Fix Version/s: (was: 1.2.0) > Update GemfireCppCache > -- > >

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880930#comment-15880930 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102774330 --- Diff: src/cppcache/src/ThinClientRegion.hpp --- @@ -149,7 +149,7 @@ class CPPCACHE_EXPORT ThinClientRegion : public LocalRegion {

  1   2   3   >