[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880725#comment-15880725
]
ASF GitHub Bot commented on GEODE-2439:
---------------------------------------
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102738544
--- Diff: src/clicache/src/CacheableDate.cpp ---
@@ -90,7 +90,7 @@ namespace Apache
TimeSpan epochSpan = m_dateTime - EpochTime;
int64_t millitime =
epochSpan.Ticks / TimeSpan::TicksPerMillisecond;
- m_hashcode = (int)millitime ^ (int)((int64)millitime >> 32);
+ m_hashcode = (int)millitime ^ (int)((int64_t)millitime >> 32);
--- End diff --
You should also be addressing:
- Thec-style casting
- Use of int vs int32_t
```
int64_t millitime =
epochSpan.Ticks / TimeSpan::TicksPerMillisecond;
m_hashcode = static_cast<int32_t>(millitime) ^
static_cast<int32_t>(millitime >> 32);
```
> Replace all non-standard types in all public includes / API
> -----------------------------------------------------------
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
