[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880727#comment-15880727
 ] 

ASF GitHub Bot commented on GEODE-2439:
---------------------------------------

Github user pivotal-jbarrett commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/27#discussion_r102743540
  
    --- Diff: src/cppcache/src/CacheImpl.cpp ---
    @@ -185,8 +185,8 @@ bool CacheImpl::getAndResetNetworkHopFlag() {
       return networkhop;
     }
     
    -int8 CacheImpl::getAndResetServerGroupFlag() {
    -  int8 serverGroupFlag = CacheImpl::s_serverGroupFlag;
    +int8_t CacheImpl::getAndResetServerGroupFlag() {
    +  int8_t serverGroupFlag = CacheImpl::s_serverGroupFlag;
    --- End diff --
    
    Is this really `bool`?


> Replace all non-standard types in all public includes / API
> -----------------------------------------------------------
>
>                 Key: GEODE-2439
>                 URL: https://issues.apache.org/jira/browse/GEODE-2439
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)