[
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880906#comment-15880906
]
ASF GitHub Bot commented on GEODE-2439:
---------------------------------------
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102771834
--- Diff: src/cppcache/include/geode/statistics/StatisticsFactory.hpp ---
@@ -96,7 +96,7 @@ class CPPCACHE_EXPORT StatisticsFactory {
virtual StatisticDescriptor* createDoubleCounter(
const char* name, const char* description, const char* units,
- int8 largerBetter = true) = 0;
+ int8_t largerBetter = true) = 0;
--- End diff --
Sure, I will do if obvious like this one.
> Replace all non-standard types in all public includes / API
> -----------------------------------------------------------
>
> Key: GEODE-2439
> URL: https://issues.apache.org/jira/browse/GEODE-2439
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
