Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/746
@bschuchardt try closing and reopening; I think that will make Travis
restart.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/739
rebased on develop again, fixed a test to use the new
MessageExecutionContext.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/730
@PurelyApplied I think you can also close and reopen a PR to restart Travis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/739
Rebased on develop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/739#discussion_r135351811
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
---
@@ -50,26 +53,52
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/719
@metatype We need the `StreamAuthenticator` to receive and send
(Protobuf-encoded) messages containing the credentials that get passed to the
`SecurityManager`. I would think that ideally it&#
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/719#discussion_r135158491
--- Diff:
geode-core/src/main/java/org/apache/geode/security/StreamAuthenticator.java ---
@@ -46,6 +44,14 @@ void receiveMessage(InputStream
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/737#discussion_r135157183
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/serialization/codec/JSONCodecJUnitTest.java
---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/737
Looks like JSONCodecJUnitTest has multiple failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user galen-pivotal closed the pull request at:
https://github.com/apache/geode/pull/649
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/649
closing for #739 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/739
GEODE-3385: Change GetAllRequest to return list of errors.
Also:
* Rename `KeyedErrorResponse` to `KeyedError`.
* move `ErrorResponse` to `clientProtocol.proto`.
* Check for null
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/730
I haven't reviewed this, but :+1: deleting commented code is a GOOD THING.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/719#discussion_r134635734
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/AuthorizationIntegrationTest.java
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/719#discussion_r134634705
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/registry/OperationContextRegistry.java
---
@@ -47,41 +48,57 @@ private void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/719#discussion_r134633950
--- Diff:
geode-core/src/main/java/org/apache/geode/security/StreamAuthorizer.java ---
@@ -0,0 +1,19 @@
+/*
+ * Licensed to the Apache Software
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134270934
--- Diff:
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java
---
@@ -297,6 +297,8 @@ public Object call() throws
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134358612
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java
---
@@ -50,51 +37,23
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134022599
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java
---
@@ -0,0 +1,64
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134026218
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/TcpServerFactory.java
---
@@ -0,0 +1,39 @@
+package
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134024644
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/TcpServerFactory.java
---
@@ -0,0 +1,39 @@
+package
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134023037
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
---
@@ -49,20 +48,13 @@ private
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/726
GEODE-3474: protobuf auth with ExampleSecurityManager
It looks like we were using the wrong constants for the username and
password strings; ExampleSecurityManager uses some defined constants
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134021675
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
---
@@ -334,107 +351,109 @@ protected void run
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134021523
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
---
@@ -334,107 +351,109 @@ protected void run
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/707#discussion_r132878512
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
---
@@ -72,9 +99,15 @@ public static
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/707#discussion_r132878378
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
---
@@ -63,6 +65,31 @@ private static
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/707#discussion_r132878110
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfig.java
---
@@ -2433,6 +2433,25 @@
String
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/707#discussion_r132877993
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java
---
@@ -1378,6 +1379,18 @@
*/
String NAME
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/702#discussion_r132869478
--- Diff: geode-book/master_middleman/bookbinder_helpers.rb ---
@@ -1,298 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r132864196
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockService.java
---
@@ -74,17 +73,6 @@
public static final
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/698
What you've done looks good. However, it looks like there are ten or so
files in `geode-protobuf` that you didn't mark as experimental. Is there a
reason for this?
Have a l
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/682#discussion_r132626571
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/admin/SSLConfig.java ---
@@ -33,11 +34,11 @@
private String ciphers
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131290606
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockToken.java
---
@@ -302,14 +302,14 @@ boolean checkForExpiration
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131290383
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockToken.java
---
@@ -302,14 +302,14 @@ boolean checkForExpiration
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131290142
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRequestProcessor.java
---
@@ -196,6 +196,13 @@ long
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131290034
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockToken.java
---
@@ -87,7 +87,8 @@
private Thread thread
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/683
@kohlmu-pivotal @hiteshk25 @bschuchardt @pivotal-amurmann @WireBaron
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/683
GEODE-3314 - additional refactoring for developer QoL.
* Write characterization tests for DLockService.
* Remove debugging code.
* Remove dead code.
* Remove comments.
* Extract
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/676
Looks like there are some conflicts that need to be resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/676#discussion_r130987753
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/673#discussion_r130782011
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java
---
@@ -0,0 +1,110
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/673#discussion_r130781962
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java
---
@@ -0,0 +1,110
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/676
It looks like this is failing in Travis due to `:rat`, but you've got a
license in your only new file. I'm a bit mystified. Closing the pull request
and reopening it can be a g
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/676#discussion_r130781436
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandlerJUnitTest.java
---
@@ -95,8 +97,8
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/676#discussion_r130781170
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/661#discussion_r130494367
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufPrimitiveTypes.java
---
@@ -0,0 +1,47
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/661#discussion_r130495450
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufPrimitiveTypes.java
---
@@ -0,0 +1,47
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/661#discussion_r130494791
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufPrimitiveTypes.java
---
@@ -0,0 +1,47
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/661#discussion_r130779627
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java
---
@@ -50,10 +50,7
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/663
@pivotal-amurmann I'd like to write a unit test. @hiteshk25 and I took a
stab at it this afternoon but after an hour or two, got lost in mocks and the
tangle of
DistributedS
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/663
We probably can write a unit test. In particular, it would be nice if we
could test this bug without starting a whole `Cache`.
---
If your project is set up for it, you can reply to this email
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/663
GEODE-3314: Fix DLockService token leak.
And add a test so that we don't do that again.
We had been unlocking the DLock on the remote server before freeing the
local `DLock
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/649
This isn't code complete; I'm planning to work on this when I have the time
(unless anyone else wants to).
---
If your project is set up for it, you can reply to this email and have
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/657#discussion_r129892735
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java ---
@@ -279,26 +280,29 @@ protected void acceptConnection(Socket
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/643#discussion_r129649690
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
---
@@ -53,10 +52,10
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/657#discussion_r129640056
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java ---
@@ -279,26 +280,29 @@ protected void acceptConnection(Socket
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/657#discussion_r129639921
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java ---
@@ -1322,6 +1328,14 @@ private void createBatchSendBuffer
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/657#discussion_r129640243
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java ---
@@ -568,6 +568,12 @@ protected Connection(ConnectionTable t
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/657#discussion_r129645767
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java ---
@@ -1322,6 +1328,14 @@ private void createBatchSendBuffer
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/649#discussion_r129626464
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -62,4 +62,14 @@ message Region {
message Server {
string url = 1
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/649#discussion_r129626228
--- Diff: geode-protobuf/src/main/proto/clientProtocol.proto ---
@@ -66,7 +66,7 @@ message Response {
RemoveAllResponse removeAllResponse
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128811946
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128811551
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
---
@@ -35,10 +37,9
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128678978
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java
---
@@ -124,20 +128,19
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128678905
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
---
@@ -144,21 +138,22
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128677601
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
---
@@ -50,47 +38,14
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128649982
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128649664
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128649345
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128647952
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128648216
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
---
@@ -15,32 +15,33 @@
package
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128649165
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128649824
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/649
Some other thoughts from today:
* make GetAllResponse return a collection of Entries and a collection of
errors.
* make Get and GetAll return the same type of response, as mentioned
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/649
GEODE-2997: Change new protocol GetAllResponse.
@kohlmu-pivotal @hiteshk25 @WireBaron @pivotal-amurmann @bschuchardt
I think it's better to return the errors and the successful
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/404
At this point this PR is a bit out of date. To merge, all of the .class,
.pdf, .fig, etc. files would need to be removed, the merge fix done and
whatever other cleanup is necessary. It also
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/634#discussion_r128082288
--- Diff:
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java
---
@@ -90,12 +92,17 @@ public synchronized void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/634#discussion_r128082009
--- Diff:
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ChildVM.java ---
@@ -49,8 +49,8 @@ public static void main(String[] args
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/641
GetServersResponse number of servers was redundant.
@kohlmu-pivotal @bschuchardt @hiteshk25 @WireBaron @pivotal-amurmann
I think that the number was redundant. What do y'all
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127820947
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -52,7 +52,12 @@ message CallbackArguments {
message Region {
--- End diff
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127756778
--- Diff: geode-protobuf/src/main/proto/region_API.proto ---
@@ -102,4 +102,14 @@ message GetRegionNamesRequest {
message
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/633#discussion_r127550540
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
---
@@ -68,9 +56,8 @@ protected
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/630
Looks like Spotless is failing in CI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/633
GEODE-3170: Closed socket doesn't result in an infinite loop.
* Protobuf deserialization returning null is handled.
* IOException causes GenericProtocolServerConnection to
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/614
Add geode-protobuf to expected_jars
This will fix the build.
@hiteshk25
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/611
This has been merged in f63b9d .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user galen-pivotal closed the pull request at:
https://github.com/apache/geode/pull/597
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/597
merged in e1c6c3a .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/597
All tests pass!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/597
Added to excluded-classes.txt, hopefully this fixes it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/597
I get the following error when running the full integration test suite:
```
org.apache.geode.codeAnalysis.AnalyzeSerializablesJUnitTest >
testSerializables FAI
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/597
Client protocol with develop, gated by a feature flag.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/586
This failed due to Spotless; closing in favor of #597.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user galen-pivotal closed the pull request at:
https://github.com/apache/geode/pull/586
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/586
@bschuchardt Was that the only failure? It looks like another test had set
`mcast-port` to a non-zero value and failed to clean up the environment
I'm rerunning precheckin;
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/592
ð thanks for pushing this through! It had completely fallen off my
radar.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/586
GEODE-3075: initial flow adding the new client protocol to core.
Create `ServerConnectionFactory`, which creates either instances of
LegacyServerConnection (identical in functionality to the
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/564
ð good catch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/474
@masaki-yamakawa [Stack
overflow](https://stackoverflow.com/questions/17606874/trigger-a-travis-ci-rebuild-without-pushing-a-commit)
suggests that you can trigger a build by closing and
1 - 100 of 201 matches
Mail list logo
