Github user galen-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/707#discussion_r132877993
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java
 ---
    @@ -1378,6 +1379,18 @@
        */
       String NAME = "name";
       /**
    +   * The authentication mode for the protobuf client-server protocol.
    +   *
    +   * </p>
    +   * <U>Description</U>: Specifies the authentication mode used by the 
geode-protobuf module.
    +   * </p>
    +   * <U>Default</U>: "NOOP"
    +   * </p>
    +   * <U>Allowed values</U>: "NOOP" "SIMPLE"
    +   */
    +  @Experimental
    +  String PROTOBUF_PROTOCOL_AUTHENTICATION_MODE = 
"protobuf-protocol-authentication-mode";
    --- End diff --
    
    The property is a String representing the authentication mode to be used by 
the protobuf protocol. It currently has two valid settings. The protobuf in the 
name refers to the new client protocol (which we're calling the protobuf 
protocol).
    
    I don't think we're quite ready to take the feature flag out yet, but we 
should consider it as this feature nears alpha. Or moving the feature flag to a 
better config mechanism (DistributionConfig), so that this property and that 
one are in approximately the same place.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to