Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/707#discussion_r132878512
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
---
@@ -72,9 +99,15 @@ public static ServerConnection
makeServerConnection(Socket s, InternalCache c,
throw new IOException("Acceptor received unknown communication
mode: " + communicationMode);
} else {
protobufProtocolHandler = findClientProtocolMessageHandler();
- return new GenericProtocolServerConnection(s, c, helper, stats,
hsTimeout, socketBufferSize,
- communicationModeStr, communicationMode, acceptor,
protobufProtocolHandler,
- securityService);
+ authenticatorClass = findStreamAuthenticator(
+
c.getInternalDistributedSystem().getConfig().getProtobufProtocolAuthenticationMode());
+ try {
+ return new GenericProtocolServerConnection(s, c, helper, stats,
hsTimeout,
+ socketBufferSize, communicationModeStr, communicationMode,
acceptor,
+ protobufProtocolHandler, securityService,
authenticatorClass.newInstance());
--- End diff --
We find the class exactly once, and create a new instance per protocol
instance. We then create an instance per `GenericProtocolServerConnection`.
This is because the authenticator (unlike the protocol handler) is stateful, so
we can't share it between connections.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
