Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134358612
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java
---
@@ -50,51 +37,23 @@
@Override
public Result<ServerAPI.GetAvailableServersResponse> process(
SerializationService serializationService,
ServerAPI.GetAvailableServersRequest request,
- Cache cache) {
-
- InternalDistributedSystem distributedSystem =
- (InternalDistributedSystem) cache.getDistributedSystem();
- Properties properties = distributedSystem.getProperties();
- String locatorsString =
properties.getProperty(ConfigurationProperties.LOCATORS);
+ MessageExecutionContext executionContext) throws
InvalidExecutionContextException {
- HashSet<DistributionLocatorId> locators = new HashSet();
- StringTokenizer stringTokenizer = new StringTokenizer(locatorsString,
",");
- while (stringTokenizer.hasMoreTokens()) {
- String locator = stringTokenizer.nextToken();
- if (StringUtils.isNotEmpty(locator)) {
- locators.add(new DistributionLocatorId(locator));
- }
+ InternalLocator locator = executionContext.getLocator();
+ ArrayList serversFromSnapshot =
--- End diff --
I don't like that this has to go so far in to get a list of servers. I'd
like to see the DUnit test (or an integration test using a real Locator) come
back just so we can have some guarantee that `InternalLocator` doesn't change
on us.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
