Github user galen-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/707#discussion_r132878110
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfig.java
 ---
    @@ -2433,6 +2433,25 @@
       String getRedundancyZone();
     
       /**
    +   * @since Geode 1.??? TODO FIXME
    +   */
    +  @ConfigAttribute(type = String.class)
    +  String PROTOBUF_PROTOCOL_AUTHENTICATION_MODE_NAME = 
PROTOBUF_PROTOCOL_AUTHENTICATION_MODE;
    +  String DEFAULT_PROTOBUF_PROTOCOL_AUTHENTICATION_MODE = "NOOP";
    +
    +  /**
    +   * @since Geode 1.??? TODO FIXME
    +   */
    +  @ConfigAttributeSetter(name = PROTOBUF_PROTOCOL_AUTHENTICATION_MODE)
    +  void setProtobufProtocolAuthenticationMode(String authenticationMode);
    +
    +  /**
    +   * @since Geode 1.??? TODO FIXME
    +   */
    +  @ConfigAttributeGetter(name = PROTOBUF_PROTOCOL_AUTHENTICATION_MODE)
    +  String getProtobufProtocolAuthenticationMode();
    +
    +  /**
    --- End diff --
    
    That's a reasonable choice. Do you think this should be another 
undocumented system property? It might be fine for an alpha, but I don't think 
we should do it for long after that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to