Re: Review Request 57820: GEODE-2395: use random ports when starting the jmx manager and http services

2017-03-21 Thread Jinmei Liao
> On March 21, 2017, 11:41 p.m., Kirk Lund wrote: > > A couple tests appear to still have a couple hardcoded ports (7070 and > > 1099). > > > > Please read what I have to say about chaining of @Before methods and having > > many subclasses extending super tests. These are the kinds of things I

[jira] [Updated] (GEODE-2671) When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

2017-03-21 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2671: - Component/s: jmx > When a locator is started with a custom jmx-manager-port, the embedded pulse > server

[jira] [Updated] (GEODE-2670) pulse with integrated security has authentication and authorization issues

2017-03-21 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2670: - Component/s: security pulse > pulse with integrated security has authentication and autho

Re: Review Request 57820: GEODE-2395: use random ports when starting the jmx manager and http services

2017-03-21 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57820/#review169639 --- A couple tests appear to still have a couple hardcoded ports (7070

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

2017-03-21 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57796/#review169645 --- Ship it! Ship It! - Jinmei Liao On March 21, 2017, 11:22 p.m

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

2017-03-21 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57822/#review169644 --- geode-pulse/build.gradle Lines 31 (patched)

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

2017-03-21 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57796/ --- (Updated March 21, 2017, 4:22 p.m.) Review request for geode, Jinmei Liao, Jare

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

2017-03-21 Thread Kevin Duling
> On March 21, 2017, 10:43 a.m., Jinmei Liao wrote: > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java > > Lines 159 (patched) > > > > > > Is this system proeprty set manually o

Re: Review Request 57823: GEODE-2704: Remove Pulse's custom StringUtils in favor of Apache Commons StringUtils

2017-03-21 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57823/#review169640 --- Ship it! Ship It! - Jared Stewart On March 21, 2017, 10:25 p

[jira] [Assigned] (GEODE-2704) Remove Pulse's custom StringUtils in favor of Apache Commons StringUtils

2017-03-21 Thread Kevin Duling (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Duling reassigned GEODE-2704: --- Assignee: Kevin Duling > Remove Pulse's custom StringUtils in favor of Apache Commons StringU

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

2017-03-21 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57796/#review169636 --- geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVe

Re: Review Request 57797: GEODE-2535: added a boolean flag to track if an entry is in memory or on disk

2017-03-21 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57797/#review169638 --- geode-core/src/main/java/org/apache/geode/internal/cache/DiskEntr

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

2017-03-21 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57796/#review169637 --- Fix it, then Ship it! Fix it and Ship it! geode-assembly/src/

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #500 was SUCCESSFUL (with 1680 tests)

2017-03-21 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #500 was successful. --- Scheduled 1682 tests in total. https://build.spring.io/browse/SGF-NAG-500/ -- This

Re: Blacklist asf904 for Geode nightly job

2017-03-21 Thread Anthony Baker
Would be very nice to run our jenkins jobs from a docker container to avoid these environmental quirks. Anthony > On Mar 21, 2017, at 12:01 PM, Mark Bretl wrote: > > Hi Kirk, > > It looks like the build actually ran on a machine called 'H4', which is > designated as a Hadoop machine. I do not

Re: Review Request 57823: GEODE-2704: Remove Pulse's custom StringUtils in favor of Apache Commons StringUtils

2017-03-21 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57823/#review169635 --- Ship it! Ship It! - Kirk Lund On March 21, 2017, 10:25 p.m.,

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

2017-03-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935470#comment-15935470 ] ASF subversion and git services commented on GEODE-2513: Commit 5d

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

2017-03-21 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57822/#review169628 --- The localization resource bundles in Pulse require some thought (d

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

2017-03-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935463#comment-15935463 ] ASF subversion and git services commented on GEODE-2513: Commit 08

Review Request 57823: GEODE-2704: Remove Pulse's custom StringUtils in favor of Apache Commons StringUtils

2017-03-21 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57823/ --- Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, and P

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

2017-03-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935464#comment-15935464 ] ASF GitHub Bot commented on GEODE-2513: --- Github user asfgit closed the pull request

[GitHub] geode-native pull request #67: GEODE-2513 Unbranding docs: Top-level files

2017-03-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

2017-03-21 Thread Kevin Duling
> On March 21, 2017, 3:16 p.m., Jinmei Liao wrote: > > geode-pulse/build.gradle > > Line 70 (original) > > > > > > you only updated one test class which doesn't need logging at all. > > Let's not introduce this test

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

2017-03-21 Thread Kevin Duling
> On March 21, 2017, 3:16 p.m., Jinmei Liao wrote: > > geode-pulse/build.gradle > > Line 70 (original) > > > > > > you only updated one test class which doesn't need logging at all. > > Let's not introduce this test

Re: Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

2017-03-21 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57822/#review169629 --- geode-pulse/build.gradle Line 70 (original)

Review Request 57822: GEODE-1274: Migration from PulseLogWriter to Log4j standard.

2017-03-21 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57822/ --- Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, Ki

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

2017-03-21 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57796/ --- (Updated March 21, 2017, 2:48 p.m.) Review request for geode, Jinmei Liao, Jare

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

2017-03-21 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57796/ --- (Updated March 21, 2017, 2:48 p.m.) Review request for geode, Jinmei Liao, Jare

[GitHub] geode-native pull request #67: GEODE-2513 Unbranding docs: Top-level files

2017-03-21 Thread davebarnes97
GitHub user davebarnes97 opened a pull request: https://github.com/apache/geode-native/pull/67 GEODE-2513 Unbranding docs: Top-level files You can merge this pull request into a Git repository by running: $ git pull https://github.com/davebarnes97/geode-native feature/GEODE-2

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

2017-03-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935367#comment-15935367 ] ASF GitHub Bot commented on GEODE-2513: --- GitHub user davebarnes97 opened a pull requ

Review Request 57820: GEODE-2395: use random ports when starting the jmx manager and http services

2017-03-21 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57820/ --- Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, Kirk Lund, and

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

2017-03-21 Thread Jinmei Liao
> On March 21, 2017, 5:43 p.m., Jinmei Liao wrote: > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java > > Lines 159 (patched) > > > > > > Is this system proeprty set manually or

Re: Blacklist asf904 for Geode nightly job

2017-03-21 Thread Kirk Lund
Unfortunately I don't know enough about DNS or more likely the internal membership details of client/server to determine why one part of geode says the hostname is 67.195.81.148 while another part of geode says the hostname is asf904. DistributedMember.getId() for a client is returning 67.195.81.1

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

2017-03-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935325#comment-15935325 ] ASF GitHub Bot commented on GEODE-2513: --- Github user asfgit closed the pull request

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

2017-03-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935324#comment-15935324 ] ASF subversion and git services commented on GEODE-2513: Commit 09

[GitHub] geode-native pull request #66: GEODE-2513 Unbranding docs: remove GemFire re...

2017-03-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

2017-03-21 Thread Kevin Duling
> On March 21, 2017, 10:43 a.m., Jinmei Liao wrote: > > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java > > Lines 72 (patched) > > > > > > I would hope we shouldn't need to manully

[jira] [Commented] (GEODE-2469) Redis adapter Hash key support

2017-03-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935317#comment-15935317 ] ASF GitHub Bot commented on GEODE-2469: --- GitHub user ggreen reopened a pull request:

[jira] [Commented] (GEODE-2469) Redis adapter Hash key support

2017-03-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935316#comment-15935316 ] ASF GitHub Bot commented on GEODE-2469: --- Github user ggreen closed the pull request

[GitHub] geode pull request #404: Geode 2469

2017-03-21 Thread ggreen
Github user ggreen closed the pull request at: https://github.com/apache/geode/pull/404 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #404: Geode 2469

2017-03-21 Thread ggreen
GitHub user ggreen reopened a pull request: https://github.com/apache/geode/pull/404 Geode 2469 The updated Geode Redis Adapter now works with a sample Spring Data Redis Example [GEODE-2469.pdf](https://github.com/apache/geode/files/785580/GEODE-2469.pdf) These change

[GitHub] geode issue #404: Geode 2469

2017-03-21 Thread ggreen
Github user ggreen commented on the issue: https://github.com/apache/geode/pull/404 @galen-pivotal and @metatype, please take a look at my latest change. It uses a java.util.concurrent.locks.Lock instead of a distribute lock for the hash and set synchronization. --- If your project

Fwd: [NOTICE] Transient network issues affecting mail today

2017-03-21 Thread Mark Bretl
Forwarding to Dev list... A few people have received bounced notification email, this may explain it. Hopefully should be resolved now. --Mark -- Forwarded message -- From: Daniel Gruno Date: Tue, Mar 21, 2017 at 7:31 AM Subject: [NOTICE] Transient network issues affecting mail

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

2017-03-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935246#comment-15935246 ] ASF GitHub Bot commented on GEODE-2513: --- Github user davebarnes97 commented on the i

[GitHub] geode-native issue #65: GEODE-2513 Unbrand section on Remote Querying

2017-03-21 Thread davebarnes97
Github user davebarnes97 commented on the issue: https://github.com/apache/geode-native/pull/65 Noticed one typo: ...native-docs/remote-querying/91-quickintro/41-quickintro-query-portfolioregion.html.md.erb, "porfolio" should be "portfolio", --- If your project is set up for it, you

[jira] [Updated] (GEODE-2705) Jars undeployed from cluster configuration while a server is offline will still be loaded from disk when the server comes back online

2017-03-21 Thread Jared Stewart (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Stewart updated GEODE-2705: - Summary: Jars undeployed from cluster configuration while a server is offline will still be loaded

[jira] [Updated] (GEODE-2705) Jars removed from cluster configuration while a server is offline will still be loaded from disk when the server comes back online

2017-03-21 Thread Jared Stewart (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Stewart updated GEODE-2705: - Affects Version/s: 1.1.0 > Jars removed from cluster configuration while a server is offline will

[jira] [Updated] (GEODE-2705) Jars removed from cluster configuration while a server is offline will still be loaded from disk when the server comes back online

2017-03-21 Thread Jared Stewart (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Stewart updated GEODE-2705: - Summary: Jars removed from cluster configuration while a server is offline will still be loaded fr

[jira] [Created] (GEODE-2705) Jars removed from cluster configuration while a server is offline will still be loaded from disk when that server comes back online

2017-03-21 Thread Jared Stewart (JIRA)
Jared Stewart created GEODE-2705: Summary: Jars removed from cluster configuration while a server is offline will still be loaded from disk when that server comes back online Key: GEODE-2705 URL: https://issues.ap

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

2017-03-21 Thread Jinmei Liao
> On March 21, 2017, 5:43 p.m., Jinmei Liao wrote: > > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java > > Lines 72 (patched) > > > > > > I would hope we shouldn't need to manully

[jira] [Updated] (GEODE-2704) Remove Pulse's custom StringUtils in favor of Apache Commons StringUtils

2017-03-21 Thread Kevin Duling (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Duling updated GEODE-2704: Description: Moving away from these custom classes to use more standardized ones. > Remove Pulse's

[jira] [Created] (GEODE-2704) Remove Pulse's custom StringUtils in favor of Apache Commons StringUtils

2017-03-21 Thread Kevin Duling (JIRA)
Kevin Duling created GEODE-2704: --- Summary: Remove Pulse's custom StringUtils in favor of Apache Commons StringUtils Key: GEODE-2704 URL: https://issues.apache.org/jira/browse/GEODE-2704 Project: Geode

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

2017-03-21 Thread Kevin Duling
> On March 21, 2017, 10:43 a.m., Jinmei Liao wrote: > > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java > > Lines 72 (patched) > > > > > > I would hope we shouldn't need to manully

Re: Blacklist asf904 for Geode nightly job

2017-03-21 Thread Mark Bretl
Hi Kirk, It looks like the build actually ran on a machine called 'H4', which is designated as a Hadoop machine. I do not see why running on a Hadoop system would be an issue, however, I do not know the ASF infrastructure well enough to know why there are DNS issues. We use labels, tied to certai

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

2017-03-21 Thread Jinmei Liao
> On March 21, 2017, 5:43 p.m., Jinmei Liao wrote: > > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java > > Lines 72 (patched) > > > > > > I would hope we shouldn't need to manully

Blacklist asf904 for Geode nightly job

2017-03-21 Thread Kirk Lund
Please blacklist asf904 for the Geode nightly job. It seems to be giving bad DNS info to our tests, causing UniversalMembershipListenerAdapterDUnitTest to fail again. Alternatively, if someone else wants to look into the failures in UniversalMembershipListenerAdapterDUnitTest please go ahead. I've

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

2017-03-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935003#comment-15935003 ] ASF GitHub Bot commented on GEODE-2513: --- GitHub user karensmolermiller opened a pull

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

2017-03-21 Thread Kevin Duling
> On March 21, 2017, 10:43 a.m., Jinmei Liao wrote: > > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java > > Lines 72 (patched) > > > > > > I would hope we shouldn't need to manully

[GitHub] geode-native pull request #66: GEODE-2513 Unbranding docs: remove GemFire re...

2017-03-21 Thread karensmolermiller
GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode-native/pull/66 GEODE-2513 Unbranding docs: remove GemFire rel notes Removed the entire directory that would hold release notes from the repo. @davebarnes97 @joeymcallister @PivotalSarge @ech

[GitHub] geode-native pull request #65: GEODE-2513 Unbrand section on Remote Querying

2017-03-21 Thread karensmolermiller
GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode-native/pull/65 GEODE-2513 Unbrand section on Remote Querying - Corrected typos along the way - Added prose to identify when links take the reader to the Geode manual @davebarnes97 @j

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

2017-03-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934984#comment-15934984 ] ASF GitHub Bot commented on GEODE-2513: --- GitHub user karensmolermiller opened a pull

[GitHub] geode issue #429: Geode-2686

2017-03-21 Thread jinmeiliao
Github user jinmeiliao commented on the issue: https://github.com/apache/geode/pull/429 It would be a good idea to do a walkthrough of these changes for us to understand the major change points. --- If your project is set up for it, you can reply to this email and have your reply ap

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

2017-03-21 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57796/#review169587 --- geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVe

[GitHub] geode pull request #429: Geode-2686

2017-03-21 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/429#discussion_r107221701 --- Diff: geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java --- @@ -126,14 +111,16 @@ public void testDeployToInvalidD

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

2017-03-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934918#comment-15934918 ] ASF subversion and git services commented on GEODE-2513: Commit bb

Re: Review Request 57796: GEODE-2671: When a locator is started with a custom jmx-manager-port, the embedded pulse server still tries to connect to jmx using 1099

2017-03-21 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57796/ --- (Updated March 21, 2017, 9:35 a.m.) Review request for geode, Jinmei Liao, Jare

Build failed in Jenkins: Geode-nightly #783

2017-03-21 Thread Apache Jenkins Server
See Changes: [jstewart] GEODE-2692: Fix tests relying on file creation time [huynhja] GEODE-2679: Lucene asynchronous disk writes for aeq can lead to data [upthewaterspout] GEODE-688: Changing 1 second pause to a w

[GitHub] geode pull request #429: Geode-2686

2017-03-21 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/429#discussion_r107195082 --- Diff: geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java --- @@ -144,40 +131,99 @@ public void run() { T

[GitHub] geode pull request #429: Geode-2686

2017-03-21 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/429#discussion_r107195612 --- Diff: geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderTest.java --- @@ -65,6 +65,26 @@ public void testLatestExists() throws Excep

[GitHub] geode pull request #429: Geode-2686

2017-03-21 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/429#discussion_r107194282 --- Diff: geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java --- @@ -126,14 +111,16 @@ public void testDeployToInvalidD

[GitHub] geode pull request #429: Geode-2686

2017-03-21 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/429#discussion_r107192575 --- Diff: geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java --- @@ -39,83 +44,63 @@ @Rule public Tempora

[GitHub] geode pull request #429: Geode-2686

2017-03-21 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/429#discussion_r107192442 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java --- @@ -67,18 +68,16 @@ public static void deployJa