----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57796/#review169587 -----------------------------------------------------------
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java Lines 72 (patched) <https://reviews.apache.org/r/57796/#comment242009> I would hope we shouldn't need to manully set this in the test. geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java Lines 159 (patched) <https://reviews.apache.org/r/57796/#comment242005> Is this system proeprty set manually or by the locator/server when starting up the pulse service? geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java Lines 160 (patched) <https://reviews.apache.org/r/57796/#comment242006> Which StringUtils is this? I believe we can use apache common's StringUtils.isBlank to do this. geode-pulse/src/main/resources/pulse.properties Line 28 (original) <https://reviews.apache.org/r/57796/#comment242008> I don't think we need to change this. This property file is only used when pulse is not in the embedded mode. - Jinmei Liao On March 21, 2017, 4:35 p.m., Kevin Duling wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57796/ > ----------------------------------------------------------- > > (Updated March 21, 2017, 4:35 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, > and Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-2671: When a locator is started with a custom jmx-manager-port, the > embedded pulse server still tries to connect to jmx using 1099 > > > Diffs > ----- > > geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d > > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java > 57711258fbbc73570656e14ee8f05550ae32e891 > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java > 5408a5651774a63c16f27722c6ff7bda25cbaaa8 > geode-pulse/src/main/resources/pulse.properties > 878bc680bbcc4369eb2d3859c6377b8942bc89d7 > > > Diff: https://reviews.apache.org/r/57796/diff/1/ > > > Testing > ------- > > precheckin successful > > > Thanks, > > Kevin Duling > >
