Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/429#discussion_r107192442
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
---
@@ -67,18 +68,16 @@ public static void
deployJarsReceivedFromClusterConfiguration(Cache cache,
String[] jarFileNames = response.getJarNames();
byte[][] jarBytes = response.getJars();
- final JarDeployer jarDeployer = new JarDeployer(
- ((GemFireCacheImpl)
cache).getDistributedSystem().getConfig().getDeployWorkingDir());
-
/******
* Un-deploy the existing jars, deployed during cache creation, do not
delete anything
*/
if (jarFileNames != null && jarBytes != null) {
- JarClassLoader[] jarClassLoaders = jarDeployer.deploy(jarFileNames,
jarBytes);
+ List<DeployedJar> jarClassLoaders =
+
ClassPathLoader.getLatest().getJarDeployer().deploy(jarFileNames, jarBytes);
for (int i = 0; i < jarFileNames.length; i++) {
- if (jarClassLoaders[i] != null) {
- logger.info("Deployed " +
(jarClassLoaders[i].getFileCanonicalPath()));
+ if (jarClassLoaders.get(i) != null) {
--- End diff --
This loop is just printing the jars that got deployed from
ClusterConfiguration on member startup. If another thread deploys a jar in the
middle of this loop, this list won't be updated to include that jar. But I
believe that is the desired behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
