----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57796/#review169637 -----------------------------------------------------------
Fix it, then Ship it! Fix it and Ship it! geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java Lines 72 (patched) <https://reviews.apache.org/r/57796/#comment242114> Just in case we eventually change integrationTest to not forkEvery 1, we should add this in to undo the System.setProperty: ```java @ClassRule public static RestoreSystemProperties restoreSystemProperties = new RestoreSystemProperties(); ``` Or code it by hand in @AfterClass. - Kirk Lund On March 21, 2017, 9:48 p.m., Kevin Duling wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57796/ > ----------------------------------------------------------- > > (Updated March 21, 2017, 9:48 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, > and Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-2671: When a locator is started with a custom jmx-manager-port, the > embedded pulse server still tries to connect to jmx using 1099 > > > Diffs > ----- > > geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d > > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java > 57711258fbbc73570656e14ee8f05550ae32e891 > > geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java > e88360ba1506f1a7b9c7df87899d5ec19abec630 > geode-pulse/build.gradle 298ae5a8a32d621defd3336c21614c588b2ac7dc > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java > 5408a5651774a63c16f27722c6ff7bda25cbaaa8 > geode-pulse/src/main/resources/pulse.properties > 878bc680bbcc4369eb2d3859c6377b8942bc89d7 > > > Diff: https://reviews.apache.org/r/57796/diff/2/ > > > Testing > ------- > > precheckin restarted > > > Thanks, > > Kevin Duling > >
