----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57796/#review169636 -----------------------------------------------------------
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java Lines 72 (patched) <https://reviews.apache.org/r/57796/#comment242112> remove this and the test should still pass. geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java Lines 270 (patched) <https://reviews.apache.org/r/57796/#comment242124> declare a PUSE_PORT_PROP here to be the same value of the PulsePort.SYSTEM_PROPERTY_PULSE_PORT geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java Lines 20 (patched) <https://reviews.apache.org/r/57796/#comment242119> We should not introduce this dependency here. Pulse needs to be run separately without the gemfire jars. geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java Lines 152 (patched) <https://reviews.apache.org/r/57796/#comment242123> Should not use ConfigurationProperties here, Use PuseConstants.SYSTEM_PROPERTY_PULSE_PORT - Jinmei Liao On March 21, 2017, 9:48 p.m., Kevin Duling wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57796/ > ----------------------------------------------------------- > > (Updated March 21, 2017, 9:48 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, > and Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-2671: When a locator is started with a custom jmx-manager-port, the > embedded pulse server still tries to connect to jmx using 1099 > > > Diffs > ----- > > geode-assembly/build.gradle 1900896da96afdcc7c776f0cd98a2aea6840fb1d > > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseVerificationTest.java > 57711258fbbc73570656e14ee8f05550ae32e891 > > geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java > e88360ba1506f1a7b9c7df87899d5ec19abec630 > geode-pulse/build.gradle 298ae5a8a32d621defd3336c21614c588b2ac7dc > > geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/PulseAppListener.java > 5408a5651774a63c16f27722c6ff7bda25cbaaa8 > geode-pulse/src/main/resources/pulse.properties > 878bc680bbcc4369eb2d3859c6377b8942bc89d7 > > > Diff: https://reviews.apache.org/r/57796/diff/2/ > > > Testing > ------- > > precheckin restarted > > > Thanks, > > Kevin Duling > >
