[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r315596244 ## File path: be/src/runtime/fe_based_rowset_id_generator.cpp ## @@ -0,0 +1,108 @@ +// Licensed to the

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r315608293 ## File path: be/src/runtime/fe_based_rowset_id_generator.cpp ## @@ -0,0 +1,108 @@ +// Licensed to the

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r315610629 ## File path: gensrc/thrift/FrontendService.thrift ## @@ -604,6 +604,12 @@ struct TSnapshotLoaderReport

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r315611578 ## File path: fe/src/main/java/org/apache/doris/catalog/RowsetIdGenerator.java ## @@ -0,0 +1,71 @@ +//

[GitHub] [incubator-doris] morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315625125 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -187,18 +222,266 @@ prote

[GitHub] [incubator-doris] morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315624772 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -187,18 +222,266 @@ prote

[GitHub] [incubator-doris] morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315623094 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -61,66 +78,77 @@ public D

[GitHub] [incubator-doris] imay merged pull request #1675: Reduce the number of partition info in BrokerScanNode param

2019-08-20 Thread GitBox
imay merged pull request #1675: Reduce the number of partition info in BrokerScanNode param URL: https://github.com/apache/incubator-doris/pull/1675 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
HangyuanLiu commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315639291 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -187,18 +222,266 @@ prot

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r315646295 ## File path: fe/src/main/java/org/apache/doris/catalog/RowsetIdGenerator.java ## @@ -0,0 +1,71 @@ +// Lice

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315650319 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -61,66 +78,77 @@ public DateLit

[GitHub] [incubator-doris] morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315653644 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -61,66 +78,77 @@ public D

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315653515 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -48,9 +57,17 @@ public DateLite

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315654711 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -187,18 +222,266 @@ protected E

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315653967 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -187,18 +222,266 @@ protected E

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315658493 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -187,18 +222,266 @@ protected E

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315659643 ## File path: fe/src/main/java/org/apache/doris/rewrite/FEFunctions.java ## @@ -75,9 +75,11 @@ public static In

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315655937 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -150,17 +178,28 @@ public Strin

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315652679 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -29,16 +31,23 @@ import org.

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315654846 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -187,18 +222,266 @@ protected E

[GitHub] [incubator-doris] worker24h opened a new pull request #1679: fixbug and extend partition function

2019-08-20 Thread GitBox
worker24h opened a new pull request #1679: fixbug and extend partition function URL: https://github.com/apache/incubator-doris/pull/1679 1. Add fixed partitions. for example: ALTER TABLE test_table ADD PARTITION p0125 VALUES ["20190125", "20190126"); 2. fixup bug: "SHOW DATA" or "

[GitHub] [incubator-doris] morningman merged pull request #1677: Add strict mode in Routine load, Stream load and Mini load

2019-08-20 Thread GitBox
morningman merged pull request #1677: Add strict mode in Routine load, Stream load and Mini load URL: https://github.com/apache/incubator-doris/pull/1677 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315696818 ## File path: be/src/olap/row.h ## @@ -75,7 +75,7 @@ template void init_row_with_others(DstRowType* dst, const SrcR

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315687953 ## File path: be/src/exprs/bitmap_function.cpp ## @@ -0,0 +1,90 @@ +// Licensed to the Apache Software Foundation (A

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315716956 ## File path: be/src/exec/olap_scanner.cpp ## @@ -328,6 +328,11 @@ Status OlapScanner::get_batch(

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315699551 ## File path: be/src/olap/row_cursor.cpp ## @@ -184,31 +179,9 @@ OLAPStatus RowCursor::allocate_memory_for_string_t

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315714288 ## File path: be/src/olap/schema.h ## @@ -78,16 +98,22 @@ class Schema { ~Schema(); -void reset(const s

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315712380 ## File path: docs/documentation/cn/sql-reference/sql-functions/aggregate-functions/bitmap.md ## @@ -0,0 +1,77 @@ +

[GitHub] [incubator-doris] morningman commented on a change in pull request #1679: fixbug and extend partition function

2019-08-20 Thread GitBox
morningman commented on a change in pull request #1679: fixbug and extend partition function URL: https://github.com/apache/incubator-doris/pull/1679#discussion_r315966311 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -1515,6 +1521,15 @@ partition_key_desc ::= :}

[GitHub] [incubator-doris] morningman commented on a change in pull request #1679: fixbug and extend partition function

2019-08-20 Thread GitBox
morningman commented on a change in pull request #1679: fixbug and extend partition function URL: https://github.com/apache/incubator-doris/pull/1679#discussion_r315966080 ## File path: fe/src/main/java/org/apache/doris/catalog/Replica.java ## @@ -111,7 +111,7 @@ public Re

[GitHub] [incubator-doris] worker24h opened a new pull request #1680: fixup bug: "SHOW DATA" or "SHOW PARTITIONS", the DATA-SIZE less than 0

2019-08-20 Thread GitBox
worker24h opened a new pull request #1680: fixup bug: "SHOW DATA" or "SHOW PARTITIONS", the DATA-SIZE less than 0 URL: https://github.com/apache/incubator-doris/pull/1680 This is an automated message from the Apache Git Serv

[GitHub] [incubator-doris] wkhappy1 closed pull request #1667: kafka导入添加fillnull

2019-08-20 Thread GitBox
wkhappy1 closed pull request #1667: kafka导入添加fillnull URL: https://github.com/apache/incubator-doris/pull/1667 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315971841 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -50,18 +50,19 @@ class BinaryPlainPageBu

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315971867 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,118 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315971934 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,118 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315972291 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,118 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315972301 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,118 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315972783 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,118 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315972900 ## File path: be/src/olap/rowset/segment_v2/column_writer.h ## @@ -147,8 +154,10 @@ class ColumnWriter {

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315974625 ## File path: be/src/exprs/bitmap_function.cpp ## @@ -0,0 +1,90 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315974753 ## File path: docs/documentation/cn/sql-reference/sql-functions/aggregate-functions/bitmap.md ## @@ -0,0 +1,

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315974781 ## File path: be/src/exec/olap_scanner.cpp ## @@ -328,6 +328,11 @@ Status OlapScanner::get_batch(

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315976631 ## File path: be/src/olap/row_cursor.cpp ## @@ -184,31 +179,9 @@ OLAPStatus RowCursor::allocate_memory_for_s

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315976929 ## File path: be/src/olap/schema.h ## @@ -78,16 +98,22 @@ class Schema { ~Schema(); -void reset(

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315979655 ## File path: be/src/olap/row.h ## @@ -75,7 +75,7 @@ template void init_row_with_others(DstRowType* dst, con

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315981727 ## File path: be/src/olap/row_cursor.cpp ## @@ -184,31 +179,9 @@ OLAPStatus RowCursor::allocate_memory_for_string_t

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315981868 ## File path: be/src/exprs/bitmap_function.cpp ## @@ -0,0 +1,90 @@ +// Licensed to the Apache Software Foundation (A

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r315984891 ## File path: be/src/runtime/fe_based_rowset_id_generator.cpp ## @@ -0,0 +1,108 @@ +// Licensed to the

[GitHub] [incubator-doris] yuanlihan closed issue #1582: Enable Partition Discovery for Broker Load

2019-08-20 Thread GitBox
yuanlihan closed issue #1582: Enable Partition Discovery for Broker Load URL: https://github.com/apache/incubator-doris/issues/1582 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-doris] yuanlihan commented on issue #1582: Enable Partition Discovery for Broker Load

2019-08-20 Thread GitBox
yuanlihan commented on issue #1582: Enable Partition Discovery for Broker Load URL: https://github.com/apache/incubator-doris/issues/1582#issuecomment-523284628 Added This is an automated message from the Apache Git Service.

[GitHub] [incubator-doris] yuanlihan opened a new issue #1681: Extract data from data source with nested structure

2019-08-20 Thread GitBox
yuanlihan opened a new issue #1681: Extract data from data source with nested structure URL: https://github.com/apache/incubator-doris/issues/1681 **Currently, Doris is not well-supported for nested data parsing in data ingestion** Users may need to load data sources, like JSON/Parquet

[GitHub] [incubator-doris] imay commented on a change in pull request #1680: fixup bug: "SHOW DATA" or "SHOW PARTITIONS", the DATA-SIZE less than 0

2019-08-20 Thread GitBox
imay commented on a change in pull request #1680: fixup bug: "SHOW DATA" or "SHOW PARTITIONS", the DATA-SIZE less than 0 URL: https://github.com/apache/incubator-doris/pull/1680#discussion_r315997217 ## File path: fe/src/main/java/org/apache/doris/catalog/Replica.java ## @

[GitHub] [incubator-doris] thimoonxy opened a new issue #1682: Failed to insert decimal data

2019-08-20 Thread GitBox
thimoonxy opened a new issue #1682: Failed to insert decimal data URL: https://github.com/apache/incubator-doris/issues/1682 version: Doris-0.10.18 ``` mysql> desc t2; +---+--+--+---+-+---+ | Field | Type | Null | Key | Default |

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316021515 ## File path: be/src/exprs/bitmap_function.cpp ## @@ -0,0 +1,90 @@ +// Licensed to the Apache Software Foundation (A

[GitHub] [incubator-doris] thimoonxy commented on issue #1682: Failed to insert decimal data

2019-08-20 Thread GitBox
thimoonxy commented on issue #1682: Failed to insert decimal data URL: https://github.com/apache/incubator-doris/issues/1682#issuecomment-523323335 > seems not a bug, DECIMAL(4,3) allows 3 digits after decimal point, 1 before point only. ``` mysql> create table t3 (k1 int, k2 date, v

[GitHub] [incubator-doris] thimoonxy closed issue #1682: Failed to insert decimal data

2019-08-20 Thread GitBox
thimoonxy closed issue #1682: Failed to insert decimal data URL: https://github.com/apache/incubator-doris/issues/1682 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-doris] thimoonxy edited a comment on issue #1682: Failed to insert decimal data

2019-08-20 Thread GitBox
thimoonxy edited a comment on issue #1682: Failed to insert decimal data URL: https://github.com/apache/incubator-doris/issues/1682#issuecomment-523323335 > seems not a bug, DECIMAL(4,3) allows 3 digits after decimal point, 1 before point only. ``` mysql> create table t3 (k1 int, k2

[GitHub] [incubator-doris] thimoonxy edited a comment on issue #1682: Failed to insert decimal data

2019-08-20 Thread GitBox
thimoonxy edited a comment on issue #1682: Failed to insert decimal data URL: https://github.com/apache/incubator-doris/issues/1682#issuecomment-523323335 > seems not a bug, DECIMAL(4,3) allows 3 digits after decimal point, 1 before point only. > decimal(5,3) indicates: int(2).double(3)

[GitHub] [incubator-doris] morningman opened a new pull request #1683: Fix NPE of insert load job persist operation

2019-08-21 Thread GitBox
morningman opened a new pull request #1683: Fix NPE of insert load job persist operation URL: https://github.com/apache/incubator-doris/pull/1683 tracking url may be null This is an automated message from the Apache Git Servi

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-21 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315103705 ## File path: be/src/olap/rowset/segment_v2/column_writer.h ## @@ -128,11 +131,15 @@ class ColumnWriter {

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-21 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316033633 ## File path: be/src/olap/rowset/segment_v2/column_writer.cpp ## @@ -142,8 +156,20 @@ Status ColumnWriter::_ap

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-21 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316033877 ## File path: be/src/olap/rowset/segment_v2/column_writer.h ## @@ -128,11 +131,15 @@ class ColumnWriter {

[GitHub] [incubator-doris] imay merged pull request #1680: fixup bug: "SHOW DATA" or "SHOW PARTITIONS", the DATA-SIZE less than 0

2019-08-21 Thread GitBox
imay merged pull request #1680: fixup bug: "SHOW DATA" or "SHOW PARTITIONS", the DATA-SIZE less than 0 URL: https://github.com/apache/incubator-doris/pull/1680 This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-21 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316068751 ## File path: be/src/exprs/bitmap_function.cpp ## @@ -0,0 +1,90 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] Aegeaner commented on issue #1650: The WHERE clause predicate could not be applied to the NULL-supplying table.

2019-08-21 Thread GitBox
Aegeaner commented on issue #1650: The WHERE clause predicate could not be applied to the NULL-supplying table. URL: https://github.com/apache/incubator-doris/issues/1650#issuecomment-523377097 In Hive, this behavior is just expected: During Join predicates (ON) cannot be pushed past Pres

[GitHub] [incubator-doris] morningman merged pull request #1683: Fix NPE of insert load job persist operation

2019-08-21 Thread GitBox
morningman merged pull request #1683: Fix NPE of insert load job persist operation URL: https://github.com/apache/incubator-doris/pull/1683 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-21 Thread GitBox
morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r316159393 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -169,36 +238,252 @@ prote

[GitHub] [incubator-doris] morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-21 Thread GitBox
morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r316160623 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -169,36 +238,252 @@ prote

[GitHub] [incubator-doris] morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-21 Thread GitBox
morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r316159500 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -169,36 +238,252 @@ prote

[GitHub] [incubator-doris] morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-21 Thread GitBox
morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r316160033 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -169,36 +238,252 @@ prote

[GitHub] [incubator-doris] morningman closed issue #1674: Too many partition info in Load plan fragment

2019-08-21 Thread GitBox
morningman closed issue #1674: Too many partition info in Load plan fragment URL: https://github.com/apache/incubator-doris/issues/1674 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-doris] gaodayue opened a new issue #1684: [Proposal] Bitmap Index File Format for V2 segment

2019-08-21 Thread GitBox
gaodayue opened a new issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684 ### Background and Goal Bitmap index is very popular among OLAP systems. A bitmap index contains two parts. - First, there is an *

[GitHub] [incubator-doris] morningman merged pull request #1672: Add timeout on snapshot of data

2019-08-21 Thread GitBox
morningman merged pull request #1672: Add timeout on snapshot of data URL: https://github.com/apache/incubator-doris/pull/1672 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1685: Add error msg when memory limit exceeded

2019-08-21 Thread GitBox
EmmyMiao87 opened a new pull request #1685: Add error msg when memory limit exceeded URL: https://github.com/apache/incubator-doris/pull/1685 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-doris] morningman opened a new pull request #1686: Add a loaded rows in SHOW LOAD result

2019-08-21 Thread GitBox
morningman opened a new pull request #1686: Add a loaded rows in SHOW LOAD result URL: https://github.com/apache/incubator-doris/pull/1686 Loaded rows will be updated periodically by query report. So that user can see that a load job is still running or being blocked. eg:

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-21 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r316512825 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -169,36 +238,252 @@ protected v

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-21 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r316511979 ## File path: fe/src/main/java/org/apache/doris/rewrite/FEFunctions.java ## @@ -75,9 +75,27 @@ public static In

[GitHub] [incubator-doris] imay commented on a change in pull request #1685: Add error msg when memory limit exceeded

2019-08-21 Thread GitBox
imay commented on a change in pull request #1685: Add error msg when memory limit exceeded URL: https://github.com/apache/incubator-doris/pull/1685#discussion_r316513179 ## File path: be/src/exec/exec_node.h ## @@ -393,11 +393,15 @@ class ExecNode { bool _is_closed;

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1687: add limit to show tablet(#1547)

2019-08-21 Thread GitBox
kangpinghuang opened a new pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687 add limit to limit the result rows when use show tablet from table. This is an automated m

[GitHub] [incubator-doris] imay commented on a change in pull request #1686: Add a loaded rows in SHOW LOAD result

2019-08-22 Thread GitBox
imay commented on a change in pull request #1686: Add a loaded rows in SHOW LOAD result URL: https://github.com/apache/incubator-doris/pull/1686#discussion_r316523679 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -118,6 +120,13 @@ //

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315027534 ## File path: be/src/olap/rowset/segment_v2/ordinal_page_index.h ## @@ -97,10 +101,24 @@ class OrdinalPageInde

[GitHub] [incubator-doris] worker24h opened a new pull request #1688: Fixbug

2019-08-22 Thread GitBox
worker24h opened a new pull request #1688: Fixbug URL: https://github.com/apache/incubator-doris/pull/1688 It can not create a new partition when paritions of a table is empty This is an automated message from the Apache Git S

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316558367 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -244,13 +297,41 @@ Status SegmentIterator::_next_

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316553007 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,166 @@ +// Licensed to the Apache Software F

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316536894 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,166 @@ +// Licensed to the Apache Software F

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316557356 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -114,8 +124,51 @@ Status SegmentIterator::_prepar

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316557716 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -114,8 +124,51 @@ Status SegmentIterator::_prepar

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316552195 ## File path: be/src/olap/rowset/segment_v2/column_reader.cpp ## @@ -156,18 +160,69 @@ Status ColumnReader::read_page(co

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316554858 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -45,16 +47,21 @@ SegmentIterator::~SegmentIterato

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316537413 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,166 @@ +// Licensed to the Apache Software F

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316583497 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,166 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316583582 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,166 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] morningman opened a new pull request #1690: Fix bug that 2 same stream load jobs may both be able to executed successfully

2019-08-22 Thread GitBox
morningman opened a new pull request #1690: Fix bug that 2 same stream load jobs may both be able to executed successfully URL: https://github.com/apache/incubator-doris/pull/1690 ISSUE #1689 This is an automated message fro

[GitHub] [incubator-doris] kangkaisen opened a new issue #1691: Add a code style check and format script for Doris BE

2019-08-22 Thread GitBox
kangkaisen opened a new issue #1691: Add a code style check and format script for Doris BE URL: https://github.com/apache/incubator-doris/issues/1691 Currently, We need take time to review the code style for Doris BE, we should add a code style check and format script to do this work.

[GitHub] [incubator-doris] kangkaisen commented on issue #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
kangkaisen commented on issue #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#issuecomment-523856177 After tested with real data, I found the bitmap load is very slower than sum. For about one million rows, stream load with sum only need 3 seco

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #1690: Fix bug that 2 same stream load jobs may both be able to executed successfully

2019-08-22 Thread GitBox
EmmyMiao87 commented on issue #1690: Fix bug that 2 same stream load jobs may both be able to executed successfully URL: https://github.com/apache/incubator-doris/pull/1690#issuecomment-523863106 LGTM This is an automated mes

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316629485 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,166 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] morningman merged pull request #1690: Fix bug that 2 same stream load jobs may both be able to executed successfully

2019-08-22 Thread GitBox
morningman merged pull request #1690: Fix bug that 2 same stream load jobs may both be able to executed successfully URL: https://github.com/apache/incubator-doris/pull/1690 This is an automated message from the Apache Git S

[GitHub] [incubator-doris] morningman commented on a change in pull request #1686: Add a loaded rows in SHOW LOAD result

2019-08-22 Thread GitBox
morningman commented on a change in pull request #1686: Add a loaded rows in SHOW LOAD result URL: https://github.com/apache/incubator-doris/pull/1686#discussion_r316635194 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -118,6 +120,13 @@

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316637044 ## File path: be/src/olap/rowset/segment_v2/column_reader.cpp ## @@ -156,18 +160,69 @@ Status ColumnReader::re

<    23   24   25   26   27   28   29   30   31   32   >