imay commented on a change in pull request #1633: add zone map page(#1390)
URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316557716
##########
File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp
##########
@@ -114,8 +124,51 @@ Status SegmentIterator::_prepare_seek() {
return Status::OK();
}
+Status SegmentIterator::_init_row_ranges() {
+ if (_lower_rowid == _upper_rowid) {
+ // no data return;
+ _row_ranges = RowRanges();
+ return Status::OK();
+ }
+
+ if (_opts.conditions != nullptr) {
+ RowRanges zone_map_row_ranges;
+ RETURN_IF_ERROR(_get_row_ranges_from_zone_map(&zone_map_row_ranges));
+ RowRanges::ranges_intersection(_row_ranges, zone_map_row_ranges,
&_row_ranges);
+ // TODO(hkp): get row ranges from bloom filter and secondary index
+ }
+
+ if (!_row_ranges.is_empty()) {
Review comment:
I think we should put this judge to init() function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
