kangpinghuang commented on a change in pull request #1633: add zone map
page(#1390)
URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315971841
##########
File path: be/src/olap/rowset/segment_v2/binary_plain_page.h
##########
@@ -50,18 +50,19 @@ class BinaryPlainPageBuilder : public PageBuilder {
}
bool is_page_full() override {
- return _size_estimate > _options.data_page_size
- || _prepared_size > _options.data_page_size;
+ // data_page_size is 0, do not limit the page size
+ return _options.data_page_size != 0 && (_size_estimate >
_options.data_page_size
+ || _prepared_size > _options.data_page_size);
}
- Status add(const uint8_t *vals, size_t *count) override {
+ Status add(const uint8_t* vals, size_t* count) override {
DCHECK(!_finished);
DCHECK_GT(*count, 0);
size_t i = 0;
// If the page is full, should stop adding more items.
while (!is_page_full() && i < *count) {
- const Slice *src = reinterpret_cast<const Slice *>(vals);
+ const Slice *src = reinterpret_cast<const Slice*>(vals);
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
