kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315027534
########## File path: be/src/olap/rowset/segment_v2/ordinal_page_index.h ########## @@ -97,10 +101,24 @@ class OrdinalPageIndex { } OrdinalPageIndexIterator end() { return OrdinalPageIndexIterator(this, _num_pages); + } + rowid_t get_first_row_id(int page_index) const { Review comment: this comment is missed by me, I will fix it in next commit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org