imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316558367
########## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ########## @@ -244,13 +297,41 @@ Status SegmentIterator::_next_batch(RowBlockV2* block, size_t* rows_read) { } Status SegmentIterator::next_batch(RowBlockV2* block) { - size_t rows_to_read = std::min((rowid_t)block->capacity(), _upper_rowid - _cur_rowid); + // _cur_rowid is 10 + // _row_ranges: [2-5], [8-15], [20-25] Review comment: ```suggestion // _row_ranges: [2-5], [8-15], [20-25] or [2,5), [8, 15) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org