Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-30 Thread Jonathan Dowland
On Thu Jan 23, 2025 at 2:28 PM GMT, Matthew Vernon wrote: I'd much much rather MRs were associated with bug reports; that way I only have to remember to check one place for outstanding issues in my packages, and years down the line when I wonder "why did this change get made" I can look up the bu

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-30 Thread Jonathan Dowland
On Fri Jan 24, 2025 at 11:22 AM GMT, Johannes Schauer Marin Rodrigues wrote: I'm likely in lack of understanding here but I have not yet understood the utility of merge commits. You say that they could be useful to attach git notes to it. But can these notes not also attached to regular commits

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-29 Thread Jonas Smedegaard
Quoting Andreas Tille (2025-01-29 15:06:15) > Am Sun, Jan 26, 2025 at 01:06:00AM +0100 schrieb gregor herrmann: > > The alternative -- and that's what we did in pkg-perl -- is to have > > the Janitor just commit to our repos instead of filing merge > > requests: > > https://salsa.debian.org/janitor

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-29 Thread Andreas Tille
Am Sun, Jan 26, 2025 at 01:06:00AM +0100 schrieb gregor herrmann: > The alternative -- and that's what we did in pkg-perl -- is to have > the Janitor just commit to our repos instead of filing merge > requests: > https://salsa.debian.org/janitor-team/janitor.debian.net/-/blob/master/k8s/policy.conf

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-25 Thread gregor herrmann
On Wed, 15 Jan 2025 08:43:21 +0100, Andreas Tille wrote: > However, in all teams I'm deeply involved we asked Jelmer to not run > Janitor automatically on the Git repositories. The rationale is, that > if a package is not uploaded commits by the Janitor might become > outdated - well, finally wha

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-25 Thread Julien Plissonneau Duquène
Le 2025-01-25 19:22, Julien Plissonneau Duquène a écrit : Wayback Machine FTR this project [1], according to this interview [2] (transcript [3] search for "discussions") now aims to also archive the discussions happening on merge requests and issues. So there is some hope for future-proof ar

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-25 Thread Julien Plissonneau Duquène
Le 2025-01-25 19:02, Simon McVittie a écrit : (I assume the Salsa admins do have a way to permanently redact a discussion thread that contains something illegal or abusive, if it becomes necessary.) It is also possible for the creator of a merge request (and probably for the repository owners

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-25 Thread Julien Plissonneau Duquène
Le 2025-01-25 17:04, Richard Lewis a écrit : I think that sounds like a lot of work in order to duplicate a subset of the existing functionality -- is another bespoke system what debian needs? A more affordable option could be to implement some of the features in the salsa CLI from `devscri

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-25 Thread Simon McVittie
On Sat, 25 Jan 2025 at 17:40:26 +0100, Jonas Smedegaard wrote: > When I post to a discussion at Salsa, then for how long is my post > publicly available? In general: until the project containing the discussion is deleted. A "project" in Gitlab jargon is the thing that wraps a git repository; more

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-25 Thread Jonas Smedegaard
Quoting Philipp Kern (2025-01-25 16:05:25) > On 1/23/25 8:46 PM, Simon Josefsson wrote: > > Jonas Smedegaard writes: > >> Are discussions at Salsa preserved years down the line? > > That is a good point. Are there any mirrors of Salsa at all? Having > > continous replication to a couple of addit

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-25 Thread Richard Lewis
Julien Plissonneau Duquène writes: > Le 2025-01-24 13:00, Andrea Pappacoda a écrit : >> Same for me. In addition, on the topic of making things easier for >> new >> contributors, when I first started using Salsa I felt lost in the >> myriad >> of features and options enabled by default. Not only

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-25 Thread Jonathan Dowland
On Fri Jan 24, 2025 at 4:49 PM GMT, Fabio Fantoni wrote: I recently saw this project that seems good to slightly improve some things, for example: https://fabre.debian.net/ This looks interesting! The BTS has (or had) a SOAP(!) API. 17 years ago I tried writing a desktop tool to try and mak

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-25 Thread Philipp Kern
On 1/23/25 8:46 PM, Simon Josefsson wrote: Jonas Smedegaard writes: Are discussions at Salsa preserved years down the line? That is a good point. Are there any mirrors of Salsa at all? Having continous replication to a couple of additional read-only instance would be useful, in case Salsa bu

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Christoph J. Scherr
On Fri, 2025-01-24 at 17:49 +0100, Fabio Fantoni wrote: > > If we want to continue to use mainly BTS I think you should have an > integration with something that allows you to do more things from the > web interface, in a simple and fast way. > > I recently saw this project that seems good to s

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Gioele Barabucci
On 24/01/25 12:22, Johannes Schauer Marin Rodrigues wrote: Quoting Gioele Barabucci (2025-01-24 09:49:27) I disagree with this conclusion. Sometimes features are extensively discussed in salsa merge requests or issues, and the entire discussion just can't be summarized in a git commit message (a

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Xiyue Deng
Hi Colin, Colin Watson writes: > On Thu, Jan 23, 2025 at 10:57:56PM -0800, Xiyue Deng wrote: >> Actually there may be another reason to turn off MR feature: some >> packaging workflows don't preserve a linear Git history and hence may >> not work well with merging from MR on Salsa. For example,

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Fabio Fantoni
Il 24/01/2025 15:26, Christoph J. Scherr ha scritto: On Fri, 2025-01-24 at 13:05 +0100, Jonas Smedegaard wrote: Hi Christoph, Quoting Christoph J. Scherr (2025-01-24 12:13:16) Hello, As someone just starting out with Debian, I'd like to share my perspective on this discussion. I only recentl

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Jonas Smedegaard
Hi Otto, Quoting Otto Kekäläinen (2025-01-24 18:24:55) > Hi Jonas! > > > > If you don't like using Salsa or don't like reviewing Merge Requests, > > > then this call is probably not for you. However, if you want Debian to > > > grow and you want to welcome new contributors, or in general work in

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Otto Kekäläinen
> Is there some way to drill down into groups and then set preferences on > an individual repo that's not in one's own namespace? Yes - you can for example open https://salsa.debian.org/debian/openqa and in the top right corner click on the bell icon, and select "Watch". That will make you get not

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Julien Plissonneau Duquène
Le 2025-01-24 13:00, Andrea Pappacoda a écrit : Same for me. In addition, on the topic of making things easier for new contributors, when I first started using Salsa I felt lost in the myriad of features and options enabled by default. Not only 99% of projects hosted on Salsa don't need featur

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Otto Kekäläinen
Hi Jonas! > > If you don't like using Salsa or don't like reviewing Merge Requests, > > then this call is probably not for you. However, if you want Debian to > > grow and you want to welcome new contributors, or in general work in a > > collaborative way towards ending single-maintainer packages,

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Jonas Smedegaard
Quoting Christoph J. Scherr (2025-01-24 15:26:39) > Writing a Pro/Con list might be a good idea, but I am not proficient > enough in both the BTS and GitLab to do so. That sounds like an excellent approach to me. I will leave that for others, as I have lost my bearing on what is on topic for this

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Sam Hartman
> "Gioele" == Gioele Barabucci writes: Gioele> On 24/01/25 13:18, Colin Watson wrote: >> I agree with this. From Otto in another thread: >> >> "It is sad to see that in Debian usage of git is stifled by >> simple things like people not agreeing to use a common branch

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Christoph J. Scherr
On Fri, 2025-01-24 at 13:05 +0100, Jonas Smedegaard wrote: > Hi Christoph, > > Quoting Christoph J. Scherr (2025-01-24 12:13:16) > > Hello, > > > > As someone just starting out with Debian, I'd like to share my perspective > > on > > this discussion. > > > > I only recently contacted the welcome

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Jeremy Stanley
On 2025-01-24 10:06:13 +0100 (+0100), Julien Plissonneau Duquène wrote: > Le 2025-01-24 09:49, Gioele Barabucci a écrit : [...] > > True. This is why MR discussions should be automatically saved in git > > notes attached to the merge commit. In this way the discussion will be > > preserved and the

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Gioele Barabucci
On 24/01/25 13:18, Colin Watson wrote: I agree with this. From Otto in another thread: "It is sad to see that in Debian usage of git is stifled by simple things like people not agreeing to use a common branch naming scheme despite there being a proposal for 10+ years now." I use git e

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Jonas Smedegaard
Quoting Antonio Terceiro (2025-01-24 13:09:10) > On Fri, Jan 24, 2025 at 11:07:40AM +0100, Jonas Smedegaard wrote: > > Quoting Otto Kek�l�inen (2025-01-24 01:32:34) > > > If you don't like using Salsa or don't like reviewing Merge Requests, > > > then this call is probably not for you. However, if

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Colin Watson
On Thu, Jan 23, 2025 at 07:35:23PM -0700, Sam Hartman wrote: > > "Otto" == Otto Kekäläinen writes: > > Otto> Could you give it a try please? Salsa isn't that bad :) > > Can you please respect people who have different positions than you? > I'm this close to turning off MRs for all my pac

+1 (Re: Let's make 2025 a year when code reviews became common in Debian)

2025-01-24 Thread Holger Levsen
On Fri, Jan 24, 2025 at 12:18:18PM +, Colin Watson wrote: > > Otto> Could you give it a try please? Salsa isn't that bad :) > > Can you please respect people who have different positions than you? > > I'm this close to turning off MRs for all my packages and promising to > > be the last per

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Colin Watson
On Thu, Jan 23, 2025 at 10:57:56PM -0800, Xiyue Deng wrote: > Actually there may be another reason to turn off MR feature: some > packaging workflows don't preserve a linear Git history and hence may > not work well with merging from MR on Salsa. For example, the "git-dpm" > and "git-debrebase" wo

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Andrea Pappacoda
Hi all, On Fri Jan 24, 2025 at 10:50 AM CET, Jonas Smedegaard wrote: Quoting Chris Hofstaedtler (2025-01-24 01:51:27) BTW, a lot of other gitlab features should probably be off for most packaging repositories. Currently, when I create a new project at Salsa, I do the following: 1. Among the

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Antonio Terceiro
On Fri, Jan 24, 2025 at 11:07:40AM +0100, Jonas Smedegaard wrote: > Quoting Otto Kekäläinen (2025-01-24 01:32:34) > > If you don't like using Salsa or don't like reviewing Merge Requests, > > then this call is probably not for you. However, if you want Debian to > > grow and you want to welcome new

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Jonas Smedegaard
Hi Christoph, Quoting Christoph J. Scherr (2025-01-24 12:13:16) > On Fri, 2025-01-24 at 11:07 +0100, Jonas Smedegaard wrote: > > Quoting Otto Kekäläinen (2025-01-24 01:32:34) > > > If you don't like using Salsa or don't like reviewing Merge Requests, > > > then this call is probably not for you. H

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Johannes Schauer Marin Rodrigues
Hi, Quoting Gioele Barabucci (2025-01-24 09:49:27) > > I disagree with this conclusion. Sometimes features are extensively > > discussed in salsa merge requests or issues, and the entire discussion just > > can't be summarized in a git commit message (and it is not desirable to > > even attempt th

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Christoph J. Scherr
On Fri, 2025-01-24 at 11:07 +0100, Jonas Smedegaard wrote: > Quoting Otto Kekäläinen (2025-01-24 01:32:34) > > If you don't like using Salsa or don't like reviewing Merge Requests, > > then this call is probably not for you. However, if you want Debian to > > grow and you want to welcome new contri

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Jonas Smedegaard
Quoting Otto Kekäläinen (2025-01-24 01:32:34) > If you don't like using Salsa or don't like reviewing Merge Requests, > then this call is probably not for you. However, if you want Debian to > grow and you want to welcome new contributors, or in general work in a > collaborative way towards ending

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Jonas Smedegaard
Quoting Chris Hofstaedtler (2025-01-24 01:51:27) > * Sam Hartman [250123 23:47]: > > > ... > > >> > Numerous people are posting Merge Requests on Salsa. Please > > >> help review them! > > > > I think it would improve collaboration a lot if we could make an effort > > to get salsa project

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Philip Hands
Otto Kekäläinen writes: > Hi! > >> I think it would improve collaboration a lot if we could make an effort >> to get salsa projects into one of two states: >> >> * Merge requests are disabled for that project >> >> * Merge requests are actively watched at least as closely as the BTS > > We should

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Julien Plissonneau Duquène
Le 2025-01-24 09:49, Gioele Barabucci a écrit : On 24/01/25 09:00, Julien Plissonneau Duquène wrote: Also note that the contents that really matter is the git repositories themselves. I do not agree with this premise. The Git repo is forever and `git log` is how you search its history. Ext

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Gioele Barabucci
On 24/01/25 09:00, Julien Plissonneau Duquène wrote: Also note that the contents that really matter is the git repositories themselves. I do not agree with this premise. The Git repo is forever and `git log` is how you search its history. External websites will one day be gone. And are not a

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-24 Thread Julien Plissonneau Duquène
Hi, Le 2025-01-24 01:23, Otto Kekäläinen a écrit : Also note that the contents that really matter is the git repositories themselves. I do not agree with this premise. The Merge Request feature is not intended to be a place of permanent documentation. It is just a tool to facilitate fast an

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Xiyue Deng
Hi Otto, First I want to thank you for your work on Salsa. I find it pleasant to use and the Salsa CI has also helped catch many lurking bugs for me. Otto Kekäläinen writes: > ... > > I understand that some people like to turn of the MR feature > completely on their repositories, but I would a

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Sam Hartman
> "Otto" == Otto Kekäläinen writes: Otto> Hi, Otto> On Thu, 23 Jan 2025 at 17:52, Wookey wrote: Otto> .. >> Right. I look at bug reports for my packages (eventually). I have >> never looked at a Salsa merge request in my life. That's just >> /dev/null for my packages.

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Wookey
On 2025-01-23 18:09 -0800, Otto Kekäläinen wrote: > Hi, > > On Thu, 23 Jan 2025 at 17:52, Wookey wrote: > .. > > Right. I look at bug reports for my packages (eventually). I have > > never looked at a Salsa merge request in my life. That's just > > /dev/null for my packages. That could change one

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Sam Hartman
Otto> Hi, >> Are discussions at Salsa preserved years down the line? Otto> confident that contents can be migrated. We already Otto> successfully migrated git.debian.org to salsa.debian.org. Actually, I think this is a lot of the problem. We did not migrate all the alioth conte

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Otto Kekäläinen
Hi, On Thu, 23 Jan 2025 at 17:52, Wookey wrote: .. > Right. I look at bug reports for my packages (eventually). I have > never looked at a Salsa merge request in my life. That's just > /dev/null for my packages. That could change one day, but I don't know when. Could you give it a try please? Sa

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Wookey
On 2025-01-23 16:36 -0800, Otto Kekäläinen wrote: > I understand that some people like to turn of the MR feature > completely on their repositories, but I would advise against that, as > it is a major killer to collaboration. Not only does it signal to > contributors to the existing package that th

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Wookey
On 2025-01-23 17:11 +, Colin Watson wrote: > On Thu, Jan 23, 2025 at 03:56:24PM +0100, Gioele Barabucci wrote: > > Or forget about the BTS and accept Salsa as the main place where > > improvements are discussed? > > As long as it's very commonly the case that nobody is actually > subscribed to

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Chris Hofstaedtler
* Sam Hartman [250123 23:47]: > > ... > >> > Numerous people are posting Merge Requests on Salsa. Please > >> help review them! > > I think it would improve collaboration a lot if we could make an effort > to get salsa projects into one of two states: > > * Merge requests are disabled fo

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Otto Kekäläinen
Hi! > I think it would improve collaboration a lot if we could make an effort > to get salsa projects into one of two states: > > * Merge requests are disabled for that project > > * Merge requests are actively watched at least as closely as the BTS We should revisit the decision to have email no

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Otto Kekäläinen
Hi Matthew! > > Numerous people are posting Merge Requests on Salsa. Please help review > > them! > > I'd much much rather MRs were associated with bug reports; that way I > only have to remember to check one place for outstanding issues in my > packages, and years down the line when I wonder "wh

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Otto Kekäläinen
Hi, > Are discussions at Salsa preserved years down the line? I don't think there is any special concern to suspect that Salsa or any other official Debian service would seize to exist abruptly? GitHub.com and GitLab.com has done a pretty good job at hosting contents for years and years, hopefull

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Sam Hartman
> "Jonas" == Jonas Smedegaard writes: Jonas> Quoting Matthew Vernon (2025-01-23 15:28:00) >> Otto Kekäläinen writes: >> >> > Numerous people are posting Merge Requests on Salsa. Please >> help review them! >> >> I'd much much rather MRs were associated with bug

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Simon Josefsson
Jonas Smedegaard writes: > Quoting Gioele Barabucci (2025-01-23 15:56:24) >> On 23/01/25 15:28, Matthew Vernon wrote: >> > Otto Kekäläinen writes: >> > >> >> Numerous people are posting Merge Requests on Salsa. Please help >> >> review them! >> > >> > I'd much much rather MRs were associated w

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Colin Watson
On Thu, Jan 23, 2025 at 03:56:24PM +0100, Gioele Barabucci wrote: > Or forget about the BTS and accept Salsa as the main place where > improvements are discussed? As long as it's very commonly the case that nobody is actually subscribed to merge requests on Salsa, it isn't realistic to expect revi

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Jonas Smedegaard
Quoting Gioele Barabucci (2025-01-23 15:56:24) > On 23/01/25 15:28, Matthew Vernon wrote: > > Otto Kekäläinen writes: > > > >> Numerous people are posting Merge Requests on Salsa. Please help > >> review them! > > > > I'd much much rather MRs were associated with bug reports; that way > > I only

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Jonas Smedegaard
Quoting Matthew Vernon (2025-01-23 15:28:00) > Otto Kekäläinen writes: > > > Numerous people are posting Merge Requests on Salsa. Please help review > > them! > > I'd much much rather MRs were associated with bug reports; that way I > only have to remember to check one place for outstanding iss

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Gioele Barabucci
On 23/01/25 15:28, Matthew Vernon wrote: Otto Kekäläinen writes: Numerous people are posting Merge Requests on Salsa. Please help review them! I'd much much rather MRs were associated with bug reports; that way I only have to remember to check one place for outstanding issues in my packages,

+1 (Re: Let's make 2025 a year when code reviews became common in Debian)

2025-01-23 Thread Holger Levsen
On Thu, Jan 23, 2025 at 02:28:00PM +, Matthew Vernon wrote: > I'd much much rather MRs were associated with bug reports; that way I > only have to remember to check one place for outstanding issues in my > packages, and years down the line when I wonder "why did this change get > made" I can lo

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-23 Thread Matthew Vernon
Hi, Otto Kekäläinen writes: > Numerous people are posting Merge Requests on Salsa. Please help review them! I'd much much rather MRs were associated with bug reports; that way I only have to remember to check one place for outstanding issues in my packages, and years down the line when I wonder

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-16 Thread Andreas Tille
Hi Gioele, Am Wed, Jan 15, 2025 at 06:38:48PM +0100 schrieb Gioele Barabucci: > Please note that although the package has a repo on Salsa, MRs there > are/were explicitly disabled, at least for non-DDs (see the postscriptum in > [1], I see they are available now). Therefore were the commits in my

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-15 Thread Gioele Barabucci
On 15/01/25 15:19, Andreas Tille wrote: I'm not sure that these packages are on BTS only because the associated packages have no Git/salsa repo. The BTS is our prefered form of reporting issues. Adding an MR and linking to it as a patch as you did in [1] is perfect and as a maintainer (who has

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-15 Thread Andreas Tille
Hi Gioele, Am Wed, Jan 15, 2025 at 08:55:51AM +0100 schrieb Gioele Barabucci: > On 14/01/25 23:14, Otto Kekäläinen wrote: > > Numerous people are posting Merge Requests on Salsa. Please help review > > them! > > Could we do the same for BTS patches? > > There are ~5000 patches that have been si

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-15 Thread Andreas Tille
Hi, Am Wed, Jan 15, 2025 at 09:01:33AM +0100 schrieb Gioele Barabucci: > Indeed, archiving the project [1], as suggested by Chris, seems a more > sensible course of action. Everything remains available, but users are given > a clear indication of the status of the repository. > > [1] > https://d

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-15 Thread Gioele Barabucci
On 14/01/25 23:14, Otto Kekäläinen wrote: Numerous people are posting Merge Requests on Salsa. Please help review them! Could we do the same for BTS patches? There are ~5000 patches that have been sitting in the BTS for years, some trivial (examples from my own: [1,2]), others less so. Most o

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-15 Thread Gioele Barabucci
On 15/01/25 08:43, Andreas Tille wrote: However, I would support the idea of bulk closing MRs and complete repositories *if* the package has been removed from Debian for the same reason we bulk close their bug reports. I tend to keep the repository for several reasons: * Users might like to

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-14 Thread Julien Plissonneau Duquène
Le 2025-01-15 00:37, Chris Hofstaedtler a écrit : Maybe a viable option for the debian namespace is to blanket close any MR that is older than 6 months. But I don't know how that will fare for the Janitor MRs. Given the "Debian time" scale, a much longer delay would be appropriate IMO. I would

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-14 Thread Andreas Tille
Hi, Am Tue, Jan 14, 2025 at 07:14:09PM -0800 schrieb Otto Kekäläinen: > > I gave this, specifically reviewing MRs in the debian namespace, a > > try after your last message on this topic. Unfortunately I have to > > say, it feels like a huge waste of time and is mostly frustrating. > > Thanks! Se

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-14 Thread Julien Plissonneau Duquène
Hi, Le 2025-01-14 23:14, Otto Kekäläinen a écrit : 619 (1242) https://salsa.debian.org/groups/java-team/-/merge_requests FWIW I took a look at that and most of them are Janitor merge requests. Please just skip them as some are outdated, and I'm planning to take care of them later this year

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-14 Thread Andrey Rakhmatullin
On Tue, Jan 14, 2025 at 07:14:09PM -0800, Otto Kekäläinen wrote: > > The other big category of MRs in the debian namespace was and still > > is: MRs where the maintainers don't get mails from salsa. If one is > > active with the project, one can know who is currently around and > > assign / ping th

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-14 Thread Otto Kekäläinen
> > 938 (9657) https://salsa.debian.org/groups/debian/-/merge_requests > [..] > > If you have some spare time for Debian today, please consider > > collaborating with another maintainer by providing them > > review/feedback on an open Merge Request. > > I gave this, specifically reviewing MRs in th

Re: Let's make 2025 a year when code reviews became common in Debian

2025-01-14 Thread Chris Hofstaedtler
* Otto Kekäläinen [250114 23:14]: > Numerous people are posting Merge Requests on Salsa. Please help review them! > > There is no single dashboard to show all Merge Requests for all Debian > packages, but here are the largest teams listed to show how many they > have open (and total count in pare

Let's make 2025 a year when code reviews became common in Debian

2025-01-14 Thread Otto Kekäläinen
Hi, Numerous people are posting Merge Requests on Salsa. Please help review them! There is no single dashboard to show all Merge Requests for all Debian packages, but here are the largest teams listed to show how many they have open (and total count in parentheses): 938 (9657) https://salsa.debi