[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6877: Enhance JSON index to support nested array

Jackie-Jiang commented on a change in pull request #6877: URL: https://github.com/apache/incubator-pinot/pull/6877#discussion_r627883138 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/json/BaseJsonIndexCreator.java ## @@

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6877: Enhance JSON index to support nested array

Jackie-Jiang commented on a change in pull request #6877: URL: https://github.com/apache/incubator-pinot/pull/6877#discussion_r627883425 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/json/ImmutableJsonIndexReader.java ## @

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6877: Enhance JSON index to support nested array

Jackie-Jiang commented on a change in pull request #6877: URL: https://github.com/apache/incubator-pinot/pull/6877#discussion_r627883534 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/json/ImmutableJsonIndexReader.java ## @

[GitHub] [incubator-pinot] icefury71 opened a new pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

icefury71 opened a new pull request #6890: URL: https://github.com/apache/incubator-pinot/pull/6890 … table ## Description This is part 1 of #6524 . This PR provides an overall ingestion status for Pinot realtime table. The status is HEALTHY if all consuming segments are in the C

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6885: Updating QueryRunner to return object of report summary

Jackie-Jiang commented on a change in pull request #6885: URL: https://github.com/apache/incubator-pinot/pull/6885#discussion_r627915336 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/perf/QueryRunner.java ## @@ -686,16 +686,16 @@ public static void increasing

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6885: Updating QueryRunner to return object of report summary

Jackie-Jiang commented on a change in pull request #6885: URL: https://github.com/apache/incubator-pinot/pull/6885#discussion_r627915394 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/perf/QueryRunner.java ## @@ -542,16 +544,16 @@ public static void targetQPSQ

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6877: Enhance JSON index to support nested array

yupeng9 commented on a change in pull request #6877: URL: https://github.com/apache/incubator-pinot/pull/6877#discussion_r627921488 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/json/BaseJsonIndexCreator.java ## @@ -130

[GitHub] [incubator-pinot] Jackie-Jiang removed a comment on pull request #6885: Updating QueryRunner to return object of report summary

Jackie-Jiang removed a comment on pull request #6885: URL: https://github.com/apache/incubator-pinot/pull/6885#issuecomment-834061611 For clients that call the QueryRunner methods directly (not through command line), added return objects for the methods so that that the client does not hav

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6885: Updating QueryRunner to return object of report summary

Jackie-Jiang commented on pull request #6885: URL: https://github.com/apache/incubator-pinot/pull/6885#issuecomment-834061611 For clients that call the QueryRunner methods directly (not through command line), added return objects for the methods so that that the client does not have to col

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6885: Updating QueryRunner to return object of report summary

Jackie-Jiang merged pull request #6885: URL: https://github.com/apache/incubator-pinot/pull/6885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

codecov-commenter commented on pull request #6890: URL: https://github.com/apache/incubator-pinot/pull/6890#issuecomment-834062294 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6890?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

codecov-commenter edited a comment on pull request #6890: URL: https://github.com/apache/incubator-pinot/pull/6890#issuecomment-834062294 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6890?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] xiangfu0 merged pull request #6888: Update helm to override zk url when zk is disabled

xiangfu0 merged pull request #6888: URL: https://github.com/apache/incubator-pinot/pull/6888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] jtao15 opened a new pull request #6891: Allow multiple alias for the same selection column.

jtao15 opened a new pull request #6891: URL: https://github.com/apache/incubator-pinot/pull/6891 This pr add supports to allow selecting same column multiple times with different alias (#6844 ). E.g. `Select colA AS xx, colA AS yy from T`. -- This is an automated message from the Apa

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6889: fix integration tests for kafka ports

codecov-commenter commented on pull request #6889: URL: https://github.com/apache/incubator-pinot/pull/6889#issuecomment-834104502 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6889?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6891: Allow multiple alias for the same selection column.

codecov-commenter commented on pull request #6891: URL: https://github.com/apache/incubator-pinot/pull/6891#issuecomment-834125903 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6891?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6878: JSON column datatype support.

codecov-commenter edited a comment on pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#issuecomment-832453091 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6878?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6878: JSON column datatype support.

codecov-commenter edited a comment on pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#issuecomment-832453091 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6878?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6878: JSON column datatype support.

amrishlal commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628351204 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonDatatypeTest.java ## @@ -0,0 +1,293 @@ +/** + * Licensed to the Apache Soft

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6878: JSON column datatype support.

amrishlal commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628351400 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java ## @@ -52,6 +52,7 @@ public static final Integer DEFAULT_DIMEN

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6878: JSON column datatype support.

amrishlal commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628354108 ## File path: pinot-core/src/test/java/org/apache/pinot/core/transport/QueryRoutingTest.java ## @@ -211,7 +211,7 @@ public void testServerDown(

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6878: JSON column datatype support.

amrishlal commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628354233 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/HavingFilterHandler.java ## @@ -154,6 +154,7 @@ public boolean isMatc

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6878: JSON column datatype support.

amrishlal commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628354318 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CastTransformFunction.java ## @@ -130,6 +132,9 @@ publ

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6878: JSON column datatype support.

amrishlal commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628354478 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CastTransformFunction.java ## @@ -76,6 +76,8 @@ public

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6878: JSON column datatype support.

amrishlal commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628358014 ## File path: pinot-common/src/test/java/org/apache/pinot/common/utils/PinotDataTypeTest.java ## @@ -102,43 +127,64 @@ public void testObject()

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6878: JSON column datatype support.

amrishlal commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628358171 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java ## @@ -538,6 +540,64 @@ public String convert(Object

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6878: JSON column datatype support.

amrishlal commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628358409 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java ## @@ -538,6 +540,64 @@ public String convert(Object

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6878: JSON column datatype support.

siddharthteotia commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628362469 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonDatatypeTest.java ## @@ -0,0 +1,308 @@ +/** + * Licensed to the Apach

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6878: JSON column datatype support.

siddharthteotia commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628365082 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonDatatypeTest.java ## @@ -0,0 +1,308 @@ +/** + * Licensed to the Apach

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6878: JSON column datatype support.

siddharthteotia commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628366484 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonDatatypeTest.java ## @@ -0,0 +1,308 @@ +/** + * Licensed to the Apach

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6878: JSON column datatype support.

amrishlal commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628354108 ## File path: pinot-core/src/test/java/org/apache/pinot/core/transport/QueryRoutingTest.java ## @@ -211,7 +211,7 @@ public void testServerDown(

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6878: JSON column datatype support.

amrishlal commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628354108 ## File path: pinot-core/src/test/java/org/apache/pinot/core/transport/QueryRoutingTest.java ## @@ -211,7 +211,7 @@ public void testServerDown(

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6877: Enhance JSON index to support nested array

Jackie-Jiang commented on a change in pull request #6877: URL: https://github.com/apache/incubator-pinot/pull/6877#discussion_r628388394 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/json/BaseJsonIndexCreator.java ## @@

[GitHub] [incubator-pinot] desaijay230592 commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

desaijay230592 commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r628396786 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java ## @@ -261,12 +270,39 @@ private vo

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6891: Allow multiple alias for the same selection column.

Jackie-Jiang commented on a change in pull request #6891: URL: https://github.com/apache/incubator-pinot/pull/6891#discussion_r628407710 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java ## @@ -91,7 +91,8 @@ private static void

[GitHub] [incubator-pinot] apucher opened a new pull request #6892: add shell-script for quickstart auth

apucher opened a new pull request #6892: URL: https://github.com/apache/incubator-pinot/pull/6892 ## Description Add a shell-script for AuthQuickstart ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) *

[GitHub] [incubator-pinot] amrishlal opened a new pull request #6893: Fix flaky test

amrishlal opened a new pull request #6893: URL: https://github.com/apache/incubator-pinot/pull/6893 ## Description To avoid flakyness, set timeout to 2000 msec. For some test runs, it can take up to 1400 msec to mark request as failed. ## Upgrade Notes Does this PR prevent a zero d

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6878: JSON column datatype support.

amrishlal commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628450306 ## File path: pinot-core/src/test/java/org/apache/pinot/core/transport/QueryRoutingTest.java ## @@ -211,7 +211,7 @@ public void testServerDown(

[GitHub] [incubator-pinot] amrishlal commented on pull request #6893: Fix flaky test

amrishlal commented on pull request #6893: URL: https://github.com/apache/incubator-pinot/pull/6893#issuecomment-834713572 @Jackie-Jiang @siddharthteotia Please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-pinot] desaijay230592 commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

desaijay230592 commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r628467875 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/environmentprovider/PinotEnvironmentProvider.java ## @@ -0,0 +1,43 @@ +/** + *

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6892: add shell-script for quickstart auth

codecov-commenter commented on pull request #6892: URL: https://github.com/apache/incubator-pinot/pull/6892#issuecomment-834731876 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6892?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6893: Fix flaky test

codecov-commenter commented on pull request #6893: URL: https://github.com/apache/incubator-pinot/pull/6893#issuecomment-834734222 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6893?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6877: Enhance JSON index to support nested array

amrishlal commented on a change in pull request #6877: URL: https://github.com/apache/incubator-pinot/pull/6877#discussion_r628472654 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonMatchQueriesTest.java ## @@ -0,0 +1,199 @@ +/** + * Licensed to the Apache

[GitHub] [incubator-pinot] richardstartin commented on a change in pull request #6886: Adjust threadCpuTime calculation

richardstartin commented on a change in pull request #6886: URL: https://github.com/apache/incubator-pinot/pull/6886#discussion_r628473211 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/InstanceResponseOperator.java ## @@ -45,8 +46,39 @@ protected Instan

[GitHub] [incubator-pinot] richardstartin commented on a change in pull request #6886: Adjust threadCpuTime calculation

richardstartin commented on a change in pull request #6886: URL: https://github.com/apache/incubator-pinot/pull/6886#discussion_r628477390 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/InstanceResponseOperator.java ## @@ -45,8 +46,39 @@ protected Instan

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6878: JSON column datatype support.

amrishlal commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628488178 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonDatatypeTest.java ## @@ -0,0 +1,308 @@ +/** + * Licensed to the Apache Soft

[GitHub] [incubator-pinot] desaijay230592 commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

desaijay230592 commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r628488447 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java ## @@ -261,12 +270,39 @@ private vo

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6878: JSON column datatype support.

amrishlal commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628488701 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonDatatypeTest.java ## @@ -0,0 +1,308 @@ +/** + * Licensed to the Apache Soft

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6878: JSON column datatype support.

amrishlal commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628488178 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonDatatypeTest.java ## @@ -0,0 +1,308 @@ +/** + * Licensed to the Apache Soft

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6878: JSON column datatype support.

amrishlal commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628493077 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonDatatypeTest.java ## @@ -0,0 +1,308 @@ +/** + * Licensed to the Apache Soft

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6887: Remove realtime segment metrics if it's destroyed

mcvsubbu commented on a change in pull request #6887: URL: https://github.com/apache/incubator-pinot/pull/6887#discussion_r628489699 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java ## @@ -462,16 +463,48 @@ public void addCallbackGa

[GitHub] [incubator-pinot] awishnick opened a new issue #6894: Confusing errors when trying to ingest Parquet files compressed with ZSTD

awishnick opened a new issue #6894: URL: https://github.com/apache/incubator-pinot/issues/6894 I tried to run a SegmentCreation job to ingest some Parquet files written by Trino. I got some confusing error messages that made it look like the file was corrupted. It turns out that this is be

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

mcvsubbu commented on a change in pull request #6890: URL: https://github.com/apache/incubator-pinot/pull/6890#discussion_r628548807 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -2117,6 +2117,17 @@ pub

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6891: Allow multiple alias for the same selection column.

jtao15 commented on a change in pull request #6891: URL: https://github.com/apache/incubator-pinot/pull/6891#discussion_r628564212 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java ## @@ -91,7 +91,8 @@ private static void update

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6891: Allow multiple alias for the same selection column.

jtao15 commented on a change in pull request #6891: URL: https://github.com/apache/incubator-pinot/pull/6891#discussion_r628564298 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/AliasQueriesTest.java ## @@ -0,0 +1,249 @@ +/** + * Licensed to the Apache Softwar

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6893: Fix flaky test

Jackie-Jiang commented on a change in pull request #6893: URL: https://github.com/apache/incubator-pinot/pull/6893#discussion_r628564151 ## File path: pinot-core/src/test/java/org/apache/pinot/core/transport/QueryRoutingTest.java ## @@ -187,6 +187,9 @@ public void testNonMatch

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6877: Enhance JSON index to support nested array

Jackie-Jiang commented on a change in pull request #6877: URL: https://github.com/apache/incubator-pinot/pull/6877#discussion_r628572042 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonMatchQueriesTest.java ## @@ -0,0 +1,199 @@ +/** + * Licensed to the Apac

[GitHub] [incubator-pinot] xiangfu0 commented on issue #6894: Confusing errors when trying to ingest Parquet files compressed with ZSTD

xiangfu0 commented on issue #6894: URL: https://github.com/apache/incubator-pinot/issues/6894#issuecomment-834822896 Have you tried using `org.apache.pinot.plugin.inputformat.parquet.ParquetNativeRecordReader` as record reader? It's using native parquet reader. Meanwhile we can look at ho

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6877: Enhance JSON index to support nested array

Jackie-Jiang commented on a change in pull request #6877: URL: https://github.com/apache/incubator-pinot/pull/6877#discussion_r628572042 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonMatchQueriesTest.java ## @@ -0,0 +1,199 @@ +/** + * Licensed to the Apac

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6892: add shell-script for quickstart auth

Jackie-Jiang merged pull request #6892: URL: https://github.com/apache/incubator-pinot/pull/6892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6891: Allow multiple alias for the same selection column.

Jackie-Jiang commented on a change in pull request #6891: URL: https://github.com/apache/incubator-pinot/pull/6891#discussion_r628581113 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java ## @@ -91,10 +91,7 @@ private static void

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6878: JSON column datatype support.

Jackie-Jiang commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628585502 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonDatatypeTest.java ## @@ -0,0 +1,308 @@ +/** + * Licensed to the Apache S

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6878: JSON column datatype support.

amrishlal commented on a change in pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#discussion_r628589659 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonDatatypeTest.java ## @@ -0,0 +1,308 @@ +/** + * Licensed to the Apache Soft

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

codecov-commenter commented on pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#issuecomment-834835328 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6842?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6891: Allow multiple alias for the same selection column.

codecov-commenter edited a comment on pull request #6891: URL: https://github.com/apache/incubator-pinot/pull/6891#issuecomment-834125903 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6891?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6877: Enhance JSON index to support nested array

codecov-commenter edited a comment on pull request #6877: URL: https://github.com/apache/incubator-pinot/pull/6877#issuecomment-832402698 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6877?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6877: Enhance JSON index to support nested array

amrishlal commented on a change in pull request #6877: URL: https://github.com/apache/incubator-pinot/pull/6877#discussion_r628602361 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonMatchQueriesTest.java ## @@ -0,0 +1,199 @@ +/** + * Licensed to the Apache

[GitHub] [incubator-pinot] mcvsubbu commented on pull request #6893: Fix flaky test

mcvsubbu commented on pull request #6893: URL: https://github.com/apache/incubator-pinot/pull/6893#issuecomment-834852938 I am a little confused by this test. How can we guarantee that the `queryServer.shutDown()` happens before the query actually makes it to the server? -- This is an

[GitHub] [incubator-pinot] apucher merged pull request #6884: filter out javaagent from generator.sh JAVA_OPTS

apucher merged pull request #6884: URL: https://github.com/apache/incubator-pinot/pull/6884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6893: Fix flaky test

amrishlal commented on a change in pull request #6893: URL: https://github.com/apache/incubator-pinot/pull/6893#discussion_r628610393 ## File path: pinot-core/src/test/java/org/apache/pinot/core/transport/QueryRoutingTest.java ## @@ -187,6 +187,9 @@ public void testNonMatching

[GitHub] [incubator-pinot] amrishlal commented on pull request #6893: Fix flaky test

amrishlal commented on pull request #6893: URL: https://github.com/apache/incubator-pinot/pull/6893#issuecomment-834862009 > I am a little confused by this test. How can we guarantee that the `queryServer.shutDown()` happens before the query actually makes it to the server? `querySe

[GitHub] [incubator-pinot] amrishlal edited a comment on pull request #6893: Fix flaky test

amrishlal edited a comment on pull request #6893: URL: https://github.com/apache/incubator-pinot/pull/6893#issuecomment-834862009 > I am a little confused by this test. How can we guarantee that the `queryServer.shutDown()` happens before the query actually makes it to the server? `

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6877: Enhance JSON index to support nested array

Jackie-Jiang commented on a change in pull request #6877: URL: https://github.com/apache/incubator-pinot/pull/6877#discussion_r628619787 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/JsonMatchQueriesTest.java ## @@ -0,0 +1,199 @@ +/** + * Licensed to the Apac

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6893: Fix flaky test

Jackie-Jiang merged pull request #6893: URL: https://github.com/apache/incubator-pinot/pull/6893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6891: Allow multiple alias for the same selection column.

snleee commented on a change in pull request #6891: URL: https://github.com/apache/incubator-pinot/pull/6891#discussion_r628619949 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/selection/SelectionOperatorUtils.java ## @@ -464,21 +464,40 @@ public static Se

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6891: Allow multiple alias for the same selection column.

snleee commented on a change in pull request #6891: URL: https://github.com/apache/incubator-pinot/pull/6891#discussion_r628619949 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/selection/SelectionOperatorUtils.java ## @@ -464,21 +464,40 @@ public static Se

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6883: Validate DISTINCT query when convert Calcite tree into PinotQuery

Jackie-Jiang merged pull request #6883: URL: https://github.com/apache/incubator-pinot/pull/6883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6877: Enhance JSON index to support nested array

codecov-commenter edited a comment on pull request #6877: URL: https://github.com/apache/incubator-pinot/pull/6877#issuecomment-832402698 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6877?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6886: Adjust threadCpuTime calculation

mcvsubbu commented on a change in pull request #6886: URL: https://github.com/apache/incubator-pinot/pull/6886#discussion_r628636851 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/InstanceResponseOperator.java ## @@ -45,8 +46,39 @@ protected InstanceResp

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6886: Adjust threadCpuTime calculation

mcvsubbu commented on a change in pull request #6886: URL: https://github.com/apache/incubator-pinot/pull/6886#discussion_r628637817 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/InstanceResponseOperator.java ## @@ -45,8 +46,39 @@ protected InstanceResp

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6886: Adjust threadCpuTime calculation

siddharthteotia commented on a change in pull request #6886: URL: https://github.com/apache/incubator-pinot/pull/6886#discussion_r628638182 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/InstanceResponseOperator.java ## @@ -45,8 +46,39 @@ protected Insta

[GitHub] [incubator-pinot] xiangfu0 commented on pull request #6889: fix integration tests for kafka ports

xiangfu0 commented on pull request #6889: URL: https://github.com/apache/incubator-pinot/pull/6889#issuecomment-834907244 > I don't fully understand the intention of this PR. Do we want to pick the port from a random kafka server, or kafka might change the passed-in port if it is unavailab

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6869: Add segment size rule to Recommendation Engine

sajjad-moradi commented on a change in pull request #6869: URL: https://github.com/apache/incubator-pinot/pull/6869#discussion_r628640366 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/impl/PinotTablePartitionRule.java ## @@ -119,12

[GitHub] [incubator-pinot] xiangfu0 merged pull request #6889: fix integration tests for kafka ports

xiangfu0 merged pull request #6889: URL: https://github.com/apache/incubator-pinot/pull/6889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6869: Add segment size rule to Recommendation Engine

sajjad-moradi commented on a change in pull request #6869: URL: https://github.com/apache/incubator-pinot/pull/6869#discussion_r628640546 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/io/params/SegmentSizeRuleParams.java ## @@ -0,0

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6869: Add segment size rule to Recommendation Engine

sajjad-moradi commented on a change in pull request #6869: URL: https://github.com/apache/incubator-pinot/pull/6869#discussion_r628640710 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/RulesToExecute.java ## @@ -160,9 +169,14 @@ publ

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6869: Add segment size rule to Recommendation Engine

sajjad-moradi commented on a change in pull request #6869: URL: https://github.com/apache/incubator-pinot/pull/6869#discussion_r628640767 ## File path: pinot-controller/src/test/java/org/apache/pinot/controller/recommender/TestConfigEngine.java ## @@ -229,6 +230,10 @@ void tes

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6878: JSON column datatype support.

codecov-commenter edited a comment on pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#issuecomment-832453091 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6878?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

mcvsubbu commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r628638866 ## File path: pinot-plugins/pinot-environment/pinot-azure/src/main/java/org/apache/pinot/plugin/provider/AzureEnvironmentProvider.java ## @@ -0,

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6891: Allow multiple alias for the same selection column.

jtao15 commented on a change in pull request #6891: URL: https://github.com/apache/incubator-pinot/pull/6891#discussion_r628664205 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java ## @@ -91,10 +91,7 @@ private static void updat

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6891: Allow multiple alias for the same selection column.

jtao15 commented on a change in pull request #6891: URL: https://github.com/apache/incubator-pinot/pull/6891#discussion_r628665006 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/selection/SelectionOperatorUtils.java ## @@ -464,21 +464,40 @@ public static Se

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6878: JSON column datatype support.

codecov-commenter edited a comment on pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#issuecomment-832453091 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6878?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6891: Allow multiple alias for the same selection column.

codecov-commenter edited a comment on pull request #6891: URL: https://github.com/apache/incubator-pinot/pull/6891#issuecomment-834125903 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6891?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6878: JSON column datatype support.

codecov-commenter edited a comment on pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878#issuecomment-832453091 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6878?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] siddharthteotia merged pull request #6878: JSON column datatype support.

siddharthteotia merged pull request #6878: URL: https://github.com/apache/incubator-pinot/pull/6878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6891: Allow multiple alias for the same selection column.

snleee commented on a change in pull request #6891: URL: https://github.com/apache/incubator-pinot/pull/6891#discussion_r628707966 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/selection/SelectionOperatorUtils.java ## @@ -464,21 +464,50 @@ public static Se

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6869: Add segment size rule to Recommendation Engine

codecov-commenter edited a comment on pull request #6869: URL: https://github.com/apache/incubator-pinot/pull/6869#issuecomment-830205799 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6869?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6869: Add segment size rule to Recommendation Engine

codecov-commenter edited a comment on pull request #6869: URL: https://github.com/apache/incubator-pinot/pull/6869#issuecomment-830205799 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6869?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] troywinter opened a new pull request #6895: [fix] update table config show error msg on exception

troywinter opened a new pull request #6895: URL: https://github.com/apache/incubator-pinot/pull/6895 Problem to solve: Currently when updating a table config, api only return invalid table config, not showing any useful error msg, it's hard for user to debug without first request table

[GitHub] [incubator-pinot] apucher opened a new issue #6896: controller UI crashes if no brokers or servers online

apucher opened a new issue #6896: URL: https://github.com/apache/incubator-pinot/issues/6896 The controller UI crashes ungracefully to a white screen if all brokers are offline and/or all servers are offline. https://user-images.githubusercontent.com/25439965/117563140-bed25c80-b058-

  1   2   3   4   5   6   7   8   9   10   >