Jackie-Jiang commented on a change in pull request #6877:
URL: https://github.com/apache/incubator-pinot/pull/6877#discussion_r628388394
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/json/BaseJsonIndexCreator.java
##########
@@ -130,7 +132,7 @@ void addToPostingList(String value) {
void generateIndexFile()
throws IOException {
ByteBuffer headerBuffer = ByteBuffer.allocate(HEADER_LENGTH);
- headerBuffer.putInt(VERSION);
+ headerBuffer.putInt(VERSION_2);
Review comment:
No, v1 and v2 have different format, and the handling logic is also
slightly different (notice the delimiter for array access). That's why we need
to maintain the version info so that the new query can work on both v1 and v2
segments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
