jtao15 commented on a change in pull request #6891:
URL: https://github.com/apache/incubator-pinot/pull/6891#discussion_r628664205
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##########
@@ -91,10 +91,7 @@ private static void updateAlias(QueryContext queryContext,
BrokerResponseNative
if (resultTable == null) {
return;
}
- Map<ExpressionContext, String> aliasMap = queryContext.getAliasMap();
- if (aliasMap.isEmpty()) {
- return;
- }
+ List<String> aliasList = queryContext.getAliasList();
Review comment:
Yes, it's empty for PQL. Added it back to short circuit for PQL.
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
##########
@@ -1185,22 +1185,50 @@ public void testQueryWithOrderby()
}
@Test
- public void testQueryWithSameAlias()
+ public void testQueryWithAlias()
Review comment:
There are some other tests in the class to cover `select *`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
