amrishlal edited a comment on pull request #6893:
URL: https://github.com/apache/incubator-pinot/pull/6893#issuecomment-834862009
> I am a little confused by this test. How can we guarantee that the
`queryServer.shutDown()` happens before the query actually makes it to the
server?
`queryServer.shutDown()` appears to be blocking call that will block until
ChannelFuture completes or throws.
```
public void shutDown() {
try {
_channel.close().sync();
} catch (Exception e) {
throw new RuntimeException(e);
} finally {
_workerGroup.shutdownGracefully(0, 0, TimeUnit.SECONDS);
_bossGroup.shutdownGracefully(0, 0, TimeUnit.SECONDS);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
