snleee commented on a change in pull request #6891:
URL: https://github.com/apache/incubator-pinot/pull/6891#discussion_r628619949
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/selection/SelectionOperatorUtils.java
##########
@@ -464,21 +464,40 @@ public static SelectionResults
renderSelectionResultsWithoutOrdering(List<Object
*
* @param rows selection rows.
* @param dataSchema data schema.
+ * @param selectionColumns selection columns.
* @return {@link ResultTable} object results.
*/
- public static ResultTable renderResultTableWithoutOrdering(List<Object[]>
rows, DataSchema dataSchema) {
+ public static ResultTable renderResultTableWithoutOrdering(List<Object[]>
rows, DataSchema dataSchema, List<String> selectionColumns) {
Review comment:
Can we add some optimization by checking `selectionColumn` size and
`dataSchema`size?
If their sizes are equal, we don't need to go through the recreation of
objects. We will be able to save some memory resources there. Since this
happens for each query, it's good to add the optimization if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
