Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya merged PR #14110: URL: https://github.com/apache/pinot/pull/14110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895737941 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/CursorIntegrationTest.java: ## @@ -0,0 +1,432 @@ +/** + * Licensed to the Apache Software

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895725815 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895718634 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/CursorIntegrationTest.java: ## @@ -0,0 +1,432 @@ +/** + * Licensed to the Apache Software Fou

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895721154 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/CursorIntegrationTest.java: ## @@ -0,0 +1,432 @@ +/** + * Licensed to the Apache Software Fou

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895712004 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/CursorIntegrationTest.java: ## @@ -0,0 +1,432 @@ +/** + * Licensed to the Apache Software Fou

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895709178 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/CursorIntegrationTest.java: ## @@ -0,0 +1,432 @@ +/** + * Licensed to the Apache Software Fou

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895703900 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/CursorIntegrationTest.java: ## @@ -0,0 +1,432 @@ +/** + * Licensed to the Apache Software Fou

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895701574 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/cursors/MemoryResponseStore.java: ## @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Softwa

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895698268 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,248 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895411031 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/cursors/MemoryResponseStore.java: ## @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Sof

Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895341255 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundat

Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895335787 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,280 @@ +/** + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1895333851 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1301,4 +1308,25 @@ public static class NullValuePlaceHolder { public static fi

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1887888375 ## pinot-common/src/main/java/org/apache/pinot/common/cursors/AbstractResponseStore.java: ## @@ -0,0 +1,267 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1879664114 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -437,6 +456,22 @@ private BrokerResponse executeSqlQuery(ObjectNode s

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on PR #14110: URL: https://github.com/apache/pinot/pull/14110#issuecomment-2533647419 Pending discussions: - shared-nothing vs shared-storage - cursor response constructor - Naming - Response Store - Auth config param -- This is an automated message from the Ap

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on PR #14110: URL: https://github.com/apache/pinot/pull/14110#issuecomment-2533642293 I have added javadoc in `ResponseStore` to emphasis that there is a response store per broker and it is assumed that it is a shared-nothing storage. This is far more simpler and from exper

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1879342446 ## pinot-common/src/main/java/org/apache/pinot/common/cursors/AbstractResponseStore.java: ## @@ -0,0 +1,264 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1870711258 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1870717036 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1870698845 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -238,7 +238,7 @@ protected long writeResultTable(String requestId, ResultTable

Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1870671093 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundat

Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1870669987 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -238,7 +238,7 @@ protected long writeResultTable(String requestId, ResultTa

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1870667616 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,280 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1870666372 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,280 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1870665757 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,280 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1870664636 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,280 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1870623535 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,280 @@ +/** + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1870610780 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1870600576 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,280 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1869934097 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,280 @@ +/** + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1869921980 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,280 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1869482083 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestHandlerDelegate.java: ## @@ -138,4 +147,18 @@ public boolean cancelQuery(long queryId,

Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1869508969 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundat

Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1869570479 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundat

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1869560804 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1869553257 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1869510516 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundat

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1869435020 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,222 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1869353974 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestHandlerDelegate.java: ## @@ -138,4 +147,18 @@ public boolean cancelQuery(long queryI

Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1869179578 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,280 @@ +/** + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1869204243 ## pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java: ## @@ -190,6 +190,14 @@ public static boolean isUseMultistageEngine(Map queryO

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1869178991 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1301,4 +1308,25 @@ public static class NullValuePlaceHolder { public static final

Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1869102598 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1301,4 +1308,24 @@ public static class NullValuePlaceHolder { public static fi

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1868690070 ## pinot-spi/src/main/java/org/apache/pinot/spi/cursors/ResponseSerde.java: ## @@ -0,0 +1,63 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1868688947 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/ResponseStoreResource.java: ## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1868686862 ## pinot-spi/src/main/java/org/apache/pinot/spi/cursors/ResponseStore.java: ## @@ -0,0 +1,78 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1868682517 ## pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java: ## @@ -349,9 +355,31 @@ public void start() timeSeriesRequestHandler =

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1868675861 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/ResponseStoreResource.java: ## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1868151666 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/ResponseStoreResource.java: ## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1868096031 ## pinot-core/src/main/java/org/apache/pinot/core/auth/Actions.java: ## @@ -97,6 +97,8 @@ public static class Cluster { public static final String UPLOAD_SEGMENT =

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867901393 ## pinot-common/src/main/java/org/apache/pinot/common/cursors/AbstractResponseStore.java: ## @@ -0,0 +1,267 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867901393 ## pinot-common/src/main/java/org/apache/pinot/common/cursors/AbstractResponseStore.java: ## @@ -0,0 +1,267 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867820889 ## pinot-common/src/main/java/org/apache/pinot/common/cursors/AbstractResponseStore.java: ## @@ -0,0 +1,267 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867865858 ## pinot-spi/src/main/java/org/apache/pinot/spi/cursors/ResponseStoreService.java: ## @@ -0,0 +1,79 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867878322 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1301,4 +1308,25 @@ public static class NullValuePlaceHolder { public static final

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867873191 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1301,4 +1308,25 @@ public static class NullValuePlaceHolder { public static final

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867869494 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/cursors/MemoryResultStore.java: ## @@ -0,0 +1,136 @@ +/** + * Licensed to the Apache Software

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867864295 ## pinot-common/src/main/java/org/apache/pinot/common/response/broker/CursorResponseNative.java: ## @@ -0,0 +1,142 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867844851 ## pinot-common/src/main/java/org/apache/pinot/common/response/CursorResponse.java: ## @@ -0,0 +1,131 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867071321 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/ResponseStoreResource.java: ## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundati

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867842763 ## pinot-common/src/main/java/org/apache/pinot/common/cursors/AbstractResponseStore.java: ## @@ -0,0 +1,267 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867840255 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/ResponseStoreResource.java: ## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867838845 ## pinot-common/src/main/java/org/apache/pinot/common/cursors/AbstractResponseStore.java: ## @@ -0,0 +1,267 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867833121 ## pinot-common/src/main/java/org/apache/pinot/common/cursors/AbstractResponseStore.java: ## @@ -0,0 +1,267 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867833121 ## pinot-common/src/main/java/org/apache/pinot/common/cursors/AbstractResponseStore.java: ## @@ -0,0 +1,267 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867818616 ## pinot-common/src/main/java/org/apache/pinot/common/cursors/AbstractResponseStore.java: ## @@ -0,0 +1,267 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867819267 ## pinot-common/src/main/java/org/apache/pinot/common/cursors/AbstractResponseStore.java: ## @@ -0,0 +1,267 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867796226 ## pinot-common/src/main/java/org/apache/pinot/common/cursors/AbstractResponseStore.java: ## @@ -0,0 +1,267 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867785540 ## pinot-spi/src/main/java/org/apache/pinot/spi/cursors/ResponseStore.java: ## @@ -0,0 +1,78 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867781410 ## pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java: ## @@ -349,9 +355,31 @@ public void start() timeSeriesRequestHandler =

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867780726 ## pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java: ## @@ -349,9 +355,31 @@ public void start() timeSeriesRequestHandler =

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867773038 ## pinot-core/src/main/java/org/apache/pinot/core/auth/Actions.java: ## @@ -97,6 +97,8 @@ public static class Cluster { public static final String UPLOAD_SEGMENT =

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867770355 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/ResponseStoreResource.java: ## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867769661 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/ResponseStoreResource.java: ## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867758925 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/ResponseStoreResource.java: ## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867755115 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/ResponseStoreResource.java: ## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867747495 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/ResponseStoreResource.java: ## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1867743541 ## pinot-spi/src/main/java/org/apache/pinot/spi/cursors/ResponseStoreService.java: ## @@ -0,0 +1,79 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Add support for Cursors through API Query Params [pinot]

yashmayya commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1865823382 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/ResponseStoreResource.java: ## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundati

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on PR #14110: URL: https://github.com/apache/pinot/pull/14110#issuecomment-2461708969 All the failures for commit https://github.com/apache/pinot/pull/14110/commits/8b72aa8946aa77d903466458c1ad3aa43d2b94a9 are in ingestion tests and are unrelated to this feature. -- Thi

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on PR #14110: URL: https://github.com/apache/pinot/pull/14110#issuecomment-2461705885 > Partial review @gortiz @jackjlli Listing the open q.'s Design: - **ManualAuthorization to read response from response store.** I have implement authorization by using ta

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1827413506 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestHandlerDelegate.java: ## @@ -46,13 +50,23 @@ public class BrokerRequestHandlerDelegate

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1827409028 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/ResponseStoreResource.java: ## @@ -0,0 +1,190 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1819408284 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/ResponseStoreResource.java: ## @@ -0,0 +1,190 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

gortiz commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1810785289 ## pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java: ## @@ -346,9 +352,38 @@ public void start() timeSeriesRequestHandler =

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1810760189 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,206 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1810736996 ## pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java: ## @@ -346,9 +352,38 @@ public void start() timeSeriesRequestHandler =

Re: [PR] Add support for Cursors through API Query Params [pinot]

gortiz commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1810497932 ## pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java: ## @@ -346,9 +352,38 @@ public void start() timeSeriesRequestHandler =

Re: [PR] Add support for Cursors through API Query Params [pinot]

gortiz commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1810491866 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,206 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

gortiz commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1810470629 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809481301 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,206 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809482947 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809481882 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809482412 ## pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809480332 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,206 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809474593 ## pinot-controller/src/main/java/org/apache/pinot/controller/cursors/ResponseStoreCleaner.java: ## @@ -0,0 +1,206 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809420734 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1261,4 +1268,23 @@ public static class NullValuePlaceHolder { public static final

Re: [PR] Add support for Cursors through API Query Params [pinot]

vrajat commented on code in PR #14110: URL: https://github.com/apache/pinot/pull/14110#discussion_r1809406416 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1261,4 +1268,23 @@ public static class NullValuePlaceHolder { public static final

  1   2   >