vrajat commented on code in PR #14110:
URL: https://github.com/apache/pinot/pull/14110#discussion_r1867873191
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -1301,4 +1308,25 @@ public static class NullValuePlaceHolder {
public static final byte[][] BYTES_ARRAY = new byte[0][];
public static final Object MAP = Collections.emptyMap();
}
+
+ public static class CursorConfigs {
+ public static final String DEFAULT_RESPONSE_STORE_TYPE = "file";
+ public static final String DEFAULT_RESPONSE_SERDE = "json";
+ public static final int MAX_CURSOR_FETCH_ROWS = 100000;
+ public static final int DEFAULT_CURSOR_FETCH_ROWS = 10000;
+ public static final String DEFAULT_RESULTS_EXPIRATION_INTERVAL = "1h"; //
1 hour.
+ public static final String PREFIX_OF_CONFIG_OF_CURSOR =
"pinot.broker.cursor";
+ public static final String PREFIX_OF_CONFIG_OF_RESPONSE_STORE =
"pinot.broker.cursor.response.store";
+ public static final String RESPONSE_STORE_TYPE = "type";
+ public static final String RESPONSE_STORE_SERDE = "serde";
+ public static final String CURSOR_FETCH_ROWS = PREFIX_OF_CONFIG_OF_CURSOR
+ ".fetch.rows";
+ public static final String RESULTS_EXPIRATION_INTERVAL =
PREFIX_OF_CONFIG_OF_RESPONSE_STORE + ".expiration";
+
+ public static final String RESPONSE_STORE_CLEANER_FREQUENCY_PERIOD =
+ "controller.cluster.response.store.cleaner.frequencyPeriod";
+ public static final String DEFAULT_RESPONSE_STORE_CLEANER_FREQUENCY_PERIOD
= "1h";
+ public static final String RESPONSE_STORE_CLEANER_INITIAL_DELAY =
+ "controller.cluster.response.store.cleaner.initialDelay";
Review Comment:
I dont know the history why all periodic tasks have this config param. Agree
with the sentiment re: too many config params. However lets change any common
patterns outside this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
