vrajat commented on PR #14110:
URL: https://github.com/apache/pinot/pull/14110#issuecomment-2461705885

   > Partial review
   
   @gortiz @jackjlli Listing the open q.'s 
   
   Design:
   - **ManualAuthorization to read response from response store.** I have 
implement authorization by using tables queried in the request.
   - **SPI does not support reading partial responses.** Currently the SPI has 
been tried with a simple file system as backend. The SPI can be improved 
incrementally & made more complex when more sophisticated backends are used
   
   Rest are coding standards/craftmanship comments. I have either addressed or 
responded to the conversations. 
   
   PTAL when you get a chance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to