vrajat commented on code in PR #14110:
URL: https://github.com/apache/pinot/pull/14110#discussion_r1810736996
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -346,9 +352,38 @@ public void start()
timeSeriesRequestHandler = new TimeSeriesRequestHandler(_brokerConf,
brokerId, _routingManager,
_accessControlFactory, _queryQuotaManager, tableCache,
queryDispatcher);
}
+
+ LOGGER.info("Initializing PinotFSFactory");
+
PinotFSFactory.init(_brokerConf.subset(CommonConstants.Broker.PREFIX_OF_CONFIG_OF_PINOT_FS_FACTORY));
+
+ LOGGER.info("Initialize ResultStore");
+ PinotConfiguration resultStoreConfiguration =
+
_brokerConf.subset(CommonConstants.CursorConfigs.PREFIX_OF_CONFIG_OF_RESULT_STORE);
+ try {
+ ResponseSerde responseSerde =
ResponseSerdeService.getInstance().getResponseSerde(
+
resultStoreConfiguration.getProperty(CommonConstants.CursorConfigs.RESULT_STORE_SERDE,
+ CommonConstants.CursorConfigs.DEFAULT_RESULT_SERDE));
+
responseSerde.init(resultStoreConfiguration.subset(CommonConstants.CursorConfigs.RESULT_STORE_SERDE)
+ .subset(responseSerde.getType()));
+
+ String expirationTime =
getConfig().getProperty(CommonConstants.CursorConfigs.RESULTS_EXPIRATION_INTERVAL,
+ CommonConstants.CursorConfigs.DEFAULT_RESULTS_EXPIRATION_INTERVAL);
+
+ _resultStore = (AbstractResponseStore)
ResponseStoreService.getInstance().getResultStore(
Review Comment:
Removing `ResponseStore` will imply moving `ResponseStoreService` to
`pinot-common` as well. Also `ResponseStore` and `ResponseSerde` are a pair.
They should not be separated.
`ResponseStore` plugins have to depend on `pinot-common`. I have tried to
move `BrokerResponse`, `ResultTable` and `DataSchema` to SPI and it is too
disruptive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
