Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-15 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1984396711 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -655,6 +658,7 @@ public RebalanceResult rebalance(

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-14 Thread via GitHub
klsince merged PR #15110: URL: https://github.com/apache/pinot/pull/15110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-13 Thread via GitHub
klsince commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1994044837 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -55,40 +55,66 @@ public InstanceAssign

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-11 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1984396192 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -615,6 +615,9 @@ public RebalanceResult rebalance(

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-09 Thread via GitHub
somandal commented on PR #15110: URL: https://github.com/apache/pinot/pull/15110#issuecomment-2709255220 @J-HowHuang can you also add the new `minimizeDataMovement` option to `RebalanceTableCommand` and set it to `ENABLE` by default there as well? do validate it by running the command local

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-07 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1985895623 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -612,9 +612,9 @@ public RebalanceResult rebalance(

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-07 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1985901053 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceConfig.java: ## @@ -83,6 +83,13 @@ public class RebalanceConfig { @Api

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-07 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1985893639 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -612,9 +612,9 @@ public RebalanceResult rebalance(

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-07 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1985859192 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -615,6 +615,9 @@ public RebalanceResult rebalance(

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-07 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1985799022 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -55,40 +55,65 @@ public InstanceAssig

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-07 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1985774736 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -55,40 +55,65 @@ public InstanceAss

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-07 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1985795069 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceConfig.java: ## @@ -83,6 +83,13 @@ public class RebalanceConfig { @ApiMo

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-07 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1985796437 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -55,40 +55,65 @@ public InstanceAss

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-07 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1985795968 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -191,17 +191,21 @@ private RebalanceResult doRebalance(T

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-07 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1985790604 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -55,40 +55,65 @@ public InstanceAssig

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-07 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1985758187 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -55,40 +55,65 @@ public InstanceAss

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-07 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1985772549 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -191,17 +191,21 @@ private RebalanceResult doRebalance

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-07 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1985770339 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceConfig.java: ## @@ -83,6 +83,13 @@ public class RebalanceConfig { @Api

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-07 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1985741776 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceConfig.java: ## @@ -83,6 +83,13 @@ public class RebalanceConfig { @ApiMo

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-07 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1985760510 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -55,40 +55,65 @@ public InstanceAss

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-07 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1985759022 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentTest.java: ## @@ -51,9 +51,7 @@ import org.apache.pin

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-07 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1984400252 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -615,6 +615,9 @@ public RebalanceResult rebalance(

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-06 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1984400252 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -615,6 +615,9 @@ public RebalanceResult rebalance(

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-06 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1984407159 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -55,40 +55,64 @@ public InstanceAss

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-06 Thread via GitHub
Jackie-Jiang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1984335201 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -55,40 +55,64 @@ public InstanceA

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-06 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1984400252 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -615,6 +615,9 @@ public RebalanceResult rebalance(

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-06 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1984399204 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -615,6 +615,9 @@ public RebalanceResult rebalance(

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-06 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1984398264 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -55,40 +55,64 @@ public InstanceAssig

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-06 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1984378250 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -55,40 +55,64 @@ public InstanceAss

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-06 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1984345215 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -55,40 +55,64 @@ public InstanceAssig

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-06 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1984248686 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -55,40 +55,64 @@ public InstanceAss

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-04 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1979922019 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -55,40 +55,64 @@ public InstanceAss

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-03 Thread via GitHub
Jackie-Jiang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1978439542 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -55,40 +55,64 @@ public InstanceA

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-26 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1972443473 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerClusterStatelessTest.java: ## @@ -886,6 +886,226 @@ public void testR

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-26 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1972442713 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerClusterStatelessTest.java: ## @@ -886,6 +886,226 @@ public void testR

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-26 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1972440509 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerClusterStatelessTest.java: ## @@ -886,6 +886,226 @@ public void testR

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-26 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1972439379 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerClusterStatelessTest.java: ## @@ -886,6 +886,226 @@ public void testR

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-26 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1972438842 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerClusterStatelessTest.java: ## @@ -886,6 +886,226 @@ public void testR

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-26 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1972437026 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerClusterStatelessTest.java: ## @@ -886,6 +886,188 @@ public void testR

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-26 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1972435892 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerClusterStatelessTest.java: ## @@ -886,6 +886,188 @@ public void testR

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-26 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1972321929 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -55,40 +55,67 @@ public InstanceAss

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-26 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1972321436 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -1303,7 +1303,7 @@ private void handleLegacySchemaC

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-26 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1972316987 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentTest.java: ## @@ -504,6 +505,208 @@ public void testMi

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-26 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1972270210 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentTest.java: ## @@ -504,6 +505,208 @@ public void testMi

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-26 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1972269922 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerClusterStatelessTest.java: ## @@ -886,6 +886,188 @@ public void tes

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-26 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1972259795 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerClusterStatelessTest.java: ## @@ -886,6 +886,188 @@ public void tes

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-26 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1972258491 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerClusterStatelessTest.java: ## @@ -886,6 +886,188 @@ public void tes

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-26 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1972234452 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentTest.java: ## @@ -504,6 +505,208 @@ public void testMi

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-26 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1972101287 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -1303,7 +1303,7 @@ private void handleLegacySchemaCon

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-26 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1972069279 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -1303,7 +1303,7 @@ private void handleLegacySchemaC

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-25 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1970742135 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentTest.java: ## @@ -504,6 +505,208 @@ public void testMirr

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-25 Thread via GitHub
J-HowHuang commented on PR #15110: URL: https://github.com/apache/pinot/pull/15110#issuecomment-2683530503 > Is it possible to add a rebalance specific test case as well for the new flag? > > `OfflineClusterIntegrationTest` had some tests with dry-run, but can probably be enhance

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-25 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1970687275 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentTest.java: ## @@ -604,7 +814,8 @@ public void testMirr

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-25 Thread via GitHub
klsince commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1970330120 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentTest.java: ## @@ -604,7 +814,8 @@ public void testMirrorS

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-24 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1968634440 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -54,41 +54,44 @@ public InstanceAssig

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-24 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1968611873 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -54,41 +54,44 @@ public InstanceAss

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-24 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1968349627 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -54,41 +54,44 @@ public InstanceAssig

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-24 Thread via GitHub
codecov-commenter commented on PR #15110: URL: https://github.com/apache/pinot/pull/15110#issuecomment-2679977418 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15110?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-24 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1968483886 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -54,41 +54,44 @@ public InstanceAssig

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-24 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1968483886 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -54,41 +54,44 @@ public InstanceAssig

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-24 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1968443719 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -54,41 +54,44 @@ public InstanceAss

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-24 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1968443719 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -54,41 +54,44 @@ public InstanceAss

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-24 Thread via GitHub
somandal commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1968447325 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -54,41 +54,44 @@ public InstanceAssig

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-24 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1968443719 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -54,41 +54,44 @@ public InstanceAss

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-24 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1968433216 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceConfig.java: ## @@ -83,6 +83,12 @@ public class RebalanceConfig { @Api

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-24 Thread via GitHub
J-HowHuang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1968428441 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -54,41 +54,44 @@ public InstanceAss

[PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-02-21 Thread via GitHub
J-HowHuang opened a new pull request, #15110: URL: https://github.com/apache/pinot/pull/15110 Add new boolean property `minimizeDataMovement` to `org.apache.pinot.controller.helix.core.rebalance.RebalanceConfig`. This flag enforces [minimal data movement algorithm](https://docs.pinot.ap