somandal commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1984400252
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -615,6 +615,9 @@ public RebalanceResult rebalance(
@QueryParam("reassignInstances") boolean reassignInstances,
@ApiParam(value = "Whether to reassign CONSUMING segments for real-time
table") @DefaultValue("false")
@QueryParam("includeConsuming") boolean includeConsuming,
+ @ApiParam(value = "If `minimizeDataMovement` is set to false in the
table config, set this to true to enforce"
+ + " minimizeDataMovement during the rebalance.")
@DefaultValue("true")
+ @QueryParam("forceMinimizeDataMovement") boolean
forceMinimizeDataMovement,
Review Comment:
yeah that's also why it may be a better idea to allow the 3 values for this
flag: a) true -> set minimizeDataMovement, b) false -> don't set
minimizeDataMovement, c) none -> default to table config
it makes the expected behavior much clearer and captures the user's actual
intent. otherwise users will need to think about what's in table config. e.g.
say i set this to false, but it is true in table config, now have to change in
2 places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
