J-HowHuang commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1972316987
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentTest.java:
##########
@@ -504,6 +505,208 @@ public void testMirrorServerSetBasedRandom() throws
FileNotFoundException {
testMirrorServerSetBasedRandomInner(10000000);
}
+ @Test
+ public void testForceMinimizeDataMovement() {
Review Comment:
I think a balanced strategy table is not relevant here as this
`InstanceAssignmentTest` is under the context of an `InstanceAssignmentDriver`.
A balanced strategy table should never touch this part of code
(`InstanceAssignmentDriver`) and [the test
here](https://github.com/apache/pinot/pull/15110/files#diff-ae3bd7ea7215864e0439399375581799850e67a32c2d320d42f1d96f12ac6b71R890)
should be sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
