Re: [PR] Fix Direct Memory OOM on Server [pinot]

2025-04-04 Thread via GitHub
deepthi912 commented on code in PR #15335: URL: https://github.com/apache/pinot/pull/15335#discussion_r2010710648 ## pinot-core/src/main/java/org/apache/pinot/core/transport/QueryServer.java: ## @@ -138,6 +144,9 @@ protected void initChannel(SocketChannel ch) { c

(pinot) 01/01: Fix Null value for group by queries when no aggregate was called

2025-04-04 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch fix-array-agg-group-by in repository https://gitbox.apache.org/repos/asf/pinot.git commit 4254e0f9f15f9863ac8f605a172514686c859bee Author: jlli_LinkedIn AuthorDate: Thu Apr 3 15:05:07 2025 -0700

Re: [PR] Bump org.apache.commons:commons-csv from 1.13.0 to 1.14.0 [pinot]

2025-04-04 Thread via GitHub
gortiz merged PR #15328: URL: https://github.com/apache/pinot/pull/15328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

Re: [PR] Enhance rebalance progress stats [pinot]

2025-04-04 Thread via GitHub
somandal commented on code in PR #15266: URL: https://github.com/apache/pinot/pull/15266#discussion_r2029695528 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceProgressStats.java: ## @@ -118,6 +126,209 @@ public RebalanceStateStat

Re: [PR] Enhance rebalance progress stats [pinot]

2025-04-04 Thread via GitHub
somandal commented on code in PR #15266: URL: https://github.com/apache/pinot/pull/15266#discussion_r2029695759 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java: ## @@ -284,4 +319,253 @@ public static TableReb

Re: [PR] Enhance rebalance progress stats [pinot]

2025-04-04 Thread via GitHub
somandal commented on code in PR #15266: URL: https://github.com/apache/pinot/pull/15266#discussion_r2029695644 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceProgressStats.java: ## @@ -118,6 +126,209 @@ public RebalanceStateStat

Re: [PR] Enhance rebalance progress stats [pinot]

2025-04-04 Thread via GitHub
somandal commented on code in PR #15266: URL: https://github.com/apache/pinot/pull/15266#discussion_r2029695528 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceProgressStats.java: ## @@ -118,6 +126,209 @@ public RebalanceStateStat

Re: [PR] roundDecimal() fails for null FLOAT values [pinot]

2025-04-04 Thread via GitHub
mghildiy commented on code in PR #15377: URL: https://github.com/apache/pinot/pull/15377#discussion_r2029663779 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/RoundDecimalTransformFunction.java: ## @@ -90,8 +90,12 @@ public double[] transformToDoub

Re: [PR] roundDecimal() fails for null FLOAT values [pinot]

2025-04-04 Thread via GitHub
mghildiy commented on code in PR #15377: URL: https://github.com/apache/pinot/pull/15377#discussion_r2029663779 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/RoundDecimalTransformFunction.java: ## @@ -90,8 +90,12 @@ public double[] transformToDoub

Re: [PR] Add DISTINCT_COUNT_OFF_HEAP aggregate function [pinot]

2025-04-04 Thread via GitHub
codecov-commenter commented on PR #15469: URL: https://github.com/apache/pinot/pull/15469#issuecomment-2780127901 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15469?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Do not convert IN/NOT_IN to OR lists [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang closed pull request #15027: Do not convert IN/NOT_IN to OR lists URL: https://github.com/apache/pinot/pull/15027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Add DISTINCT_COUNT_OFF_HEAP aggregate function [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang opened a new pull request, #15469: URL: https://github.com/apache/pinot/pull/15469 Support calculating count of unique values using off-heap memory. For variable length types (e.g. `STRING`, `BYTES`), we use murmur3 hash (64 bits by default) to represent the value.

Re: [PR] Enhance rebalance progress stats [pinot]

2025-04-04 Thread via GitHub
J-HowHuang commented on code in PR #15266: URL: https://github.com/apache/pinot/pull/15266#discussion_r2029595112 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java: ## @@ -284,4 +319,253 @@ public static TableR

Re: [PR] Enhance rebalance progress stats [pinot]

2025-04-04 Thread via GitHub
J-HowHuang commented on code in PR #15266: URL: https://github.com/apache/pinot/pull/15266#discussion_r2029592306 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceProgressStats.java: ## @@ -118,6 +126,209 @@ public RebalanceStateSt

Re: [I] Fix critical CVEs in 1.3.0 [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang commented on issue #15453: URL: https://github.com/apache/pinot/issues/15453#issuecomment-2779912171 `1.3.0` should be using the following versions: avro: `1.11.4` (Last change #14148) async-http-client: `3.0.0` (Last change #13709) Can you check how the vulnerable d

Re: [PR] Moving dependency version declarations to maven properties [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang commented on code in PR #15437: URL: https://github.com/apache/pinot/pull/15437#discussion_r2029565885 ## pom.xml: ## @@ -1215,6 +1234,12 @@ pom import + + +com.google.api.grpc +proto-google-common-protos +

Re: [PR] Add per query stats to QuerySummary in pinot-tools QueryRunner [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang merged PR #15376: URL: https://github.com/apache/pinot/pull/15376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Moving dependency version declarations to maven properties [pinot]

2025-04-04 Thread via GitHub
leujean02 commented on code in PR #15437: URL: https://github.com/apache/pinot/pull/15437#discussion_r2029557091 ## pom.xml: ## @@ -1215,6 +1234,12 @@ pom import + + +com.google.api.grpc +proto-google-common-protos +$

Re: [I] [multistage] Sub-Optimal Plan for IN Clause When Used with OR [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang commented on issue #15442: URL: https://github.com/apache/pinot/issues/15442#issuecomment-2779908588 To debug this, you want to figure out if this is a bug from parser side, or optimizer side. IIRC, when combining `IN` with `OR`, Calcite directly parse the query into a quite we

Re: [PR] Moving dependency version declarations to maven properties [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang commented on code in PR #15437: URL: https://github.com/apache/pinot/pull/15437#discussion_r2029552651 ## pom.xml: ## @@ -1215,6 +1234,12 @@ pom import + + +com.google.api.grpc +proto-google-common-protos +

Re: [PR] Disables catch up when semaphore not acquired [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang commented on code in PR #15431: URL: https://github.com/apache/pinot/pull/15431#discussion_r2029551158 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1450,9 +1450,15 @@ public void goOnlineFromConsumin

Re: [PR] Disables catch up when semaphore not acquired [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang commented on PR #15431: URL: https://github.com/apache/pinot/pull/15431#issuecomment-2779903722 Please take a look at the test failures -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Moving dependency version declarations to maven properties [pinot]

2025-04-04 Thread via GitHub
leujean02 commented on PR #15437: URL: https://github.com/apache/pinot/pull/15437#issuecomment-2779898909 > Can you rebase it to the latest master? Seems like it is combining changes of some recent PRs Conflict Resolved @Jackie-Jiang -- This is an automated message from the Apache

Re: [PR] roundDecimal() fails for null FLOAT values [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang commented on code in PR #15377: URL: https://github.com/apache/pinot/pull/15377#discussion_r2029541976 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/RoundDecimalTransformFunction.java: ## @@ -90,18 +90,30 @@ public double[] transformT

Re: [PR] Bump com.google.cloud:libraries-bom from 26.57.0 to 26.58.0 [pinot]

2025-04-04 Thread via GitHub
tibrewalpratik17 merged PR #15414: URL: https://github.com/apache/pinot/pull/15414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@p

(pinot) branch master updated (401756e8e0 -> 8242f4e18d)

2025-04-04 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 401756e8e0 Bump software.amazon.awssdk:bom from 2.31.14 to 2.31.15 (#15465) add 8242f4e18d Add per query stats to

(pinot) branch dependabot/maven/io.netty-netty-bom-4.2.0.Final deleted (was 23584b2979)

2025-04-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/io.netty-netty-bom-4.2.0.Final in repository https://gitbox.apache.org/repos/asf/pinot.git was 23584b2979 Bump io.netty:netty-bom from 4.1.119.Final to 4.2.0.Final The

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.14 to 2.31.15 [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang merged PR #15465: URL: https://github.com/apache/pinot/pull/15465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.15 deleted (was 14ba039532)

2025-04-04 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.15 in repository https://gitbox.apache.org/repos/asf/pinot.git was 14ba039532 Bump software.amazon.awssdk:bom from 2.31.14 to 2.31.15 The r

Re: [PR] Bump io.netty:netty-bom from 4.1.119.Final to 4.2.0.Final [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang closed pull request #15464: Bump io.netty:netty-bom from 4.1.119.Final to 4.2.0.Final URL: https://github.com/apache/pinot/pull/15464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Moving dependency version declarations to maven properties [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang commented on PR #15437: URL: https://github.com/apache/pinot/pull/15437#issuecomment-2779887716 Can you rebase it to the latest master? Seems like it is combining changes of some recent PRs -- This is an automated message from the Apache Git Service. To respond to the message

(pinot) branch master updated (3a090f2e33 -> 401756e8e0)

2025-04-04 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 3a090f2e33 Ensure that minAvailableReplicas has an upper bound of existing numReplicas to fix infinite loop in rebalan

Re: [PR] Bump io.netty:netty-bom from 4.1.119.Final to 4.2.0.Final [pinot]

2025-04-04 Thread via GitHub
dependabot[bot] commented on PR #15464: URL: https://github.com/apache/pinot/pull/15464#issuecomment-277908 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

(pinot) branch master updated (37ec14d204 -> 3a090f2e33)

2025-04-04 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 37ec14d204 [multistage] Add Physical Plan Nodes / Trait Assignment / Logical Agg Rule (#15439) add 3a090f2e33 Ens

Re: [PR] Ensure that minAvailableReplicas has an upper bound of existing numReplicas to fix infinite loop in rebalance for StrictReplicaGroup assignment [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang merged PR #15468: URL: https://github.com/apache/pinot/pull/15468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [multistage] Add Physical Plan Nodes / Trait Assignment / Logical Agg Rule [pinot]

2025-04-04 Thread via GitHub
ankitsultana commented on code in PR #15439: URL: https://github.com/apache/pinot/pull/15439#discussion_r2029528655 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/v2/nodes/PhysicalAggregate.java: ## @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache

(pinot) branch master updated (1fc0cfe456 -> 37ec14d204)

2025-04-04 Thread ankitsultana
This is an automated email from the ASF dual-hosted git repository. ankitsultana pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 1fc0cfe456 Added support to apply record enrichers before complex transformations (#15359) add 37ec14d204 [

Re: [PR] [multistage] Add Physical Plan Nodes / Trait Assignment / Logical Agg Rule [pinot]

2025-04-04 Thread via GitHub
ankitsultana merged PR #15439: URL: https://github.com/apache/pinot/pull/15439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Enhance rebalance progress stats [pinot]

2025-04-04 Thread via GitHub
somandal commented on code in PR #15266: URL: https://github.com/apache/pinot/pull/15266#discussion_r2029524839 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceProgressStats.java: ## @@ -118,6 +128,165 @@ public RebalanceStateStat

Re: [PR] Enhance rebalance progress stats [pinot]

2025-04-04 Thread via GitHub
somandal commented on code in PR #15266: URL: https://github.com/apache/pinot/pull/15266#discussion_r2029525615 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java: ## @@ -284,4 +319,204 @@ public static TableReb

Re: [PR] Enhance rebalance progress stats [pinot]

2025-04-04 Thread via GitHub
somandal commented on code in PR #15266: URL: https://github.com/apache/pinot/pull/15266#discussion_r2029524674 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceProgressStats.java: ## @@ -19,33 +19,25 @@ package org.apache.pinot.c

Re: [PR] Add Tenants Info to Rebalance API summary [pinot]

2025-04-04 Thread via GitHub
J-HowHuang commented on code in PR #15284: URL: https://github.com/apache/pinot/pull/15284#discussion_r2004078548 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -670,6 +686,20 @@ private RebalanceSummaryResult calc

Re: [PR] Moving dependency version declarations to maven properties [pinot]

2025-04-04 Thread via GitHub
leujean02 commented on code in PR #15437: URL: https://github.com/apache/pinot/pull/15437#discussion_r2029500814 ## pom.xml: ## @@ -789,25 +808,37 @@ test-jar + + +org.apache.arrow +arrow-vector +${arrow.version} + +

Re: [PR] Moving dependency version declarations to maven properties [pinot]

2025-04-04 Thread via GitHub
leujean02 commented on code in PR #15437: URL: https://github.com/apache/pinot/pull/15437#discussion_r2029500490 ## pom.xml: ## @@ -271,6 +271,24 @@ 2.5.3 0.11.0-pre2 0.3.2 +3.49.2 +2.4.21 +2.0.2 +1.3.0 Review Comment: Addressed ## p

Re: [PR] Moving dependency version declarations to maven properties [pinot]

2025-04-04 Thread via GitHub
leujean02 commented on code in PR #15437: URL: https://github.com/apache/pinot/pull/15437#discussion_r2029500613 ## pom.xml: ## @@ -271,6 +271,24 @@ 2.5.3 0.11.0-pre2 0.3.2 +3.49.2 +2.4.21 +2.0.2 +1.3.0 +0.19.0 +8.5.15 +4.0.0 +2.4 +

Re: [PR] Moving dependency version declarations to maven properties [pinot]

2025-04-04 Thread via GitHub
leujean02 commented on code in PR #15437: URL: https://github.com/apache/pinot/pull/15437#discussion_r2029500337 ## pom.xml: ## @@ -792,22 +810,26 @@ org.checkerframework checker-qual -3.49.2 +${checker-qual.version} + Review Comment:

Re: [PR] Added support to apply record enrichers before complex transformations [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang merged PR #15359: URL: https://github.com/apache/pinot/pull/15359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (096ad7cdc2 -> 1fc0cfe456)

2025-04-04 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 096ad7cdc2 Make MSE leaf stage use cached TableConfig and Schema from TableDataManager (#15461) add 1fc0cfe456 Ad

Re: [PR] [multistage] Add Physical Plan Nodes / Trait Assignment / Logical Agg Rule [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang commented on code in PR #15439: URL: https://github.com/apache/pinot/pull/15439#discussion_r2029497571 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/v2/nodes/PhysicalAggregate.java: ## @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache

Re: [I] roundDecimal() fails for null FLOAT values [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang commented on issue #15255: URL: https://github.com/apache/pinot/issues/15255#issuecomment-2735030214 Thanks for reporting the issue. Have you tried this on a DOUBLE dimension with null values? Seems like the problem is from trying to parse `-Inf` as `BigDecimal`, but I don't kn

Re: [PR] Enhance rebalance progress stats [pinot]

2025-04-04 Thread via GitHub
somandal commented on code in PR #15266: URL: https://github.com/apache/pinot/pull/15266#discussion_r2029469316 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java: ## @@ -284,4 +319,253 @@ public static TableReb

Re: [PR] Ensure that minAvailableReplicas has an upper bound of existing numReplicas to fix infinite loop in rebalance for StrictReplicaGroup assignment [pinot]

2025-04-04 Thread via GitHub
codecov-commenter commented on PR #15468: URL: https://github.com/apache/pinot/pull/15468#issuecomment-2779773214 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15468?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Enhance rebalance progress stats [pinot]

2025-04-04 Thread via GitHub
J-HowHuang commented on code in PR #15266: URL: https://github.com/apache/pinot/pull/15266#discussion_r2029456703 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java: ## @@ -284,4 +319,253 @@ public static TableR

Re: [PR] Enhance rebalance progress stats [pinot]

2025-04-04 Thread via GitHub
J-HowHuang commented on code in PR #15266: URL: https://github.com/apache/pinot/pull/15266#discussion_r2029454774 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java: ## @@ -284,4 +319,253 @@ public static TableR

(pinot) branch master updated (667fba096f -> 096ad7cdc2)

2025-04-04 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 667fba096f Cache IndexLoadingConfig in TableDataManager (#15443) add 096ad7cdc2 Make MSE leaf stage use cached Tab

Re: [PR] Make MSE leaf stage use cached TableConfig and Schema from TableDataManager [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang merged PR #15461: URL: https://github.com/apache/pinot/pull/15461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Harmonize Pinot Dependency Management [pinot]

2025-04-04 Thread via GitHub
leujean02 closed pull request #15418: Harmonize Pinot Dependency Management URL: https://github.com/apache/pinot/pull/15418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [I] [spark connector] dependency conflict [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang closed issue #15320: [spark connector] dependency conflict URL: https://github.com/apache/pinot/issues/15320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[PR] Ensure that minAvailableReplicas has an upper bound of existing numReplicas to fix infinite loop for StrictReplicaGroup assignment [pinot]

2025-04-04 Thread via GitHub
somandal opened a new pull request, #15468: URL: https://github.com/apache/pinot/pull/15468 When running table rebalance, we need to specify the `minAvailableReplicas` to keep up as part of the rebalance. Internally we track the number of replicas based on the target assignment only which c

Re: [PR] Add Tenants Info to Rebalance API summary [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang commented on code in PR #15284: URL: https://github.com/apache/pinot/pull/15284#discussion_r2019080775 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -699,6 +723,28 @@ private RebalanceSummaryResult ca

Re: [PR] Bump com.dynatrace.hash4j:hash4j from 0.20.0 to 0.21.0 [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang merged PR #15426: URL: https://github.com/apache/pinot/pull/15426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Enhance rebalance progress stats [pinot]

2025-04-04 Thread via GitHub
somandal commented on code in PR #15266: URL: https://github.com/apache/pinot/pull/15266#discussion_r2029417170 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java: ## @@ -284,4 +319,253 @@ public static TableReb

Re: [PR] Add metrics for tracking zookeeper's max buffer size in services [pinot]

2025-04-04 Thread via GitHub
xiangfu0 merged PR #15380: URL: https://github.com/apache/pinot/pull/15380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Fix concern with uploaded segments leading to API failure [pinot]

2025-04-04 Thread via GitHub
KKcorps merged PR #15409: URL: https://github.com/apache/pinot/pull/15409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [PR] Fallback for bad values in periodic controller task configurations [pinot]

2025-04-04 Thread via GitHub
codecov-commenter commented on PR #15466: URL: https://github.com/apache/pinot/pull/15466#issuecomment-2779615101 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15466?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Enhance rebalance progress stats [pinot]

2025-04-04 Thread via GitHub
J-HowHuang commented on code in PR #15266: URL: https://github.com/apache/pinot/pull/15266#discussion_r2027413419 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceProgressStats.java: ## @@ -19,33 +19,25 @@ package org.apache.pinot

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.4 to 2.31.5 [pinot]

2025-04-04 Thread via GitHub
tibrewalpratik17 merged PR #15344: URL: https://github.com/apache/pinot/pull/15344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@p

[PR] Bump joda-time:joda-time from 2.13.1 to 2.14.0 [pinot]

2025-04-04 Thread via GitHub
dependabot[bot] opened a new pull request, #15417: URL: https://github.com/apache/pinot/pull/15417 Bumps [joda-time:joda-time](https://github.com/JodaOrg/joda-time) from 2.13.1 to 2.14.0. Release notes Sourced from https://github.com/JodaOrg/joda-time/releases";>joda-time:joda-time

Re: [PR] (Minor) fix logs [pinot]

2025-04-04 Thread via GitHub
noob-se7en commented on code in PR #15438: URL: https://github.com/apache/pinot/pull/15438#discussion_r2026873578 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -621,7 +621,7 @@ private void commitSegm

(pinot) branch master updated (3fce1ba865 -> b9447edd9e)

2025-04-04 Thread xbli
This is an automated email from the ASF dual-hosted git repository. xbli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 3fce1ba865 Remove mockito and bytebuddy warnings. (#15421) add b9447edd9e remove snapshotRWlock in upsert table part

Re: [PR] Consuming Rebalance Summary [pinot]

2025-04-04 Thread via GitHub
somandal commented on code in PR #15368: URL: https://github.com/apache/pinot/pull/15368#discussion_r2019835365 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java: ## @@ -306,18 +298,107 @@ public Map getServerSegmentC

Re: [PR] Bump com.azure:azure-sdk-bom from 1.2.32 to 1.2.33 [pinot]

2025-04-04 Thread via GitHub
tibrewalpratik17 merged PR #15412: URL: https://github.com/apache/pinot/pull/15412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@p

Re: [PR] Consuming Rebalance Summary [pinot]

2025-04-04 Thread via GitHub
J-HowHuang commented on code in PR #15368: URL: https://github.com/apache/pinot/pull/15368#discussion_r2025730873 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -140,10 +156,20 @@ public TableRebalancer(HelixManager

Re: [PR] Unblocks helix thread for online segment [pinot]

2025-04-04 Thread via GitHub
noob-se7en closed pull request #15246: Unblocks helix thread for online segment URL: https://github.com/apache/pinot/pull/15246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Extend POSSIBLE_QUERY_OPTIONS in PinotConnection to all query level o… [pinot]

2025-04-04 Thread via GitHub
chrajeshbabu commented on PR #15281: URL: https://github.com/apache/pinot/pull/15281#issuecomment-2738845281 @Jackie-Jiang could you pls review this. With this change all possible query options can be passed to pinot connection without explicitly specifying in possible options list. -- T

Re: [PR] switch log.debug to log.info on query request [pinot]

2025-04-04 Thread via GitHub
gortiz commented on PR #15264: URL: https://github.com/apache/pinot/pull/15264#issuecomment-2743114456 @mayankshriv The issue is that we have a normal slf4j log and a QueryLogger, which I'm not sure what is being used for. To me, it looks like an artifact for configuring some logging for qu

Re: [PR] Upgrade Calcite to 1.39.0 [pinot]

2025-04-04 Thread via GitHub
yashmayya commented on code in PR #15263: URL: https://github.com/apache/pinot/pull/15263#discussion_r2000856836 ## pinot-query-planner/src/test/resources/queries/JoinPlans.json: ## @@ -405,10 +405,10 @@ "\nLogicalProject(col1=[$0])", "\n LogicalJoin(condi

[PR] Bump com.dynatrace.hash4j:hash4j from 0.20.0 to 0.21.0 [pinot]

2025-04-04 Thread via GitHub
dependabot[bot] opened a new pull request, #15426: URL: https://github.com/apache/pinot/pull/15426 Bumps [com.dynatrace.hash4j:hash4j](https://github.com/dynatrace-oss/hash4j) from 0.20.0 to 0.21.0. Release notes Sourced from https://github.com/dynatrace-oss/hash4j/releases";>com.d

Re: [PR] (Minor) fix logs [pinot]

2025-04-04 Thread via GitHub
noob-se7en commented on code in PR #15438: URL: https://github.com/apache/pinot/pull/15438#discussion_r2026893885 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1066,13 +1066,14 @@ public void segment

Re: [I] Stream ingest breaks with a Confluent Json Schema [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang commented on issue #15262: URL: https://github.com/apache/pinot/issues/15262#issuecomment-2737926824 @r-reis Do you want to help contribute this feature? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

(pinot) branch dependabot/maven/com.puppycrawl.tools-checkstyle-10.23.0 updated (526e0af93b -> ae14b33d93)

2025-04-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.puppycrawl.tools-checkstyle-10.23.0 in repository https://gitbox.apache.org/repos/asf/pinot.git discard 526e0af93b Bump com.puppycrawl.tools:checkstyle from 10.22.0 to

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.4 created (now 9f7f804a36)

2025-04-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.4 in repository https://gitbox.apache.org/repos/asf/pinot.git at 9f7f804a36 Bump software.amazon.awssdk:bom from 2.31.3 to 2.31.4 No n

Re: [PR] [multistage] Add Physical Plan Nodes / Trait Assignment / Logical Agg Rule [pinot]

2025-04-04 Thread via GitHub
ankitsultana commented on code in PR #15439: URL: https://github.com/apache/pinot/pull/15439#discussion_r2029313208 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotLogicalAggregateRule.java: ## @@ -0,0 +1,198 @@ +/** + * Licensed to the Apache Softwa

Re: [PR] [multistage] Adding Basic Constructs for Physical Optimization [pinot]

2025-04-04 Thread via GitHub
itschrispeck commented on code in PR #15371: URL: https://github.com/apache/pinot/pull/15371#discussion_r2025237779 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/v2/PinotDataDistribution.java: ## @@ -0,0 +1,193 @@ +/** + * Licensed to the Apache So

Re: [PR] Simplify the Helix state model [pinot]

2025-04-04 Thread via GitHub
codecov-commenter commented on PR #15341: URL: https://github.com/apache/pinot/pull/15341#issuecomment-2742091892 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15341?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add getter for PreCheckContext [pinot]

2025-04-04 Thread via GitHub
codecov-commenter commented on PR #15339: URL: https://github.com/apache/pinot/pull/15339#issuecomment-2741913123 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15339?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Fallback for bad values in periodic controller task configurations [pinot]

2025-04-04 Thread via GitHub
ayesheepatra07 opened a new pull request, #15466: URL: https://github.com/apache/pinot/pull/15466 This change improves how the controller conf applies the values for periodic task configurations. Previously, invalid new configuration values were throwing exceptions and not letting the servi

[I] Fix critical CVEs in 1.3.0 [pinot]

2025-04-04 Thread via GitHub
piby180 opened a new issue, #15453: URL: https://github.com/apache/pinot/issues/15453 Hi all, We are using release 1.3.0 docker image with tag `release-1.3.0-21-amazoncorretto` Our Ops Team is complaining about two critical CVEs in pinot image. ![Image](https://github.

Re: [PR] [multistage] Add Physical Plan Nodes / Trait Assignment / Logical Agg Rule [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang commented on code in PR #15439: URL: https://github.com/apache/pinot/pull/15439#discussion_r2029293578 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotLogicalAggregateRule.java: ## @@ -0,0 +1,198 @@ +/** + * Licensed to the Apache Softwa

Re: [PR] Add more StartMinionCommand -config alias [pinot]

2025-04-04 Thread via GitHub
xiangfu0 merged PR #15307: URL: https://github.com/apache/pinot/pull/15307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Add support for orphan segment cleanup [pinot]

2025-04-04 Thread via GitHub
9aman commented on code in PR #15142: URL: https://github.com/apache/pinot/pull/15142#discussion_r2001093916 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java: ## @@ -55,6 +55,8 @@ public class SegmentsValidationAndRetentionCo

Re: [PR] Add metrics to track segment operation throttle thresholds and count of number of segments undergoing operation [pinot]

2025-04-04 Thread via GitHub
klsince commented on code in PR #15392: URL: https://github.com/apache/pinot/pull/15392#discussion_r202159 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/BaseSegmentOperationsThrottler.java: ## @@ -41,17 +46,22 @@ public abstract class BaseSegmentO

Re: [PR] remove snapshotRWlock in upsert table partition mgr [pinot]

2025-04-04 Thread via GitHub
codecov-commenter commented on PR #15420: URL: https://github.com/apache/pinot/pull/15420#issuecomment-2767265930 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15420?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch table_data_manager_cache_config created (now 078808af4c)

2025-04-04 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch table_data_manager_cache_config in repository https://gitbox.apache.org/repos/asf/pinot.git at 078808af4c Cache TableConfig and Schema in TableDataManager This branch includes the followin

Re: [PR] Enhance rebalance progress stats [pinot]

2025-04-04 Thread via GitHub
somandal commented on code in PR #15266: URL: https://github.com/apache/pinot/pull/15266#discussion_r2021943506 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceProgressStats.java: ## @@ -118,13 +129,107 @@ public RebalanceStateSta

Re: [PR] Substitute TransferableBlock with MseBlock [pinot]

2025-04-04 Thread via GitHub
gortiz commented on code in PR #15245: URL: https://github.com/apache/pinot/pull/15245#discussion_r2005330530 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/InMemorySendingMailbox.java: ## @@ -54,17 +58,28 @@ public boolean isLocal() { } @Override -

Re: [PR] Feature: New UI to monitor Rebalance Server Status [pinot]

2025-04-04 Thread via GitHub
klsince merged PR #15400: URL: https://github.com/apache/pinot/pull/15400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [PR] Improved retention management for hybrid tables [pinot]

2025-04-04 Thread via GitHub
Jackie-Jiang merged PR #15257: URL: https://github.com/apache/pinot/pull/15257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Fixes deleteSegmentsFromSequenceNum API [pinot]

2025-04-04 Thread via GitHub
codecov-commenter commented on PR #15430: URL: https://github.com/apache/pinot/pull/15430#issuecomment-2770881904 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15430?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Adds a new config to create a configurable JFR recording in continuous mode [pinot]

2025-04-04 Thread via GitHub
yashmayya commented on code in PR #15364: URL: https://github.com/apache/pinot/pull/15364#discussion_r2011690089 ## pinot-core/src/main/java/org/apache/pinot/core/util/trace/ContinuousJfrStarter.java: ## @@ -0,0 +1,164 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

  1   2   >