Jackie-Jiang commented on code in PR #15437:
URL: https://github.com/apache/pinot/pull/15437#discussion_r2029565885
##########
pom.xml:
##########
@@ -1215,6 +1234,12 @@
<type>pom</type>
<scope>import</scope>
</dependency>
+ <!-- com.google.api.grpc:proto-google-common-protos needs to appear
before com.google.cloud:libraries-bom -->
+ <dependency>
+ <groupId>com.google.api.grpc</groupId>
+ <artifactId>proto-google-common-protos</artifactId>
+ <version>${proto-google-common-protos.version}</version>
+ </dependency>
Review Comment:
Shall we open a different PR for that purpose since that is under a
different scope? Mixing them could make this change very hard to trace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
