gortiz commented on PR #15264: URL: https://github.com/apache/pinot/pull/15264#issuecomment-2743114456
@mayankshriv The issue is that we have a normal slf4j log and a QueryLogger, which I'm not sure what is being used for. To me, it looks like an artifact for configuring some logging for queries without using log4j. What the log4j2 file included Apache Pinot images (docker/images/pinot/etc/conf/pinot-broker-log4j2.xml) does is to send the logs from QueryLogger to a different file. This means these logs will not be included in the normal log file. Therefore, we should not see queries logged twice because of QueryLogger. We will see queries logged twice because we log the query along with the stats when the query finishes and once again when the query starts. In this case, we can remove the query from the final log, but again, I think that could bother third-party users who are relying on that log right now. In one of my pending PRs, I've added the ability to add the query into logger MDC, which means we can tune whether the query is logged or not using log4j2.xml. We can think about using that in the future instead of the current model, where any change we make on logs can affect other other Pinot deployments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
