gortiz commented on code in PR #15245:
URL: https://github.com/apache/pinot/pull/15245#discussion_r2005330530
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/InMemorySendingMailbox.java:
##########
@@ -54,17 +58,28 @@ public boolean isLocal() {
}
@Override
- public void send(TransferableBlock block)
+ public void send(MseBlock.Data data)
+ throws IOException, TimeoutException {
+ sendPrivate(data, Collections.emptyList());
Review Comment:
`List.of()` was introduced in Java 9. Some parts of the code need to be
compiled with Java 8 (basically to generate the driver). Does that mean I'm
using `Collections.emptyList()` when needed? No, honestly. I usually use
whatever copilot/Intellij autocomplete recommends, although I'm more used to
using `Collections.emptyList`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
