deepthi912 commented on code in PR #15335:
URL: https://github.com/apache/pinot/pull/15335#discussion_r2010710648
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/QueryServer.java:
##########
@@ -138,6 +144,9 @@ protected void initChannel(SocketChannel ch) {
ch.pipeline().addLast(ChannelHandlerFactory.getLengthFieldBasedFrameDecoder());
ch.pipeline().addLast(ChannelHandlerFactory.getLengthFieldPrepender());
ch.pipeline().addLast(_instanceRequestHandler);
+ ch.closeFuture().addListener(future -> {
+ _allChannels.remove(ch);
Review Comment:
They are closed, just made sure there are no channels that are present in
_allChannels when they get closed. I can also remove this actually since I am
anyway handling it in DirectOOMServerHandler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
