vrajat commented on PR #15374:
URL: https://github.com/apache/pinot/pull/15374#issuecomment-2774623347
> Instance type should already be included in `_instanceId` as a prefix. Do
you see the need of including it explicitly?
InstanceType is used here:
https://github.com/apache/pinot/b
vrajat commented on code in PR #15374:
URL: https://github.com/apache/pinot/pull/15374#discussion_r2026290810
##
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##
@@ -409,7 +409,8 @@ public void start()
_brokerConf.getProperty(C
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch new-site-dev
in repository https://gitbox.apache.org/repos/asf/pinot-site.git
The following commit(s) were added to refs/heads/new-site-dev by this push:
new c803bf95 Fix small layout issue
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch table_data_manager_cache_config
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 078808af4c92d417004684b44a90566d2b645991
Author: Xiaotian (Jackie) Jiang
AuthorDate: Wed Apr 2 1
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch table_data_manager_cache_config
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 078808af4c Cache TableConfig and Schema in TableDataManager
The revisions that were on this b
mghildiy commented on issue #15381:
URL: https://github.com/apache/pinot/issues/15381#issuecomment-2774512598
Panama is still not GA.
I would take a look at ByteBuf.
Manish
On Thu, 3 Apr, 2025, 10:30 am Siddharth Teotia, ***@***.***>
wrote:
> Is Project Panama o
siddharthteotia commented on issue #15381:
URL: https://github.com/apache/pinot/issues/15381#issuecomment-2774498064
Is Project Panama officially supported in a JDK ?
I would recommend looking at Netty's memory manager -- Pool based and Unpool
Apache Arrow uses Netty (for RPC as
siddharthteotia commented on PR #15205:
URL: https://github.com/apache/pinot/pull/15205#issuecomment-2774495155
@vvivekiyer - you may want to look at this and see how different is this
from our implementation. May be add that flavor as well since the PR already
has an interface ?
--
Thi
himanish-star commented on code in PR #15400:
URL: https://github.com/apache/pinot/pull/15400#discussion_r2026166219
##
pinot-controller/src/main/resources/app/components/Table.tsx:
##
@@ -562,7 +564,7 @@ export default function CustomizedTables({
) : (
codecov-commenter commented on PR #15438:
URL: https://github.com/apache/pinot/pull/15438#issuecomment-2773867624
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15438?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
itschrispeck opened a new issue, #15444:
URL: https://github.com/apache/pinot/issues/15444
We observe that server reads way more data than required on startup. From
the below screenshot, we see ~6TB of data read from disk upon server restart.
The servers have <400GB memory allocated, so it
codecov-commenter commented on PR #15443:
URL: https://github.com/apache/pinot/pull/15443#issuecomment-2774378435
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15443?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Jackie-Jiang opened a new pull request, #15443:
URL: https://github.com/apache/pinot/pull/15443
Cache `TableConfig` and `Schema` in `TableDataManager` to reduce ZK access
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
xiangfu0 merged PR #147:
URL: https://github.com/apache/pinot-site/pull/147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
ankitsultana opened a new issue, #15442:
URL: https://github.com/apache/pinot/issues/15442
This query generates an incorrect plan:
```
SET useMultistageEngine=true;
EXPLAIN PLAN FOR SELECT userUUID
FROM userAttributes
WHERE (deviceOS IN ('foo')
OR userUUID IN (
codecov-commenter commented on PR #15441:
URL: https://github.com/apache/pinot/pull/15441#issuecomment-2774115817
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15441?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
xiangfu0 merged PR #148:
URL: https://github.com/apache/pinot-site/pull/148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
gio-startree opened a new pull request, #148:
URL: https://github.com/apache/pinot-site/pull/148
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
codecov-commenter commented on PR #15439:
URL: https://github.com/apache/pinot/pull/15439#issuecomment-2773894626
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15439?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
xiangfu0 merged PR #15410:
URL: https://github.com/apache/pinot/pull/15410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2025686681
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##
@@ -306,18 +297,120 @@ public Map
getServerSegmen
Jackie-Jiang commented on code in PR #15438:
URL: https://github.com/apache/pinot/pull/15438#discussion_r2025681519
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##
@@ -621,7 +621,7 @@ private void commitSe
leujean02 commented on code in PR #15437:
URL: https://github.com/apache/pinot/pull/15437#discussion_r2025681522
##
pom.xml:
##
@@ -2137,6 +2175,7 @@
org.jacoco
jacoco-maven-plugin
+
Review Comment:
I added comments on Maven plugins for future
codecov-commenter commented on PR #15437:
URL: https://github.com/apache/pinot/pull/15437#issuecomment-2773855663
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15437?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Jackie-Jiang commented on code in PR #15281:
URL: https://github.com/apache/pinot/pull/15281#discussion_r2025660642
##
pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java:
##
@@ -84,7 +84,7 @@ public static Map
resolveCaseInsensitiveOptions(Ma
Jackie-Jiang commented on code in PR #15437:
URL: https://github.com/apache/pinot/pull/15437#discussion_r2025654555
##
pom.xml:
##
@@ -2137,6 +2175,7 @@
org.jacoco
jacoco-maven-plugin
+
Review Comment:
Is this correct?
##
pom.xml:
#
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2025668510
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -627,22 +644,42 @@ private RebalanceSummaryResult
cal
dang-stripe opened a new issue, #15440:
URL: https://github.com/apache/pinot/issues/15440
We ran into this error while restarting servers to reload segments. This
caused the servers to fail to startup.
```
[2025-04-01 20:24:22.723960] ERROR
[example_table_v1_OFFLINE-OfflineTableDa
Jackie-Jiang commented on code in PR #15374:
URL: https://github.com/apache/pinot/pull/15374#discussion_r2025657791
##
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##
@@ -409,7 +409,8 @@ public void start()
_brokerConf.getProp
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 84f30208b7 [multistage] Introducing dynamic filtering semi-join broker
level configuration (#15402)
add 9db
ankitsultana merged PR #15371:
URL: https://github.com/apache/pinot/pull/15371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
noob-se7en commented on code in PR #15438:
URL: https://github.com/apache/pinot/pull/15438#discussion_r2025647189
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##
@@ -621,7 +621,7 @@ private void commitSegm
noob-se7en commented on code in PR #15438:
URL: https://github.com/apache/pinot/pull/15438#discussion_r2025645868
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##
@@ -634,6 +634,8 @@ public File downloadSegment(SegmentZKMe
Jackie-Jiang commented on code in PR #15359:
URL: https://github.com/apache/pinot/pull/15359#discussion_r2025634977
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/CompositeTransformer.java:
##
@@ -87,20 +98,7 @@ public class CompositeTransf
xiangfu0 commented on code in PR #15410:
URL: https://github.com/apache/pinot/pull/15410#discussion_r2025630508
##
pom.xml:
##
@@ -789,6 +790,22 @@
test-jar
+
+org.apache.arrow
+arrow-vector
+${arrow.version}
+
+
+
Jackie-Jiang merged PR #15429:
URL: https://github.com/apache/pinot/pull/15429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
somandal commented on code in PR #15266:
URL: https://github.com/apache/pinot/pull/15266#discussion_r2025535644
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -1145,8 +1174,8 @@ static boolean isExternalViewConverge
leujean02 opened a new pull request, #15437:
URL: https://github.com/apache/pinot/pull/15437
I have started the work on the proposal outlined in the issue
[#12676](https://github.com/apache/pinot/issues/12676).
As a first step, I have start by moving dependency version declarations to
``
codecov-commenter commented on PR #15436:
URL: https://github.com/apache/pinot/pull/15436#issuecomment-2773649207
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15436?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
somandal commented on code in PR #15266:
URL: https://github.com/apache/pinot/pull/15266#discussion_r2025535969
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceObserver.java:
##
@@ -49,4 +52,29 @@ void onTrigger(Trigger trigger, M
somandal commented on code in PR #15266:
URL: https://github.com/apache/pinot/pull/15266#discussion_r2025535193
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java:
##
@@ -284,4 +328,306 @@ public static
TableReb
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2025480289
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -806,6 +864,157 @@ private List getServerTag(String se
J-HowHuang opened a new pull request, #15436:
URL: https://github.com/apache/pinot/pull/15436
## Description
Wrap the logger with `TableRebalanceLogger` to format the log messages in
rebalance-related logs.
The scope is at job level, namely each rebalance job will have its own
`T
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 84f30208b7 [multistage] Introducing dynamic
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/org.checkerframework-checker-qual-3.49.2
in repository https://gitbox.apache.org/repos/asf/pinot.git
was c8c6a79279 Bump org.checkerframework:checker-qual from 3.49.1 to 3.
ankitsultana merged PR #15402:
URL: https://github.com/apache/pinot/pull/15402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
klsince commented on code in PR #15266:
URL: https://github.com/apache/pinot/pull/15266#discussion_r2025372338
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceProgressStats.java:
##
@@ -118,6 +127,33 @@ public RebalanceStateStats
Jackie-Jiang commented on code in PR #15410:
URL: https://github.com/apache/pinot/pull/15410#discussion_r2025366657
##
pom.xml:
##
@@ -789,6 +790,22 @@
test-jar
+
+org.apache.arrow
+arrow-vector
+${arrow.version}
+
+
+
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 25ef4806fb make pinot task manager pluggable (#15
Jackie-Jiang merged PR #15432:
URL: https://github.com/apache/pinot/pull/15432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2025317896
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##
@@ -306,18 +297,120 @@ public Map
getServerSegmen
ankitsultana commented on code in PR #15371:
URL: https://github.com/apache/pinot/pull/15371#discussion_r2025364625
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/v2/ExchangeStrategy.java:
##
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache Software
J-HowHuang commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2025365472
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -806,6 +864,157 @@ private List getServerTag(String se
somandal commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2025325439
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##
@@ -306,18 +297,120 @@ public Map
getServerSegmentC
shauryachats commented on code in PR #15402:
URL: https://github.com/apache/pinot/pull/15402#discussion_r2025212485
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##
@@ -456,6 +456,9 @@ public static class Broker {
public static final String
CO
klsince commented on code in PR #15368:
URL: https://github.com/apache/pinot/pull/15368#discussion_r2025258481
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java:
##
@@ -306,18 +297,120 @@ public Map
getServerSegmentCh
raghavyadav01 commented on code in PR #15266:
URL: https://github.com/apache/pinot/pull/15266#discussion_r2021773303
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceProgressStats.java:
##
@@ -18,35 +18,28 @@
*/
package org.apac
This is an automated email from the ASF dual-hosted git repository.
kharekartik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 142fb45c82 Allow periodic tasks to run with
KKcorps merged PR #14915:
URL: https://github.com/apache/pinot/pull/14915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
dependabot[bot] closed pull request #15423: Bump software.amazon.awssdk:bom
from 2.31.11 to 2.31.12
URL: https://github.com/apache/pinot/pull/15423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dependabot[bot] opened a new pull request, #15434:
URL: https://github.com/apache/pinot/pull/15434
Bumps
[org.checkerframework:checker-qual](https://github.com/typetools/checker-framework)
from 3.49.1 to 3.49.2.
Release notes
Sourced from https://github.com/typetools/checker-frame
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.31.13
in repository https://gitbox.apache.org/repos/asf/pinot.git
at f2c0b22856 Bump software.amazon.awssdk:bom from 2.31.11 to 2.31.13
N
dependabot[bot] commented on PR #15423:
URL: https://github.com/apache/pinot/pull/15423#issuecomment-2772286912
Superseded by #15435.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.checkerframework-checker-qual-3.49.2
in repository https://gitbox.apache.org/repos/asf/pinot.git
at c8c6a79279 Bump org.checkerframework:checker-qual from 3.49.1 t
dependabot[bot] opened a new pull request, #15435:
URL: https://github.com/apache/pinot/pull/15435
Bumps software.amazon.awssdk:bom from 2.31.11 to 2.31.13.
Most Recent Ignore Conditions Applied to This Pull Request
| Dependency Name | Ignore Conditions |
| --- | --- |
codecov-commenter commented on PR #15433:
URL: https://github.com/apache/pinot/pull/15433#issuecomment-2772203727
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15433?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
himanish-star commented on code in PR #15400:
URL: https://github.com/apache/pinot/pull/15400#discussion_r2024546878
##
pinot-controller/src/main/resources/app/pages/TenantDetails.tsx:
##
@@ -445,6 +450,17 @@ const TenantPageDetails = ({ match }:
RouteComponentProps) => {
albertobastos opened a new pull request, #15433:
URL: https://github.com/apache/pinot/pull/15433
Adds a log trace whenever the broker includes any exception as part of the
query response.
This log trace is flagged with a Marker for easier filtering on Logging
configuration allowing t
himanish-star commented on code in PR #15400:
URL: https://github.com/apache/pinot/pull/15400#discussion_r2024546605
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServerStatusOp.tsx:
##
@@ -0,0 +1,128 @@
+/**
+ * Licensed to the Apache Softwa
himanish-star commented on code in PR #15400:
URL: https://github.com/apache/pinot/pull/15400#discussion_r2024545990
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServerStatusOp.tsx:
##
@@ -0,0 +1,128 @@
+/**
+ * Licensed to the Apache Softwa
himanish-star commented on code in PR #15400:
URL: https://github.com/apache/pinot/pull/15400#discussion_r2024443959
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServerStatusOp.tsx:
##
@@ -0,0 +1,128 @@
+/**
+ * Licensed to the Apache Softwa
himanish-star commented on code in PR #15400:
URL: https://github.com/apache/pinot/pull/15400#discussion_r2024465728
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServerStatusOp.tsx:
##
@@ -0,0 +1,128 @@
+/**
+ * Licensed to the Apache Softwa
gortiz commented on code in PR #15245:
URL: https://github.com/apache/pinot/pull/15245#discussion_r2024217488
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/BlockSplitter.java:
##
@@ -18,20 +18,80 @@
*/
package org.apache.pinot.query.runtime.blocks
gortiz commented on code in PR #15245:
URL: https://github.com/apache/pinot/pull/15245#discussion_r2024217488
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/BlockSplitter.java:
##
@@ -18,20 +18,80 @@
*/
package org.apache.pinot.query.runtime.blocks
gortiz commented on code in PR #15245:
URL: https://github.com/apache/pinot/pull/15245#discussion_r2024212697
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/MseBlock.java:
##
@@ -0,0 +1,178 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
gortiz commented on code in PR #15245:
URL: https://github.com/apache/pinot/pull/15245#discussion_r2024203526
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/RowHeapDataBlock.java:
##
@@ -0,0 +1,112 @@
+/**
+ * Licensed to the Apache Software Foundatio
76 matches
Mail list logo
