noob-se7en commented on code in PR #15438:
URL: https://github.com/apache/pinot/pull/15438#discussion_r2025645868


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -634,6 +634,8 @@ public File downloadSegment(SegmentZKMetadata zkMetadata)
       Thread.sleep(sleepTimeMs);
     }
 
+    _logger.error("Failed to download segment: {} after: {}ms.", segmentName, 
downloadTimeoutMs);

Review Comment:
   This log is required because there is no log printed on server logs if 
download fails.
   Only log on this is seeing below timeout exception log in helix logs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to