Jackie-Jiang commented on code in PR #15359:
URL: https://github.com/apache/pinot/pull/15359#discussion_r2025634977
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/CompositeTransformer.java:
##########
@@ -87,20 +98,7 @@ public class CompositeTransformer implements
RecordTransformer {
*/
public static List<RecordTransformer> getDefaultTransformers(TableConfig
tableConfig, Schema schema) {
Review Comment:
Let's add a TODO to integrate `ComplexTypeTransformer` into the
`CompositeTransformer`. We should also document that this method doesn't
include enrichers pre complex type transform
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/EnrichmentConfig.java:
##########
@@ -32,11 +32,16 @@ public class EnrichmentConfig extends BaseJsonConfig {
@JsonPropertyDescription("Enricher properties")
private final JsonNode _properties;
+ @JsonPropertyDescription("Record enricher type that is applied before
complex type transformation")
+ private final boolean _preComplexTypeRecordEnricher;
Review Comment:
(minor) Suggest renaming, same for other places
```suggestion
private final boolean _preComplexTypeTransform;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
