vrajat commented on PR #15374: URL: https://github.com/apache/pinot/pull/15374#issuecomment-2774623347
> Instance type should already be included in `_instanceId` as a prefix. Do you see the need of including it explicitly? InstanceType is used here: https://github.com/apache/pinot/blob/master/pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java#L665 I have to write code to: * Extrace instance string from `instanceId` * Convert to enum This is easier and less error prone. Also from the code, it is possible that it is not prefixed by `Broker_` or `Server_` ? I know it is rare that the instance id is overriden. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
